Bug#1041271: maildir-utils: public shared library shipped in maildir-utils binary package

2023-07-16 Thread Jeremy Sowden 
On 2023-07-16, at 20:11:30 +0100, Jeremy Sowden wrote:
> On 2023-07-16, at 13:59:43 -0300, David Bremner wrote:
> > I think that libguile-mu.* need to be either moved to a private
> > directory or to their own packages. I don't know enough about guile to
> > say which is better.
> 
> I think it probably wants to go into Guile's extensions directory:
> /usr/lib/${DEB_HOST_MULTIARCH}/guile-3.0/extensions.
> 
> For 1.8, I believe that will require something along the lines of:
> 
>   diff --git a/configure.ac b/configure.ac
>   index 5e44d5d168f9..f99a5cf5c169 100644
>   --- a/configure.ac
>   +++ b/configure.ac
>   @@ -211,6 +211,7 @@ AS_IF([test "x$enable_guile" != "xno"],[
>  GUILE_PKG([3.0 2.2])
>  GUILE_PROGS
>  GUILE_FLAGS
>   +  GUILE_SITE_DIR
>  AC_DEFINE_UNQUOTED([GUILE_BINARY],"$GUILE",[guile binary])
>  vsnarf=guile-snarf${GUILE_EFFECTIVE_VERSION}
>  AC_CHECK_PROGS(GUILE_SNARF,[${vsnarf} guile-snarf], [no])
>   diff --git a/guile/Makefile.am b/guile/Makefile.am
>   index dd911087ded7..992e929c1fdc 100644
>   --- a/guile/Makefile.am
>   +++ b/guile/Makefile.am
>   @@ -42,7 +42,8 @@ AM_CXXFLAGS=  \
>   -Wno-missing-declarations   \
>   -Wno-suggest-attribute=noreturn
>
>   -lib_LTLIBRARIES=   \
>   +guile_extensionsdir = $(GUILE_EXTENSION)
>   +guile_extensions_LTLIBRARIES = \
>   libguile-mu.la
>
>libguile_mu_la_SOURCES=\
> 
> I'll create another MR once I've tested it.

https://salsa.debian.org/emacsen-team/maildir-utils/-/merge_requests/3

J.


signature.asc
Description: PGP signature

Bug#1041271: maildir-utils: public shared library shipped in maildir-utils binary package

2023-07-16 Thread Jeremy Sowden 
On 2023-07-16, at 13:59:43 -0300, David Bremner wrote:
> Package: maildir-utils
> Version: 1.8.14-2
> Severity: serious
> Justification: violates policy 8.1
> 
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
> 
> I think that libguile-mu.* need to be either moved to a private
> directory or to their own packages. I don't know enough about guile to
> say which is better.

I think it probably wants to go into Guile's extensions directory:
/usr/lib/${DEB_HOST_MULTIARCH}/guile-3.0/extensions.

For 1.8, I believe that will require something along the lines of:

  diff --git a/configure.ac b/configure.ac
  index 5e44d5d168f9..f99a5cf5c169 100644
  --- a/configure.ac
  +++ b/configure.ac
  @@ -211,6 +211,7 @@ AS_IF([test "x$enable_guile" != "xno"],[
 GUILE_PKG([3.0 2.2])
 GUILE_PROGS
 GUILE_FLAGS
  +  GUILE_SITE_DIR
 AC_DEFINE_UNQUOTED([GUILE_BINARY],"$GUILE",[guile binary])
 vsnarf=guile-snarf${GUILE_EFFECTIVE_VERSION}
 AC_CHECK_PROGS(GUILE_SNARF,[${vsnarf} guile-snarf], [no])
  diff --git a/guile/Makefile.am b/guile/Makefile.am
  index dd911087ded7..992e929c1fdc 100644
  --- a/guile/Makefile.am
  +++ b/guile/Makefile.am
  @@ -42,7 +42,8 @@ AM_CXXFLAGS=  \
  -Wno-missing-declarations   \
  -Wno-suggest-attribute=noreturn
   
  -lib_LTLIBRARIES=   \
  +guile_extensionsdir = $(GUILE_EXTENSION)
  +guile_extensions_LTLIBRARIES = \
  libguile-mu.la
   
   libguile_mu_la_SOURCES=\

I'll create another MR once I've tested it.

J.


signature.asc
Description: PGP signature

Bug#1041271: maildir-utils: public shared library shipped in maildir-utils binary package

2023-07-16 Thread David Bremner 
Package: maildir-utils
Version: 1.8.14-2
Severity: serious
Justification: violates policy 8.1

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

I think that libguile-mu.* need to be either moved to a private
directory or to their own packages. I don't know enough about guile to
say which is better.

- -- System Information:
Debian Release: trixie/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-7-amd64 (SMP w/20 CPU threads; PREEMPT)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages maildir-utils depends on:
ii  guile-3.0-libs  3.0.8-2
ii  libc6   2.37-3
ii  libgcc-s1   13.1.0-6
ii  libglib2.0-02.74.6-2
ii  libgmime-3.0-0  3.2.13+dfsg-2
ii  libreadline88.2-1.3
ii  libstdc++6  13.1.0-6
ii  libxapian30 1.4.22-1

maildir-utils recommends no packages.

maildir-utils suggests no packages.

- -- no debconf information

-BEGIN PGP SIGNATURE-

iQIzBAEBCAAdFiEEkiyHYXwaY0SiY6fqA0U5G1WqFSEFAmS0If4ACgkQA0U5G1Wq
FSFdlw//drvAFftKxrrn1Hk+A1wYL0ATPOgwI/61u3sC4P/uQRcTbC6zfJcO/uca
GJVFWaUHIFsmPr3lwQf6KkZweBtdnm38MXsXbxw7uBH5abEKoLPZCEr0FzArfZe/
CaPFMHgCl6/k25BNigIXUcx5rgvoLCjRYrh8RVvrIN/NWfEioYDYqYs4+ZEmswP3
fMOdoqfohtXlisfKrrI/ysK00gJpI0vWYJzdEcapirDy7eMtSBXOqjUz2a3kGJ/h
Oxtg1J1GCSp/pAb3lJvAojxITQI69ZAkX2T6xGqXUhGbRCKjVUulovI0iSQGbwM4
mKDMs5oH6kn8gM9z/HTUpoxhLE85KbMQjtsTx6MoXXZKPat02ipzloc3NqWQyBDj
pL8BEpnU6Hc0MtZLI6Q+gUG1akq5BmB24pKxrcEfAVRSdFXbOjfGIHjyH6achfcn
QwOz6R5kNte4VLfCOvWXhnsDvCeiOfePC/gaVqvvzJR5/iWMovDOdBTshK9uXWkl
3hgwYqRIYRtnKobz8QcOnqTbVxFiJv8gyaOm7cbhzKGfWeMFwv38mhmJXaRj7Znv
zb8MqG2eK89v8ZkD7RxsfVVOGOU94102QwlmQ6QOuB4etVyfuUkjjnRsjJgwSRE1
TtlYcHfIj8M2EgMPWEB2mjcFb/TKlx48+Br53YNk3z6mErYJtZk=
=HGuU
-END PGP SIGNATURE-