Bug#1052483: emacs-gtk: rcirc doesn't rejoin channels on reconnecting

2023-09-23 Thread Manphiz
FYI I seems to be able to convince the upstream to backport the fix to
29 branch, so it will be part of 29.2.  So please feel free to wait for
the next point release.

-- 
Manphiz



Bug#1052483: emacs-gtk: rcirc doesn't rejoin channels on reconnecting

2023-09-22 Thread Manphiz
control: tag -1 patch
control: forwarded -1 https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65882

Patch attached.

-- 
Manphiz

--- emacs-29.1+1.orig/lisp/net/rcirc.el
+++ emacs-29.1+1/lisp/net/rcirc.el
@@ -859,6 +859,7 @@ If QUIET is non-nil, no not emit a messa
   (if (rcirc--connection-open-p process)
   (throw 'exit (or quiet (message "Server process is alive")))
 (delete-process process))
+  (setq rcirc-user-authenticated nil)
   (let ((conn-info rcirc-connection-info))
 (setf (nth 5 conn-info)
   (cl-remove-if-not #'rcirc-channel-p


Bug#1052483: emacs-gtk: rcirc doesn't rejoin channels on reconnecting

2023-09-22 Thread Xiyue Deng
Package: emacs-gtk
Version: 1:29.1+1-5~bpo12+1manphiz1
Severity: normal
X-Debbugs-Cc: none, Xiyue Deng 

rcirc can be set up to automatically join a list of channels on
connecting to a server.  However, in case of network issue and rcirc
reconnecting to the server, it won't rejoin those channels.  A more
detailed analysis and fix can be found on the upstream bug.  I'll
provide the patch in a follow-up email.

Please note that the package version looks funny as it's built locally
with the patch to confirm it works.  It can be reproduced in the current
packaged 28.2 or 29.1 versions.


-- System Information:
Debian Release: 12.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-12-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages emacs-gtk depends on:
ii  emacs-bin-common 1:29.1+1-5~bpo12+1manphiz1
ii  emacs-common 1:29.1+1-5~bpo12+1manphiz1
ii  libacl1  2.3.1-3
ii  libasound2   1.2.8-1+b1
ii  libc62.36-9+deb12u1
ii  libcairo21.16.0-7
ii  libdbus-1-3  1.14.8-2~deb12u1
ii  libfontconfig1   2.14.1-4
ii  libfreetype6 2.12.1+dfsg-5
ii  libgccjit0   12.2.0-14
ii  libgdk-pixbuf-2.0-0  2.42.10+dfsg-1+b1
ii  libgif7  5.2.1-2.5
ii  libglib2.0-0 2.74.6-2
ii  libgmp10 2:6.2.1+dfsg1-1.1
ii  libgnutls30  3.7.9-2
ii  libgpm2  1.20.7-10+b1
ii  libgtk-3-0   3.24.37-2
ii  libharfbuzz0b6.0.0+dfsg-3
ii  libice6  2:1.0.10-1
ii  libjansson4  2.14-2
ii  libjpeg62-turbo  1:2.1.5-2
ii  liblcms2-2   2.14-2
ii  libm17n-01.8.0-6
ii  libotf1  0.9.16-4
ii  libpango-1.0-0   1.50.12+ds-1
ii  libpng16-16  1.6.39-2
ii  librsvg2-2   2.54.7+dfsg-1~deb12u1
ii  libselinux1  3.4-1+b6
ii  libsm6   2:1.2.3-1
ii  libsqlite3-0 3.40.1-2
ii  libsystemd0  252.12-1~deb12u1
ii  libtiff6 4.5.0-6
ii  libtinfo66.4-4
ii  libtree-sitter0  0.20.7-1
ii  libwebp7 1.2.4-0.2+deb12u1
ii  libwebpdemux21.2.4-0.2+deb12u1
ii  libx11-6 2:1.8.4-2+deb12u1
ii  libxcomposite1   1:0.4.5-1
ii  libxext6 2:1.3.4-1+b1
ii  libxfixes3   1:6.0.0-2
ii  libxi6   2:1.8-1+b1
ii  libxinerama1 2:1.1.4-3
ii  libxml2  2.9.14+dfsg-1.3~deb12u1
ii  libxrandr2   2:1.5.2-2+b1
ii  libxrender1  1:0.9.10-1.1
ii  zlib1g   1:1.2.13.dfsg-1

Versions of packages emacs-gtk recommends:
ii  fonts-noto-color-emoji  2.038-1

Versions of packages emacs-gtk suggests:
ii  emacs-common-non-dfsg  1:29.1+1-1~bpo12+0manphiz1

-- no debconf information