Bug#1053467: network-manager-openconnect-gnome: No option to specify UserAgent header in GUI
Hi Luca, On Tue, Nov 14, 2023 at 02:39:10PM +, Luca Boccassi wrote: > On Tue, 14 Nov 2023 at 14:01, Salvatore Bonaccorso wrote: > > > > Hi Luca, > > > > On Tue, Nov 14, 2023 at 01:25:41PM +, Luca Boccassi wrote: > > > On Tue, 14 Nov 2023 14:00:54 +0100 Salvatore Bonaccorso > > > wrote: > > > > Hi > > > > > > > > I parepared a backport of a series of three commits for it, for > > > > bookworm and have lightly tested it. It seems to work and as such I > > > > would like to propose an update for the upcoming point release. > > > > > > > > Luca, is this fine with you? Can you peer-review the debdiff? > > > > > > Hi, sounds good to me, but please send a MR on Salsa (without > > > d/changelog changes, I use gbp) - I've prepared a debian/bookworm > > > branch for this. Then I can do a p-u upload. > > > > Thanks! > > > > Here is the MR accordingly with the debian/changelog entries dropped: > > > > https://salsa.debian.org/debian/network-manager-openconnect/-/merge_requests/6 > > Uploaded to p-u - would you mind filing the release team bug for it, > please? That way you can add some details on how you tested it. > Thanks! Sure, will do. Thanks for the upload! Regards, Salvatore
Bug#1053467: network-manager-openconnect-gnome: No option to specify UserAgent header in GUI
On Tue, 14 Nov 2023 at 14:01, Salvatore Bonaccorso wrote: > > Hi Luca, > > On Tue, Nov 14, 2023 at 01:25:41PM +, Luca Boccassi wrote: > > On Tue, 14 Nov 2023 14:00:54 +0100 Salvatore Bonaccorso > > wrote: > > > Hi > > > > > > I parepared a backport of a series of three commits for it, for > > > bookworm and have lightly tested it. It seems to work and as such I > > > would like to propose an update for the upcoming point release. > > > > > > Luca, is this fine with you? Can you peer-review the debdiff? > > > > Hi, sounds good to me, but please send a MR on Salsa (without > > d/changelog changes, I use gbp) - I've prepared a debian/bookworm > > branch for this. Then I can do a p-u upload. > > Thanks! > > Here is the MR accordingly with the debian/changelog entries dropped: > > https://salsa.debian.org/debian/network-manager-openconnect/-/merge_requests/6 Uploaded to p-u - would you mind filing the release team bug for it, please? That way you can add some details on how you tested it. Thanks!
Bug#1053467: network-manager-openconnect-gnome: No option to specify UserAgent header in GUI
Hi Luca, On Tue, Nov 14, 2023 at 01:25:41PM +, Luca Boccassi wrote: > On Tue, 14 Nov 2023 14:00:54 +0100 Salvatore Bonaccorso > wrote: > > Hi > > > > I parepared a backport of a series of three commits for it, for > > bookworm and have lightly tested it. It seems to work and as such I > > would like to propose an update for the upcoming point release. > > > > Luca, is this fine with you? Can you peer-review the debdiff? > > Hi, sounds good to me, but please send a MR on Salsa (without > d/changelog changes, I use gbp) - I've prepared a debian/bookworm > branch for this. Then I can do a p-u upload. Thanks! Here is the MR accordingly with the debian/changelog entries dropped: https://salsa.debian.org/debian/network-manager-openconnect/-/merge_requests/6 Regards, Salvatore
Bug#1053467: network-manager-openconnect-gnome: No option to specify UserAgent header in GUI
On Tue, 14 Nov 2023 14:00:54 +0100 Salvatore Bonaccorso wrote: > Hi > > I parepared a backport of a series of three commits for it, for > bookworm and have lightly tested it. It seems to work and as such I > would like to propose an update for the upcoming point release. > > Luca, is this fine with you? Can you peer-review the debdiff? Hi, sounds good to me, but please send a MR on Salsa (without d/changelog changes, I use gbp) - I've prepared a debian/bookworm branch for this. Then I can do a p-u upload. -- Kind regards, Luca Boccassi signature.asc Description: This is a digitally signed message part
Bug#1053467: network-manager-openconnect-gnome: No option to specify UserAgent header in GUI
Hi
I parepared a backport of a series of three commits for it, for
bookworm and have lightly tested it. It seems to work and as such I
would like to propose an update for the upcoming point release.
Luca, is this fine with you? Can you peer-review the debdiff?
Regards,
Salvatore
diff -Nru network-manager-openconnect-1.2.8/debian/changelog
network-manager-openconnect-1.2.8/debian/changelog
--- network-manager-openconnect-1.2.8/debian/changelog 2022-05-21
15:35:15.0 +0200
+++ network-manager-openconnect-1.2.8/debian/changelog 2023-11-14
13:38:09.0 +0100
@@ -1,3 +1,13 @@
+network-manager-openconnect (1.2.8-3+deb12u1) bookworm; urgency=medium
+
+ * Non-maintainer upload.
+ * Add User Agent to Openconnect VPN for NetworkManager (Closes: #1053467)
+ * Use openconnect_set_useragent() where available
+ * Add support for GTK4 in user-agent calls
+ * Add Build-Depends on libgtk-4-bin for gtk4-builder-tool
+
+ -- Salvatore Bonaccorso Tue, 14 Nov 2023 13:38:09 +0100
+
network-manager-openconnect (1.2.8-3) unstable; urgency=medium
* Bump Standards-Version to 4.6.1, no changes
diff -Nru network-manager-openconnect-1.2.8/debian/control
network-manager-openconnect-1.2.8/debian/control
--- network-manager-openconnect-1.2.8/debian/control2022-05-21
15:35:15.0 +0200
+++ network-manager-openconnect-1.2.8/debian/control2023-11-14
13:38:09.0 +0100
@@ -8,6 +8,7 @@
libgcr-3-dev,
libglib2.0-dev,
libgtk-3-dev,
+ libgtk-4-bin,
libgtk-4-dev,
libnm-dev,
libnma-dev,
diff -Nru
network-manager-openconnect-1.2.8/debian/patches/0002-Add-User-Agent-to-Openconnect-VPN-for-NetworkManager.patch
network-manager-openconnect-1.2.8/debian/patches/0002-Add-User-Agent-to-Openconnect-VPN-for-NetworkManager.patch
---
network-manager-openconnect-1.2.8/debian/patches/0002-Add-User-Agent-to-Openconnect-VPN-for-NetworkManager.patch
1970-01-01 01:00:00.0 +0100
+++
network-manager-openconnect-1.2.8/debian/patches/0002-Add-User-Agent-to-Openconnect-VPN-for-NetworkManager.patch
2023-11-14 13:38:09.0 +0100
@@ -0,0 +1,302 @@
+From: Debasish Patra
+Date: Sat, 29 Aug 2020 17:58:16 -0400
+Subject: Add User Agent to Openconnect VPN for NetworkManager
+Origin:
https://gitlab.gnome.org/GNOME/NetworkManager-openconnect/-/commit/b5e154c06fd9013a925f85c2aa38d88e4ee53db0
+Bug-Debian: https://bugs.debian.org/1053467
+
+---
+ auth-dialog/main.c| 3 +-
+ properties/nm-openconnect-dialog.ui | 73 +--
+ properties/nm-openconnect-editor-plugin.c | 5 ++
+ properties/nm-openconnect-editor.c| 15 +
+ shared/nm-service-defines.h | 1 +
+ 5 files changed, 79 insertions(+), 18 deletions(-)
+
+diff --git a/auth-dialog/main.c b/auth-dialog/main.c
+index 99cab7cd921f..305b568650ba 100644
+--- a/auth-dialog/main.c
b/auth-dialog/main.c
+@@ -1853,6 +1853,7 @@ static void build_main_dialog(auth_ui_data *ui_data)
+
+ static auth_ui_data *init_ui_data (char *vpn_name, GHashTable *options,
GHashTable *secrets, char *vpn_uuid)
+ {
++ char *vpn_useragent = g_hash_table_lookup(options, "useragent");
+ auth_ui_data *ui_data;
+
+ ui_data = g_slice_new0(auth_ui_data);
+@@ -1883,7 +1884,7 @@ static auth_ui_data *init_ui_data (char *vpn_name,
GHashTable *options, GHashTab
+ g_unix_set_fd_nonblocking(ui_data->cancel_pipes[0], TRUE, NULL);
+ g_unix_set_fd_nonblocking(ui_data->cancel_pipes[1], TRUE, NULL);
+
+- ui_data->vpninfo = (void *)openconnect_vpninfo_new("OpenConnect VPN
Agent (NetworkManager)",
++ ui_data->vpninfo = (void *)openconnect_vpninfo_new(vpn_useragent ?:
"OpenConnect VPN Agent (NetworkManager)",
+ validate_peer_cert,
write_new_config,
+
nm_process_auth_form, write_progress,
+ ui_data);
+diff --git a/properties/nm-openconnect-dialog.ui
b/properties/nm-openconnect-dialog.ui
+index 43beb44a34a9..f32afcd5899f 100644
+--- a/properties/nm-openconnect-dialog.ui
b/properties/nm-openconnect-dialog.ui
+@@ -105,6 +105,45 @@
+ 2
+
+
++
++
++True
++_User Agent:
++True
++False
++GTK_JUSTIFY_LEFT
++False
++False
++1
++0.5
++user_agent_entry
++PANGO_ELLIPSIZE_NONE
++-1
++False
++
++
++0
++3
++
++
++
++
++True
++True
++True
++True
++0
++
++True
++
++False
++True
++
++
++1
++3
++
++
+
+
+ 13
+@@ -114,7 +153,7 @@
+
+
+ 0
+-3
++4
+ 2
+
+
Bug#1053467: network-manager-openconnect-gnome: No option to specify UserAgent header in GUI
Package: network-manager-openconnect-gnome Version: 1.2.6-4 Severity: wishlist Tags: patch X-Debbugs-Cc: f...@butterbrot.org Dear Maintainer, our Cisco VPN apparently got upgraded a few days ago and now requires a specific UserAgent header to still allow clients to connect, e.g. using the string "AnyConnect Windows 4.10.04071". There is an upstream patch that fixes this issue, adding a UI field for the user agent string: https://gitlab.gnome.org/GNOME/NetworkManager- openconnect/-/commit/b5e154c06fd9013a925f85c2aa38d88e4ee53db0 I've verified that this patch works on 1.2.6; I'd suggest to add this into at least buster-backports and bullseye-backports, and perhaps also into 1.2.8 on bookworm, if applicable (AFAICT this patch has not yet been merged upstream). Thanks and best, Florian -- System Information: Debian Release: bookworm/sid APT prefers jammy-updates APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), (100, 'jammy-backports') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.15.0-67-generic (SMP w/8 CPU threads) Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to de_DE.UTF-8), LANGUAGE=en_GB:en Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages network-manager-openconnect-gnome depends on: ii libc62.35-0ubuntu3.4 ii libgcr-base-3-1 3.40.0-4 ii libgcr-ui-3-13.40.0-4 ii libglib2.0-0 2.72.4-0ubuntu2.2 ii libgtk-3-0 3.24.33-1ubuntu2 ii libnm0 1.36.6-0ubuntu2 ii libopenconnect5 8.20-1 ii libsecret-1-00.20.5-2 ii libsoup2.4-1 2.74.2-3 ii libwebkit2gtk-4.0-37 2.40.5-0ubuntu0.22.04.1 ii libxml2 2.9.13+dfsg-1ubuntu0.3 ii network-manager-openconnect 1.2.6-4 network-manager-openconnect-gnome recommends no packages. network-manager-openconnect-gnome suggests no packages. -- no debconf information
