Bug#1053950: openttd: diff for NMU version 13.4-0.1
Hi Maytham, > Nice! It's not on the Salsa repo, so I'm assuming you're yet to push your > changes. Yup. I've justed pushed and uploaded! > Thanks for your quick responses, and thanks for maintaining this awesome > package! Looking forward to the new version. :) Thanks for your interest and effort as well! Gr. Matthijs signature.asc Description: PGP signature
Bug#1053950: openttd: diff for NMU version 13.4-0.1
Hi Matthijs, On Sun, 2023-11-26 at 10:12 +0100, Matthijs Kooijman wrote: > > nmudiff (from devscripts) did that gigantic diff, but I've followed > > your workflow in my fork of the repo at [1], if you want to just copy > > the commits over (and change the Debian revision from -0.1 to -1). > Ah, I already imported the tarball myself :-) Nice! It's not on the Salsa repo, so I'm assuming you're yet to push your changes. > > I've built it on my computer, and have ran it through the usual tests, > > and the only issue is that Lintian says the override for the missing > > man page is unnecessary. > > Yeah, that's because on build, lintian tests both the openttd and > openttd-data package so it sees the manpage and thinks the override is > unneeded, but it *is* actually needed when testing the packages in > isolation. Ah, that's good to know. Thanks for your quick responses, and thanks for maintaining this awesome package! Looking forward to the new version. :) Kind regards, Maytham signature.asc Description: This is a digitally signed message part
Bug#1053950: openttd: diff for NMU version 13.4-0.1
Hi Maytham, > nmudiff (from devscripts) did that gigantic diff, but I've followed > your workflow in my fork of the repo at [1], if you want to just copy > the commits over (and change the Debian revision from -0.1 to -1). Ah, I already imported the tarball myself :-) > I've built it on my computer, and have ran it through the usual tests, > and the only issue is that Lintian says the override for the missing > man page is unnecessary. Yeah, that's because on build, lintian tests both the openttd and openttd-data package so it sees the manpage and thinks the override is unneeded, but it *is* actually needed when testing the packages in isolation. Gr. Matthijs signature.asc Description: PGP signature
Bug#1053950: openttd: diff for NMU version 13.4-0.1
Hi Matthijs, On Sat, 2023-11-25 at 18:00 +0100, Matthijs Kooijman wrote: > > I'll go through my normal git-based workflow rather than using your NMU > though, nmudiff (from devscripts) did that gigantic diff, but I've followed your workflow in my fork of the repo at [1], if you want to just copy the commits over (and change the Debian revision from -0.1 to -1). > AFAICS you've made no changes to the packaging except import the > upstream tarball, right? That's correct. I've built it on my computer, and have ran it through the usual tests, and the only issue is that Lintian says the override for the missing man page is unnecessary. Thanks for your work! Looking forward to the new version. Kind regards, Maytham [1]: http://salsa.debian.org/Maytha8/openttd signature.asc Description: This is a digitally signed message part
Bug#1053950: openttd: diff for NMU version 13.4-0.1
Hi Maytham, > I've prepared an NMU for openttd (versioned as 13.4-0.1). The diff > is attached to this message. Thanks for your patch. I should have uploaded a new OpenTTD version a long time ago, so let met correct that by handling the update now. I'll go through my normal git-based workflow rather than using your NMU though, AFAICS you've made no changes to the packaging except import the upstream tarball, right? Gr. Matthijs signature.asc Description: PGP signature
