Bug#1056056: linux-image-6.1.0-13-amd64: After a 'warm' reboot the disk is missing (not detected by the bios) on a HP t640
On Tuesday, 20 February 2024 09:22:06 CET Ben Mesman | Spark Narrowcasting wrote: > mmc: sdhci-pci-o2micro: Fix a warm reboot issue that disk can't be > detected by BIOS > ... > Link: > https://lore.kernel.org/r/20240203102908.4683-1-fredaibayhubt...@126.com > > I'm still waiting for the patch to land in the stable kernel series (both > 6.1 and 6.6) That patched is queued in both 6.1 and 6.6 (and 6.7) so should normally land in the next upstream point release. signature.asc Description: This is a digitally signed message part.
Bug#1056056: linux-image-6.1.0-13-amd64: After a 'warm' reboot the disk is missing (not detected by the bios) on a HP t640
Van: Salvatore Bonaccorso
> Hi Ben,
>
> On Thu, Dec 14, 2023 at 09:16:48AM +, Ben Mesman | Spark Narrowcasting
> wrote:
> > The attached patch works on my systems. Is there a way to get this in?
>
> ...
>
> We cannot pick changes which are not going to land in Linux upstream
> and then backported to the stable series. So the way to go here is to
> report the bug upstream, along with your proposed change. Candidates
> to reach out are:
>
> ...
>
> as it is affecting 6.1.y mention that the fix needs to be backported to
> various
> stable series at least back 6.1.y and describe which testing you have
> performed.
>
> Feel free to keep as well the Debian bug in the loop for the report.
>
> Hope this helps?
Small update on this bug: I reached out and Fred Ai made a patch which is now
in the mainline kernel:
commit 58aeb5623c2ebdadefe6352b14f8076a7073fea0
Author: Fred Ai
Date: Sat Feb 3 02:29:08 2024 -0800
mmc: sdhci-pci-o2micro: Fix a warm reboot issue that disk can't be detected
by BIOS
Driver shall switch clock source from DLL clock to
OPE clock when power off card to ensure that card
can be identified with OPE clock by BIOS.
Signed-off-by: Fred Ai
Fixes:4be33cf18703 ("mmc: sdhci-pci-o2micro: Improve card input timing at
SDR104/HS200 mode")
Cc: sta...@vger.kernel.org
Link:
https://lore.kernel.org/r/20240203102908.4683-1-fredaibayhubt...@126.com
Signed-off-by: Ulf Hansson
I'm still waiting for the patch to land in the stable kernel series (both 6.1
and 6.6)
Regards,
Ben Mesman.
Bug#1056056: linux-image-6.1.0-13-amd64: After a 'warm' reboot the disk is missing (not detected by the bios) on a HP t640
Hi Ben,
On Thu, Dec 14, 2023 at 09:16:48AM +, Ben Mesman | Spark Narrowcasting
wrote:
> The attached patch works on my systems. Is there a way to get this in?
> --- arch/x86/kernel/reboot.c.orig 2023-12-14 08:25:10.033382061 +0100
> +++ arch/x86/kernel/reboot.c 2023-12-14 08:31:10.394325941 +0100
> @@ -469,6 +469,14 @@
> DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq"),
> },
> },
> + { /* Handle problems with rebooting HP t640 thin-clients */
> + .callback = set_pci_reboot,
> + .ident = "HP t640",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "HP t640 Thin Client"),
> + },
> + },
>
> { /* PCIe Wifi card isn't detected after reboot otherwise */
> .callback = set_pci_reboot,
We cannot pick changes which are not going to land in Linux upstream
and then backported to the stable series. So the way to go here is to
report the bug upstream, along with your proposed change. Candidates
to reach out are:
./scripts/get_maintainer.pl arch/x86/kernel/reboot.c
Thomas Gleixner (maintainer:X86 ARCHITECTURE (32-BIT AND
64-BIT),commit_signer:2/11=18%)
Ingo Molnar (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
Borislav Petkov (maintainer:X86 ARCHITECTURE (32-BIT AND
64-BIT))
Dave Hansen (maintainer:X86 ARCHITECTURE (32-BIT
AND 64-BIT))
x...@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
"H. Peter Anvin" (reviewer:X86 ARCHITECTURE (32-BIT AND
64-BIT))
Sean Christopherson
(commit_signer:10/11=91%,authored:10/11=91%,added_lines:176/177=99%,removed_lines:102/103=99%)
Kai Huang (commit_signer:7/11=64%)
Josh Poimboeuf (commit_signer:1/11=9%,authored:1/11=9%)
"Peter Zijlstra (Intel)" (commit_signer:1/11=9%)
linux-ker...@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT))
as it is affecting 6.1.y mention that the fix needs to be backported to various
stable series at least back 6.1.y and describe which testing you have
performed.
Feel free to keep as well the Debian bug in the loop for the report.
Hope this helps?
Regards,
Salvatore
Bug#1056056: linux-image-6.1.0-13-amd64: After a 'warm' reboot the disk is missing (not detected by the bios) on a HP t640
The attached patch works on my systems. Is there a way to get this in?
--- arch/x86/kernel/reboot.c.orig 2023-12-14 08:25:10.033382061 +0100
+++ arch/x86/kernel/reboot.c 2023-12-14 08:31:10.394325941 +0100
@@ -469,6 +469,14 @@
DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq"),
},
},
+ { /* Handle problems with rebooting HP t640 thin-clients */
+ .callback = set_pci_reboot,
+ .ident = "HP t640",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "HP"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "HP t640 Thin Client"),
+ },
+ },
{ /* PCIe Wifi card isn't detected after reboot otherwise */
.callback = set_pci_reboot,
Bug#1056056: linux-image-6.1.0-13-amd64: After a 'warm' reboot the disk is missing (not detected by the bios) on a HP t640
Some searching and some trial and error later I find that adding a "reboot=p"
to the kernel command line will result in en rebootable system. It looks like
this system ("HP t640 Thin Client") should be added to the list of boot quirks
in 'arch/x86/kernel/reboot.c'?
For the record, "c,p", "g,p" and "p" work, all other combinations fail to do a
functional reboot.
Bug#1056056: linux-image-6.1.0-13-amd64: After a 'warm' reboot the disk is missing (not detected by the bios) on a HP t640
Package: src:linux Version: 6.1.55-1 Severity: important X-Debbugs-Cc: b...@sparknarrowcasting.nl If the HP t640 (I tried 2 different systems) runs this kernel, a 'reboot' will result in the BIOS reporting that the disk is missing. After a cold reboot (turning the device off and on again) the disk wil be detected and the system will boot as expected. The next reboot will again trigger this bug. Other HP thin-clients from similar series (t620, t630, t655) do not have the same problem. Debian bullseye (kernel 5.10) does not have this problem, but upgrading to 6.1.0 (through bulleye-backports) will trigger this bug. Upgrading bookworm to a 6.5 kernel (through bookworm-backports) does not solve the bug. Because the installer uses the same kernel, after the installation is complete and does the reboot, the bug will be triggered. -- Package-specific info: ** Version: Linux version 6.1.0-13-amd64 (debian-ker...@lists.debian.org) (gcc-12 (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40) #1 SMP PREEMPT_DYNAMIC Debian 6.1.55-1 (2023-09-29) ** Command line: BOOT_IMAGE=/boot/vmlinuz-6.1.0-13-amd64 root=UUID=3b7b05fe-9cdc-49e7-9416-319125d9858e ro quiet ** Not tainted ** Kernel log: [ 0.00] Linux version 6.1.0-13-amd64 (debian-ker...@lists.debian.org) (gcc-12 (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40) #1 SMP PREEMPT_DYNAMIC Debian 6.1.55-1 (2023-09-29) [ 0.00] Command line: BOOT_IMAGE=/boot/vmlinuz-6.1.0-13-amd64 root=UUID=3b7b05fe-9cdc-49e7-9416-319125d9858e ro quiet [ 0.00] BIOS-provided physical RAM map: [ 0.00] BIOS-e820: [mem 0x-0x0009] usable [ 0.00] BIOS-e820: [mem 0x000a-0x000f] reserved [ 0.00] BIOS-e820: [mem 0x0010-0x09df] usable [ 0.00] BIOS-e820: [mem 0x09e0-0x09ffdfff] reserved [ 0.00] BIOS-e820: [mem 0x09ffe000-0x0a1f] usable [ 0.00] BIOS-e820: [mem 0x0a20-0x0a20afff] ACPI NVS [ 0.00] BIOS-e820: [mem 0x0a20b000-0x7a88dfff] usable [ 0.00] BIOS-e820: [mem 0x7a88e000-0x7a980fff] reserved [ 0.00] BIOS-e820: [mem 0x7a981000-0x7a9b5fff] ACPI data [ 0.00] BIOS-e820: [mem 0x7a9b6000-0x7af20fff] ACPI NVS [ 0.00] BIOS-e820: [mem 0x7af21000-0x7c96bfff] reserved [ 0.00] BIOS-e820: [mem 0x7c96c000-0x7ca04fff] type 20 [ 0.00] BIOS-e820: [mem 0x7ca05000-0x7dff] usable [ 0.00] BIOS-e820: [mem 0x7e00-0x7fff] reserved [ 0.00] BIOS-e820: [mem 0xf800-0xfbff] reserved [ 0.00] BIOS-e820: [mem 0xfd00-0xfdff] reserved [ 0.00] BIOS-e820: [mem 0xfeb8-0xfec01fff] reserved [ 0.00] BIOS-e820: [mem 0xfec1-0xfec10fff] reserved [ 0.00] BIOS-e820: [mem 0xfed0-0xfed00fff] reserved [ 0.00] BIOS-e820: [mem 0xfed4-0xfed44fff] reserved [ 0.00] BIOS-e820: [mem 0xfed8-0xfed8] reserved [ 0.00] BIOS-e820: [mem 0xfedc2000-0xfedc] reserved [ 0.00] BIOS-e820: [mem 0xfedd4000-0xfedd5fff] reserved [ 0.00] BIOS-e820: [mem 0xfee0-0xfeef] reserved [ 0.00] BIOS-e820: [mem 0xff00-0x] reserved [ 0.00] BIOS-e820: [mem 0x0001-0x00015eff] usable [ 0.00] BIOS-e820: [mem 0x00015f00-0x00017eff] reserved [ 0.00] BIOS-e820: [mem 0x00017f00-0x00017f33] usable [ 0.00] BIOS-e820: [mem 0x00017f34-0x00017fff] reserved [ 0.00] NX (Execute Disable) protection: active [ 0.00] efi: EFI v2.70 by American Megatrends [ 0.00] efi: TPMFinalLog=0x7aed8000 ACPI 2.0=0x7a998000 ACPI=0x7a998000 SMBIOS=0x7c82 SMBIOS 3.0=0x7c81f000 MEMATTR=0x790b6298 ESRT=0x790c0698 [ 0.00] secureboot: Secure boot disabled [ 0.00] SMBIOS 3.2.1 present. [ 0.00] DMI: HP HP t640 Thin Client/8523, BIOS M43 v01.04 10/29/2019 [ 0.00] tsc: Fast TSC calibration using PIT [ 0.00] tsc: Detected 2395.458 MHz processor [ 0.000628] e820: update [mem 0x-0x0fff] usable ==> reserved [ 0.000631] e820: remove [mem 0x000a-0x000f] usable [ 0.000644] last_pfn = 0x17f340 max_arch_pfn = 0x4 [ 0.001139] x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT [ 0.001351] e820: update [mem 0x8000-0x] usable ==> reserved [ 0.001361] last_pfn = 0x7e000 max_arch_pfn = 0x4 [ 0.006355] esrt: Reserving ESRT space from 0x790c0698 to 0x790c06d0. [ 0.006369] e820: update [mem
