Bug#1056457: python-ase's autopkg tests fail with Python 3.12

2024-01-19 Thread Andrius Merkys

Hi Graham,

On Mon, 8 Jan 2024 08:46:45 +0200 Graham Inggs  wrote:

However, since spglib stopped building its extension for all supported
Python versions (see #1057858) testing python-ase against Python 3.12
now fails with:

531s INTERNALERROR> Traceback (most recent call last):
531s INTERNALERROR>   File
"/usr/lib/python3/dist-packages/spglib/spglib.py", line 41, in

531s INTERNALERROR> from spglib import _spglib as spg
531s INTERNALERROR> ImportError: cannot import name '_spglib' from
partially initialized module 'spglib' (most likely due to a circular
import) (/usr/lib/python3/dist-packages/spglib/__init__.py)

Therefore, I let python-ase only test against the default Python
version [1], and lower the severity of this bug, until either Python
3.12 is the default, or spglib builds its extension for all supported
Python versions again.


Maybe an alternative solution would be to only disable spglib-related 
test cases for Python 3.12. It seems that spglib is not an essential 
dependency for python-ase, thus the remaining test cases could still be 
ran to ensure package's integrity on Python 3.12.



[1] 
https://salsa.debian.org/debichem-team/python-ase/-/commit/b33055fd68da81e1806e7a0f0dd65dc5b53fc3b2

Best wishes,
Andrius



Bug#1056457: python-ase's autopkg tests fail with Python 3.12

2024-01-07 Thread Graham Inggs
Control: severity -1 important

Hi s3v

Thank you for all the links to the upstream commits.  I have applied
them, and python-ase now builds successfully (closing #1056184).

However, since spglib stopped building its extension for all supported
Python versions (see #1057858) testing python-ase against Python 3.12
now fails with:

531s INTERNALERROR> Traceback (most recent call last):
531s INTERNALERROR>   File
"/usr/lib/python3/dist-packages/spglib/spglib.py", line 41, in

531s INTERNALERROR> from spglib import _spglib as spg
531s INTERNALERROR> ImportError: cannot import name '_spglib' from
partially initialized module 'spglib' (most likely due to a circular
import) (/usr/lib/python3/dist-packages/spglib/__init__.py)

Therefore, I let python-ase only test against the default Python
version [1], and lower the severity of this bug, until either Python
3.12 is the default, or spglib builds its extension for all supported
Python versions again.

Regards
Graham


[1] 
https://salsa.debian.org/debichem-team/python-ase/-/commit/b33055fd68da81e1806e7a0f0dd65dc5b53fc3b2



Bug#1056457: [Debichem-devel] Bug#1056457: python-ase's autopkg tests fail with Python 3.12

2023-12-21 Thread s3v
Hi,

On Thu, 21 Dec 2023 08:39:54 +0200 Andrius Merkys  wrote:
> Is there a way to ignore DeprecationWarnings, but leave them in to the
> output? They are quite helpful to see, but not worth failing the build
> at the time being.
>

You're right, deprecation outputs are useful.
I've just tried by commenting "error" in ase/test/pytest.ini for stop
treating warnings as errors. Outputs are in place and tests don't fail
as well.


= warnings 
summary ==
...
...
test_forcecurve.py::test_forcecurve
  /usr/lib/python3/dist-packages/dateutil/tz/tz.py:37: DeprecationWarning: 
datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in 
a future version. Use timezone-aware objects
to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, 
datetime.UTC).
    EPOCH = datetime.datetime.utcfromtimestamp(0)

test_parsemath.py: 109 warnings
constraints/test_parameteric_constr.py: 66 warnings
fio/test_aims_io.py: 66 warnings
  
/build/python-ase-3.22.1/.pybuild/cpython3_3.12_ase/build/ase/utils/parsemath.py:146:
 DeprecationWarning: ast.Num is deprecated and will be removed in Python 3.14; 
use ast.Constant instead
    if isinstance(node, ast.Num):  # 

test_parsemath.py: 50 warnings
constraints/test_parameteric_constr.py: 64 warnings
fio/test_aims_io.py: 45 warnings
  
/build/python-ase-3.22.1/.pybuild/cpython3_3.12_ase/build/ase/utils/parsemath.py:147:
 DeprecationWarning: Attribute n is deprecated and will be removed in Python 
3.14; use value instead
    return node.n



Thanks for maintaining python-ase!



Bug#1056457: [Debichem-devel] Bug#1056457: python-ase's autopkg tests fail with Python 3.12

2023-12-20 Thread Andrius Merkys

Control: tags -1 + patch

Hi,

On 2023-12-20 20:23, s3v wrote:

After applying [1][2][3] from upstream and adding "-p no:warnings":

   addopts = -p no:cacheprovider -p no:warnings
  
in ase/test/pytest.ini (DeprecationWarnings from various packages make

tests fail), I was able to build your package in a sid chroot environment.

Kind Regards

[1] https://gitlab.com/ase/ase/-/commit/9c019c1782115343014691596514eb6d351e8e17
[2] https://gitlab.com/ase/ase/-/commit/f0932b3385fea739bc737e5aec1fc92960b0550c
[3] https://gitlab.com/ase/ase/-/merge_requests/3022


This is great news, thanks for caring for python-ase. It would be nice 
to have an upstream release with all Python 3.12 compatibility fixes, 
but in the meantime patches are OK.


Is there a way to ignore DeprecationWarnings, but leave them in to the 
output? They are quite helpful to see, but not worth failing the build 
at the time being.


Best,
Andrius



Bug#1056457: python-ase's autopkg tests fail with Python 3.12

2023-12-20 Thread s3v
Dear Maintainer,

After applying [1][2][3] from upstream and adding "-p no:warnings":

  addopts = -p no:cacheprovider -p no:warnings
 
in ase/test/pytest.ini (DeprecationWarnings from various packages make
tests fail), I was able to build your package in a sid chroot environment.

Kind Regards

[1] https://gitlab.com/ase/ase/-/commit/9c019c1782115343014691596514eb6d351e8e17
[2] https://gitlab.com/ase/ase/-/commit/f0932b3385fea739bc737e5aec1fc92960b0550c
[3] https://gitlab.com/ase/ase/-/merge_requests/3022



Bug#1056457: python-ase's autopkg tests fail with Python 3.12

2023-11-22 Thread Matthias Klose

Package: src:python-ase
Version: 3.22.1-3
Severity: important
Tags: sid trixie
User: debian-pyt...@lists.debian.org
Usertags: python3.12

python-ase's autopkg tests fail with Python 3.12:

[...]
329s autopkgtest [18:38:29]: test command1: for py in $(py3versions -s); 
do cd "$AUTOPKGTEST_TMP"; $py -m ase test; done

329s autopkgtest [18:38:29]: test command1: [---
329s usage: ase [-h] [--version] [-T]
329s 
{help,info,test,gui,db,run,band-structure,build,dimensionality,eos,ulm,find,nebplot,nomad-upload,nomad-get,convert,reciprocal,completion,diff,exec}

329s...
329s ase: error: AttributeError: module 'importlib' has no attribute 
'find_loader'

329s To get a full traceback, use: ase -T test ...
330s autopkgtest [18:38:30]: test command1: ---]
330s autopkgtest [18:38:30]: test command1:  - - - - - - - - - - results 
- - - - - - - - - -

330s command1 FAIL non-zero exit status 2
330s autopkgtest [18:38:30]:  summary
330s command1 FAIL non-zero exit status 2