Bug#1057472: darktable: diff for NMU version 4.4.2-1.1

2023-12-05 Thread David Bremner
Boyuan Yang  writes:

> I've prepared an NMU for darktable (versioned as 4.4.2-1.1) and
> uploaded it to DELAYED/5. Please feel free to tell me if I
> should delay it longer.

As long as you are prepared to deal with any fallout, go ahead. In any
case I doubt there are very many darktable users on arm64.

> I am disabling the OpenMP support for now on arm64 so that it does not
> block library transitions indefinitely. Currently it blocks the completion
> of libavif transition, and transitively blocks jpeg-xl transition from
> starting, etc. For a full list of blocked transition, check information on
> https://tracker.debian.org/pkg/darktable . I don't think we should delay it
> any longer given that no signs of bug solving is currently visible.

Well, take that up with the gcc maintainer, since that is where the
(fixed upstream) bug is.



Bug#1057472: darktable: diff for NMU version 4.4.2-1.1

2023-12-05 Thread Boyuan Yang
Package: darktable
Version: 4.4.2-1
Severity: normal
Tags: patch  pending
X-Debbugs-CC: brem...@debian.org by...@debian.org

Dear Debian darktable package maintainer,

I've prepared an NMU for darktable (versioned as 4.4.2-1.1) and
uploaded it to DELAYED/5. Please feel free to tell me if I
should delay it longer.

I am disabling the OpenMP support for now on arm64 so that it does not
block library transitions indefinitely. Currently it blocks the completion
of libavif transition, and transitively blocks jpeg-xl transition from
starting, etc. For a full list of blocked transition, check information on
https://tracker.debian.org/pkg/darktable . I don't think we should delay it
any longer given that no signs of bug solving is currently visible.

If you have any other idea, please let me know immediately and feel free
to stop my delayed upload using dcut. I would be more than welcome to have
some discussion so that we can get a proper solution.

Regards.

diff -Nru darktable-4.4.2/debian/changelog darktable-4.4.2/debian/changelog
--- darktable-4.4.2/debian/changelog2023-08-20 08:26:40.0 -0400
+++ darktable-4.4.2/debian/changelog2023-12-05 10:05:05.0 -0500
@@ -1,3 +1,13 @@
+darktable (4.4.2-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Mitchell Dzurick ]
+  * Disable openmp for arm64 builds for now (LP: #2038351)
+See Debian bug: #1053405
+
+ -- Boyuan Yang   Tue, 05 Dec 2023 10:05:05 -0500
+
 darktable (4.4.2-1) unstable; urgency=medium
 
   * Update to new upstream version 4.4.2.
diff -Nru darktable-4.4.2/debian/rules darktable-4.4.2/debian/rules
--- darktable-4.4.2/debian/rules2023-08-20 08:26:40.0 -0400
+++ darktable-4.4.2/debian/rules2023-12-05 10:04:10.0 -0500
@@ -20,7 +20,12 @@
dh $@
 
 override_dh_auto_configure: cmake/version.cmake
+ifeq ($(DEB_HOST_ARCH),arm64)
+   # Disable OPENMP for arm64 builds. See LP: #2038351
+   dh_auto_configure -- -DBINARY_PACKAGE_BUILD=1 -
DCMAKE_BUILD_TYPE=Release -DRAWSPEED_ENABLE_LTO=ON -DUSE_OPENMP=OFF
+else
dh_auto_configure -- -DBINARY_PACKAGE_BUILD=1 -
DCMAKE_BUILD_TYPE=Release -DRAWSPEED_ENABLE_LTO=ON
+endif
 
 describe-current-version:
git describe --tags upstream | sed 's,^release-,,;s,-,+,;s,-,~,;'


signature.asc
Description: This is a digitally signed message part