Source: liquidctl
Version: 1.13.0-1
Severity: normal
Tags: patch
User: helm...@debian.org
Usertags: dep17m2

Dear Maintainer,

your package installs files related to udev, into /lib. These
files need to be moved to /usr/lib as part of Debian's usr-merge
effort [1].

Attached you will find a patch to delegate the exact placement of
the udev files to udev.pc (using pkg-config). This should work today
in unstable and, if necessary, for bookworm. Once udev.pc in
unstable points to /usr/lib your package will benefit automatically
after a binNMU or any other upload.

Later during the trixie cycle I expect this bug class to raise in
priority.

If during the trixie cycle your package will undergo structural
changes or any other file moves, please see the wiki and upload
to experimental first when these changes are done.

Thank you for considering,
Chris

[1] https://wiki.debian.org/UsrMerge


PS: please push the pristine-tar branch and the upstream/... tags
to salsa, if you are still using git-buildpackage.
diff -Nru liquidctl-1.13.0/debian/changelog liquidctl-1.13.0/debian/changelog
--- liquidctl-1.13.0/debian/changelog	2023-09-07 11:30:45.000000000 +0200
+++ liquidctl-1.13.0/debian/changelog	2023-12-09 00:48:55.000000000 +0100
@@ -1,3 +1,10 @@
+liquidctl (1.13.0-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Use udev.pc to place udev rules file
+
+ -- Chris Hofstaedtler <z...@debian.org>  Sat, 09 Dec 2023 00:48:55 +0100
+
 liquidctl (1.13.0-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru liquidctl-1.13.0/debian/control liquidctl-1.13.0/debian/control
--- liquidctl-1.13.0/debian/control	2023-02-12 16:43:07.000000000 +0100
+++ liquidctl-1.13.0/debian/control	2023-12-09 00:48:11.000000000 +0100
@@ -4,6 +4,7 @@
 Maintainer: Laszlo Boszormenyi (GCS) <g...@debian.org>
 Build-Depends: debhelper-compat (= 13),
                dh-python,
+               pkgconf,
                pybuild-plugin-pyproject,
                python3-all,
                python3-setuptools,
@@ -14,7 +15,8 @@
                python3-usb <!nocheck>,
                python3-colorlog <!nocheck>,
                python3-crcmod <!nocheck>,
-               python3-pil <!nocheck>
+               python3-pil <!nocheck>,
+               systemd-dev,
 Homepage: https://github.com/liquidctl/liquidctl
 Standards-Version: 4.6.2
 Rules-Requires-Root: no
diff -Nru liquidctl-1.13.0/debian/liquidctl.install liquidctl-1.13.0/debian/liquidctl.install
--- liquidctl-1.13.0/debian/liquidctl.install	2021-02-07 08:33:36.000000000 +0100
+++ liquidctl-1.13.0/debian/liquidctl.install	2023-12-09 00:48:44.000000000 +0100
@@ -1 +1 @@
-extra/linux/71-liquidctl.rules /lib/udev/rules.d/
+extra/linux/71-liquidctl.rules ${env:deb_udevdir}/rules.d/
diff -Nru liquidctl-1.13.0/debian/rules liquidctl-1.13.0/debian/rules
--- liquidctl-1.13.0/debian/rules	2023-02-12 16:43:07.000000000 +0100
+++ liquidctl-1.13.0/debian/rules	2023-12-09 00:48:32.000000000 +0100
@@ -5,6 +5,7 @@
 #export DH_VERBOSE=1
 
 export PYBUILD_NAME=liquidctl
+export deb_udevdir = $(shell pkg-config --variable=udevdir udev)
 
 %:
 	dh $@ --with python3 --buildsystem=pybuild

Reply via email to