Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
(sorry for the very late response, I only noticed your message just now) I did come to the conclusion that Werkzeug 2.3.x has some bigger changes that will break most of the existing packages in some way. The main differences to Werkzeug 3.x than isn't that big. Ok, that makes sense! Although, I'm not 100% convinced that updating to 2.3 in the short run to fix some currently broken packages, and then focusing on upgrading to 3.x isn't a better choice. 2.3 is also closer to 3.x, so that may make a transition smoother. Because a updated flask-login and other (updated) packages have also underlying changes that require than a updated package of Werkzeug. And some upstream projects did change their source in a way so they can deal different versions of Werkzeug. So a usual update is magical fixing build issues we did have in older versions against recent Flask/Werkzeug versions. Ok, now I get what mean. Thanks for the clarification and sorry for the confusion.
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
Hello Julian, Am 04.01.24 um 10:23 schrieb Julian Gilbey: ... The build of src:flask is depending on python3-werkzeug >= 3.x, which has itself a dependency on python3-markupsafe, so if you spot a missing direct dependency I'm interested how this comes to play as Markupsafe should be around at build time. In the debian/experimental branch of python-werkzeug, debian/control does not mention python3-markupsafe, but it should do. hmm, you were talking about Werkzeug, I was within the src:flask package. A bit of misunderstanding. If you spot a issue in src:python-werkzeug than of course that's great you fixed this! -- Regards Carsten
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
On Thu, Jan 04, 2024 at 08:28:53PM +, Julian Gilbey wrote: > Hi all, > > A quick update > [...] > > Updates: > [...] > > (2) It appears that all of the autopkgtests triggered by > python3-werkzeug 2.3.8 have passed (though most are no longer showing > on tracker.d.o). The only package that is failing is flask-dance. As > you (Carsten) mentioned earlier, "the upstream package isn't really > ready for the newer versions", so I suggest that we file an RC bug > against it. Perhaps we can ask the appropriate team (release team?) > to drop it from testing for now so that python3-werkzeug can migrate. > It has no reverse dependencies. And upstream fixed it with version 7.0.1 within hours of it being reported! I've just uploaded that to unstable, so python3-werkzeug will hopefully migrate in a couple of days' time. Best wishes, Julian
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
Hi all, A quick update On Thu, Jan 04, 2024 at 12:13:19PM +0100, Thomas Goirand wrote: > On 1/3/24 22:22, Julian Gilbey wrote: > > On Fri, Dec 22, 2023 at 12:04:48AM +0100, Gregor Riepl wrote: > > > Hi Carsten, > > > [...] > > > > > > My point was that if, for whatever reason, werkzeug 3.0.1 is not yet fit > > > for > > > release, it should be enough to upgrade to 2.3.5 to address these unit > > > test > > > failures. > > > [...] Updates: (1) I've added python3-markupsafe to the Build-Depends and pushed to debian/experimental (though not uploaded it to experimental) (2) It appears that all of the autopkgtests triggered by python3-werkzeug 2.3.8 have passed (though most are no longer showing on tracker.d.o). The only package that is failing is flask-dance. As you (Carsten) mentioned earlier, "the upstream package isn't really ready for the newer versions", so I suggest that we file an RC bug against it. Perhaps we can ask the appropriate team (release team?) to drop it from testing for now so that python3-werkzeug can migrate. It has no reverse dependencies. Best wishes, Julian
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
On Thu, Jan 04, 2024 at 12:13:19PM +0100, Thomas Goirand wrote: > On 1/3/24 22:22, Julian Gilbey wrote: > > On Fri, Dec 22, 2023 at 12:04:48AM +0100, Gregor Riepl wrote: > > > Hi Carsten, > > > [...] > > > > > > My point was that if, for whatever reason, werkzeug 3.0.1 is not yet fit > > > for > > > release, it should be enough to upgrade to 2.3.5 to address these unit > > > test > > > failures. > > > [...] > > > > > > That doesn't make any sense to me. These deprecations are obviously in > > > werkzeug and not flask-login. Why would changes in flask-login fix them? > > > > > > Not saying flask-login shouldn't be updated, but that's not the right > > > scope > > > for this bug report. > > > > Just to throw in: these werkzeug failures are also causing a similar > > FTBFS in debugpy; I've temporarily addressed it by skipping these unit > > tests, but that's not a great solution. > > > > I just took a quick look at upgrading the unstable/testing version of > > werkzeug to 2.3.8 in the meantime. It was pretty quick, and the > > package tests all pass. Shall I upload it to unstable? On salsa, I > > would push to debian/2.x for the Debian branch and to upstream-2.x for > > the upstream, so as not to prevent merging the experimental branch > > into debian/master later. Actually, it is probably OK to use the > > upstream branch for this update without causing problems, but might be > > better to be safe. > > > > (Incidentally, while doing this, I spotted one bug with the current > > experimental version: it is missing a Build-Depends on > > python3-markupsafe.) > > > > Best wishes, > > > > Julian > > Hi Julian, > > I do not agree with Casten here. Please do upload 2.3.8 to unstable if it > fixes things, so we have time to address all the Python 3.12 issues right > now. Please hold on uploading 3.x (as well as werkzeug) if this can wait, > because we need to address all the Python 3.12 issues first, and now is not > a good time to transition any other components. > > Upgrading flask+werkzeug is *NOT* urgent. Fixing all 3.12 issues must be our > current priority. > > Cheers, > > Thomas Goirand (zigo) Hi Thomas, I've already uploaded 2.3.8 for exactly this reason ;-) Best wishes, Julian
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
On 1/3/24 22:22, Julian Gilbey wrote: On Fri, Dec 22, 2023 at 12:04:48AM +0100, Gregor Riepl wrote: Hi Carsten, [...] My point was that if, for whatever reason, werkzeug 3.0.1 is not yet fit for release, it should be enough to upgrade to 2.3.5 to address these unit test failures. [...] That doesn't make any sense to me. These deprecations are obviously in werkzeug and not flask-login. Why would changes in flask-login fix them? Not saying flask-login shouldn't be updated, but that's not the right scope for this bug report. Just to throw in: these werkzeug failures are also causing a similar FTBFS in debugpy; I've temporarily addressed it by skipping these unit tests, but that's not a great solution. I just took a quick look at upgrading the unstable/testing version of werkzeug to 2.3.8 in the meantime. It was pretty quick, and the package tests all pass. Shall I upload it to unstable? On salsa, I would push to debian/2.x for the Debian branch and to upstream-2.x for the upstream, so as not to prevent merging the experimental branch into debian/master later. Actually, it is probably OK to use the upstream branch for this update without causing problems, but might be better to be safe. (Incidentally, while doing this, I spotted one bug with the current experimental version: it is missing a Build-Depends on python3-markupsafe.) Best wishes, Julian Hi Julian, I do not agree with Casten here. Please do upload 2.3.8 to unstable if it fixes things, so we have time to address all the Python 3.12 issues right now. Please hold on uploading 3.x (as well as werkzeug) if this can wait, because we need to address all the Python 3.12 issues first, and now is not a good time to transition any other components. Upgrading flask+werkzeug is *NOT* urgent. Fixing all 3.12 issues must be our current priority. Cheers, Thomas Goirand (zigo)
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
On Thu, Jan 04, 2024 at 09:23:58AM +, Julian Gilbey wrote: > Hello Carsten, > [...] > There are other packages that currently FTBFS because werkzeug 2.2.x > is not compatible with Python 3.12 in some small ways. It would fix > those FTBFS bugs now; 6 months is a long time to wait! I've already > done the work on 2.3.8, so it's just a matter of uploading it. I'll > do that now. Done, and pushed to salsa. Let's see what happens ;-) The debian branch is debian/2.x, and I used the standard upstream and pristine-tar branches. So you'll need to do a manual git pull on the upstream and pristine-tar branches, and a git pull --tags; gbp push will probably not work on debian/experimental until there's a new upstream 3.x, so you'll have to do a manual git push and git push --tags until that. But gbp buildpackage will still work fine. Best wishes, Julian
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
Hello Carsten,
On Thu, Jan 04, 2024 at 07:07:01AM +0100, Carsten Schoenert wrote:
> Hello Julian,
>
> Am 03.01.24 um 22:22 schrieb Julian Gilbey:
> > Just to throw in: these werkzeug failures are also causing a similar
> > FTBFS in debugpy; I've temporarily addressed it by skipping these unit
> > tests, but that's not a great solution.
> >
> > I just took a quick look at upgrading the unstable/testing version of
> > werkzeug to 2.3.8 in the meantime. It was pretty quick, and the
> > package tests all pass. Shall I upload it to unstable?
>
> in the end it's up to you. I personally still see no real gain in doing such
> a version bump if we could spend the same time on fixing issues we currently
> see for Flask/Werkzeug >= 3.x given that we need to migrate any way in a not
> to far future. Why spend now time on things that could happen already within
> the past 6 months? What do we really gain?
There are other packages that currently FTBFS because werkzeug 2.2.x
is not compatible with Python 3.12 in some small ways. It would fix
those FTBFS bugs now; 6 months is a long time to wait! I've already
done the work on 2.3.8, so it's just a matter of uploading it. I'll
do that now.
> And, in case you decide to upload Werkzeug 2.3.8, my guess is you will see
> almost the same fallout as that is still visible for the both packages with
> the version bump to 3.x in experimental. With one exception, it will produce
> pressure to fix out the issues we seen until now even more.
I guess that 2.3.8 is much closer to the version currently in testing
than 3.x is. It will certainly fix some bugs.
> I worked on a lot of packages that had FTBFS or test suite issues in the
> past 2-3 weeks, the current queue of outstanding packages for Flask/Werkzeug
> 3.x is down to 5 packages.
That's great, thanks!!
[... list snipped ...]
> > (Incidentally, while doing this, I spotted one bug with the current
> > experimental version: it is missing a Build-Depends on
> > python3-markupsafe.)
>
> The only requirement for Markupsafe in Flask 3.0.0 is listed in
> requirements/tests-pallets-min{.*}.
>
> The build of src:flask is depending on python3-werkzeug >= 3.x, which has
> itself a dependency on python3-markupsafe, so if you spot a missing direct
> dependency I'm interested how this comes to play as Markupsafe should be
> around at build time.
In the debian/experimental branch of python-werkzeug, debian/control
does not mention python3-markupsafe, but it should do.
Best wishes,
Julian
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
Hello Gregor, Am 22.12.23 um 00:04 schrieb Gregor Riepl: My point was that if, for whatever reason, werkzeug 3.0.1 is not yet fit for release, it should be enough to upgrade to 2.3.5 to address these unit test failures. I did come to the conclusion that Werkzeug 2.3.x has some bigger changes that will break most of the existing packages in some way. The main differences to Werkzeug 3.x than isn't that big. flask-login got recent updates which so far I've seen will fix these issues in the test suite. So if you want to push things further try to update/patch flask-login to a recent version targeting experimental. Just rebuilding flask-login against the version of python3-werkzeug in experimental will not fix the problems, so also not an intermediate update to 2.3.5, Python 3.12 is now very strict about deprecation warnings. That doesn't make any sense to me. These deprecations are obviously in werkzeug and not flask-login. Why would changes in flask-login fix them? Because a updated flask-login and other (updated) packages have also underlying changes that require than a updated package of Werkzeug. And some upstream projects did change their source in a way so they can deal different versions of Werkzeug. So a usual update is magical fixing build issues we did have in older versions against recent Flask/Werkzeug versions. I was able to fix not all of the current fallout, but quite a few of them. -- Regards Carsten
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
Hello Julian,
Am 03.01.24 um 22:22 schrieb Julian Gilbey:
Just to throw in: these werkzeug failures are also causing a similar
FTBFS in debugpy; I've temporarily addressed it by skipping these unit
tests, but that's not a great solution.
I just took a quick look at upgrading the unstable/testing version of
werkzeug to 2.3.8 in the meantime. It was pretty quick, and the
package tests all pass. Shall I upload it to unstable?
in the end it's up to you. I personally still see no real gain in doing
such a version bump if we could spend the same time on fixing issues we
currently see for Flask/Werkzeug >= 3.x given that we need to migrate
any way in a not to far future. Why spend now time on things that could
happen already within the past 6 months? What do we really gain?
And, in case you decide to upload Werkzeug 2.3.8, my guess is you will
see almost the same fallout as that is still visible for the both
packages with the version bump to 3.x in experimental. With one
exception, it will produce pressure to fix out the issues we seen until
now even more.
I worked on a lot of packages that had FTBFS or test suite issues in the
past 2-3 weeks, the current queue of outstanding packages for
Flask/Werkzeug 3.x is down to 5 packages.
I've seen other Python team members who did also some upload to fix
packages, thank you all for working on that.
https://qa.debian.org/excuses.php?experimental=1=python-werkzeug
https://qa.debian.org/excuses.php?experimental=1=flask
flask-dance (python-werkzeug)
I've done several attempts to get it build with the newer versions, it's
tricky and in my opinion the upstream package isn't really ready for the
newer versions.
Would need open a upstream issue about the problems to get that addressed.
onionshare (python-werkzueg)
Did not look that much yet into the culprit, might be easy to fix.
https://github.com/onionshare/onionshare/pull/1677
It's tiring to work on a active upstream project that did the last
version update now more than one year ago.
beets (flask)
Fixed locally, waiting on response from Stefano due missing commits in
the Salsa tree.
flask-dance (flask)
Same as above.
flask-socketio (flask)
Might be fixed by a newer upstream version, I opened a wishlist bug
about updating (http://bugs.debian.org/1059538). Maybe someone can cross
check?
ironic-inspector (flask)
Did not look deep into that yet. Might be fixed by a newer available
upstream version. The package currently is marked for auto removal on
25th January, I guess Thomas Goirand is happily taking any help on this
package.
(Incidentally, while doing this, I spotted one bug with the current
experimental version: it is missing a Build-Depends on
python3-markupsafe.)
The only requirement for Markupsafe in Flask 3.0.0 is listed in
requirements/tests-pallets-min{.*}.
The build of src:flask is depending on python3-werkzeug >= 3.x, which
has itself a dependency on python3-markupsafe, so if you spot a missing
direct dependency I'm interested how this comes to play as Markupsafe
should be around at build time.
--
Regards
Carsten
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
On Fri, Dec 22, 2023 at 12:04:48AM +0100, Gregor Riepl wrote: > Hi Carsten, > [...] > > My point was that if, for whatever reason, werkzeug 3.0.1 is not yet fit for > release, it should be enough to upgrade to 2.3.5 to address these unit test > failures. > [...] > > That doesn't make any sense to me. These deprecations are obviously in > werkzeug and not flask-login. Why would changes in flask-login fix them? > > Not saying flask-login shouldn't be updated, but that's not the right scope > for this bug report. Just to throw in: these werkzeug failures are also causing a similar FTBFS in debugpy; I've temporarily addressed it by skipping these unit tests, but that's not a great solution. I just took a quick look at upgrading the unstable/testing version of werkzeug to 2.3.8 in the meantime. It was pretty quick, and the package tests all pass. Shall I upload it to unstable? On salsa, I would push to debian/2.x for the Debian branch and to upstream-2.x for the upstream, so as not to prevent merging the experimental branch into debian/master later. Actually, it is probably OK to use the upstream branch for this update without causing problems, but might be better to be safe. (Incidentally, while doing this, I spotted one bug with the current experimental version: it is missing a Build-Depends on python3-markupsafe.) Best wishes, Julian
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
Hi Carsten, I can see that 3.0.1 is currently in experimental, but it would be enough to upgrade to the latest 2.x to fix this issue. this makes not really sense to me. Flask 3.0.0 and Werkzeug 3.0.0 was released on 09-30-2023, so almost three months before. Putting energy into Flask 2.3.5 and fix other related packages while 3.x is on the way is a waste of time in my eyes as we would need to work at least twice on some packages... Absolutely! My point was that if, for whatever reason, werkzeug 3.0.1 is not yet fit for release, it should be enough to upgrade to 2.3.5 to address these unit test failures. flask-login got recent updates which so far I've seen will fix these issues in the test suite. So if you want to push things further try to update/patch flask-login to a recent version targeting experimental. Just rebuilding flask-login against the version of python3-werkzeug in experimental will not fix the problems, so also not an intermediate update to 2.3.5, Python 3.12 is now very strict about deprecation warnings. That doesn't make any sense to me. These deprecations are obviously in werkzeug and not flask-login. Why would changes in flask-login fix them? Not saying flask-login shouldn't be updated, but that's not the right scope for this bug report. Regards, Gregor
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
Hello Gregor, Am Thu, Dec 21, 2023 at 02:00:40PM +0100 schrieb Gregor Riepl: > I don't see any other errors in the log except for the ast.Str deprecation > warnings, and they all come from python-werkezug and not this package. > > Reassiging the bug. > Upstream has already fixed this in in 2.3.5, by the way: > https://github.com/pallets/werkzeug/issues/2704 > > I can see that 3.0.1 is currently in experimental, but it would be enough to > upgrade to the latest 2.x to fix this issue. this makes not really sense to me. Flask 3.0.0 and Werkzeug 3.0.0 was released on 09-30-2023, so almost three months before. Putting energy into Flask 2.3.5 and fix other related packages while 3.x is on the way is a waste of time in my eyes as we would need to work at least twice on some packages... flask-login got recent updates which so far I've seen will fix these issues in the test suite. So if you want to push things further try to update/patch flask-login to a recent version targeting experimental. Just rebuilding flask-login against the version of python3-werkzeug in experimental will not fix the problems, so also not an intermediate update to 2.3.5, Python 3.12 is now very strict about deprecation warnings. Regards Carsten
Bug#1058318: flask-login: FTBFS: dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.12 3.11" returned exit code 13
I don't see any other errors in the log except for the ast.Str deprecation warnings, and they all come from python-werkezug and not this package. Reassiging the bug. Upstream has already fixed this in in 2.3.5, by the way: https://github.com/pallets/werkzeug/issues/2704 I can see that 3.0.1 is currently in experimental, but it would be enough to upgrade to the latest 2.x to fix this issue. Please push a new python-werkzeug release ASAP. Thank you!
