Bug#1060254: mumble: please make the build reproducible
Hello Chris and Diederik I missed that a couple of bugs came in for Mumble because it turns out up to now I had not signed up for the Debian VoIP Packaging Team mailing list. *sigh* It's going to take me some time to figure out the correct 'sieve' rules to get the Mumble bug messages to show up in my 'Debian-Bugs' mail folder so that I'll be able to quickly catch new bugs coming in. It's going to take a few weeks before I will be able to start work on packaging Mumble v.1.5.613, but I hope I can do an upload with the patches for reproducibility and fixing the autopkgtest 'smoke' test. Thanks for working on reproducibility in the Mumble package. -- Chris -- Chris Knadle chris.kna...@coredump.us
Bug#1060254: mumble: please make the build reproducible
On zondag 11 februari 2024 14:43:49 CET you wrote: > I went ahead and send your patch upstream and that got accepted. > So I'm attaching a/your patch with all the DEP-3 headers set. There's now a new release/tag v1.5.613 which includes this fix :) signature.asc Description: This is a digitally signed message part.
Bug#1060254: mumble: please make the build reproducible
Control: tag -1 +upstream +fixed-upstream Control: forwarded -1 https://github.com/mumble-voip/mumble/pull/6333 Hi Chris, On Mon, 08 Jan 2024 10:24:37 + "Chris Lamb" wrote: > Source: mumble > Version: 1.5.517-1 > Severity: wishlist > Tags: patch > User: reproducible-bui...@lists.alioth.debian.org > Usertags: timestamps > X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org > > Whilst working on the Reproducible Builds effort [0], we noticed that > mumble could not be built reproducibly. > > Patch attached. CMake is already following the SOURCE_DATE_EPOCH environment > variable if available, but it needs to be instructed to use the UTC > timezone. Thanks for your work on Reproducible Builds! I went ahead and send your patch upstream and that got accepted. So I'm attaching a/your patch with all the DEP-3 headers set. Cheers, DiederikFrom: Chris Lamb Date: Sat, 10 Feb 2024 17:03:16 +0100 Subject: BUILD: Set timezone on release date for reproducibility Origin: upstream, https://github.com/mumble-voip/mumble/commit/af46c1a909a4a90955bb9a4b3c010f45ce80a986 To make the build reproducible, it's needed to set the timezone as otherwise the date could vary based on the timezone of the build server. Link: https://bugs.debian.org/1060254 --- auxiliary_files/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/auxiliary_files/CMakeLists.txt b/auxiliary_files/CMakeLists.txt index 86850e900..30b5962ee 100644 --- a/auxiliary_files/CMakeLists.txt +++ b/auxiliary_files/CMakeLists.txt @@ -8,7 +8,7 @@ include(pkg-utils) if(NOT BUILD_RELEASE_DATE) # If BUILD_RELEASE_DATE has not been set, default to time of build - string(TIMESTAMP BUILD_RELEASE_DATE "%Y-%m-%d") + string(TIMESTAMP BUILD_RELEASE_DATE "%Y-%m-%d" UTC) endif() if(overlay) -- 2.43.0 signature.asc Description: This is a digitally signed message part.
Bug#1060254: mumble: please make the build reproducible
Source: mumble Version: 1.5.517-1 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: timestamps X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0], we noticed that mumble could not be built reproducibly. This is because it embeds the current build date in an XML file: │ │ │ │ ├── ./usr/share/metainfo/info.mumble.Mumble.appdata.xml │ │ │ │ │ @@ -23,13 +23,13 @@ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │Light and Dark Theme │ │ │ │ │ https://raw.githubusercontent.com/mumble-voip/mumble/master/screenshots/Mumble.png │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ - │ │ │ │ │ + │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ mumble │ │ │ │ │ │ │ │ │ │ Patch attached. CMake is already following the SOURCE_DATE_EPOCH environment variable if available, but it needs to be instructed to use the UTC timezone. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- --- a/debian/patches/50-reproducible-build.diff 1970-01-01 01:00:00.0 +0100 --- b/debian/patches/50-reproducible-build.diff 2024-01-08 10:10:33.875933485 + @@ -0,0 +1,15 @@ +Description: Make the build reproducible +Author: Chris Lamb +Last-Update: 2024-01-08 + +--- mumble-1.5.517.orig/auxiliary_files/CMakeLists.txt mumble-1.5.517/auxiliary_files/CMakeLists.txt +@@ -8,7 +8,7 @@ include(pkg-utils) + + if(NOT BUILD_RELEASE_DATE) + # If BUILD_RELEASE_DATE has not been set, default to time of build +- string(TIMESTAMP BUILD_RELEASE_DATE "%Y-%m-%d") ++ string(TIMESTAMP BUILD_RELEASE_DATE "%Y-%m-%d" UTC) + endif() + + if(overlay) --- a/debian/patches/series 2024-01-08 09:47:51.592354667 + --- b/debian/patches/series 2024-01-08 10:10:33.095927130 + @@ -3,3 +3,4 @@ #44-add-speechd-header.diff 45-add-pid-location-hint.diff 90-debianize-systemd-unit.diff +50-reproducible-build.diff
