Bug#1060421: python3-botocore: botocore as a (useless) undeclared dependency on python3-six
On Fri, Jan 12, 2024 at 08:00:48AM +0100, Alexandre Detiste wrote: > >> Or should the Debian package depend on python3-six? > > > > That s the fast solution > > Yes please do that, I've checked awscli upstream and it's a bit of a mess > with so many pull request; I'll check again later. Here's the upstream change responsible for six being present in botocore's compat.py: https://github.com/boto/botocore/pull/2814 So it seems that adding the dependency is the right thing for now, and I will take care of that. noah
Bug#1060421: python3-botocore: botocore as a (useless) undeclared dependency on python3-six
>> Or should the Debian package depend on python3-six? > > That s the fast solution Yes please do that, I've checked awscli upstream and it's a bit of a mess with so many pull request; I'll check again later. Greetings and thank your for taking the time to analyse this? Le jeu. 11 janv. 2024 à 21:04, Alexandre Detiste a écrit : > > CodeSearch tell us it's used twice elsewhere ... two other packages to check > first > > https://codesearch.debian.net/search?q=+botocore.compat=1=1 > > > awscli_2.14.6-1/tests/functional/s3/test_presign_command.py > > ---> I ll check out 2.15.8 > > > > python-s3transfer_0.7.0-1/s3transfer/compat.py ( so a compat.py that imports > a compat.py !) > > > I ll package 0.10 & check > > > > > So the quick & dirty solution is to add python3-six dependency, but there's > no émergency and only 2 reverse dep to check. > > I ll ping you later. > > Greetings > > Le jeu. 11 janv. 2024, 20:43, Gregor Riepl a écrit : >> >> Hi, >> >> How do you suggest this should be fixed? >> A Debian patch that removes the line from compat.py? > > I ll check >> >> Or should the Debian package depend on python3-six? > > That s the fast solution >> >> Or is it a bug that must be fixed upstream? > > Also, all upstreams should remove usage of six.py
Bug#1060421: python3-botocore: botocore as a (useless) undeclared dependency on python3-six
CodeSearch tell us it's used twice elsewhere ... two other packages to check first https://codesearch.debian.net/search?q=+botocore.compat=1=1 awscli_2.14.6-1/tests/functional/s3/test_presign_command.py ---> I ll check out 2.15.8 python-s3transfer_0.7.0-1/s3transfer/compat.py ( so a compat.py that imports a compat.py !) > I ll package 0.10 & check So the quick & dirty solution is to add python3-six dependency, but there's no émergency and only 2 reverse dep to check. I ll ping you later. Greetings Le jeu. 11 janv. 2024, 20:43, Gregor Riepl a écrit : > Hi, > > How do you suggest this should be fixed? > A Debian patch that removes the line from compat.py? > I ll check > Or should the Debian package depend on python3-six? > That s the fast solution > Or is it a bug that must be fixed upstream? > Also, all upstreams should remove usage of six.py >
Bug#1060421: python3-botocore: botocore as a (useless) undeclared dependency on python3-six
Hi, python3-core is importing python3-six for absolutely no reason this package only work by luck for now because the library got pulled-in by something else (most likely python3-urllib2) $ grep ' six' /usr/lib/python3/dist-packages/botocore -r | grep import /usr/lib/python3/dist-packages/botocore/compat.py:import six How do you suggest this should be fixed? A Debian patch that removes the line from compat.py? Or should the Debian package depend on python3-six? Or is it a bug that must be fixed upstream? Regards, Gregor
Bug#1060421: python3-botocore: botocore as a (useless) undeclared dependency on python3-six
Package: python3-botocore Version: 1.31.49+repack-1 Severity: important X-Debbugs-Cc: debian-pyt...@lists.debian.org python3-core is importing python3-six for absolutely no reason this package only work by luck for now because the library got pulled-in by something else (most likely python3-urllib2) $ grep ' six' /usr/lib/python3/dist-packages/botocore -r | grep import /usr/lib/python3/dist-packages/botocore/compat.py:import six Greetings, A possibility to catch this earlier would be to add a deprecation warning inside python3-six ? -- System Information: Debian Release: trixie/sid APT prefers testing APT policy: (501, 'testing'), (450, 'unstable'), (400, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 6.5.0-5-amd64 (SMP w/2 CPU threads; PREEMPT) Kernel taint flags: TAINT_USER Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), LANGUAGE=fr_BE:fr Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) Versions of packages python3-botocore depends on: ii python3 3.11.4-5+b1 ii python3-dateutil 2.8.2-3 ii python3-jmespath 1.0.1-1 ii python3-requests 2.31.0+dfsg-1 ii python3-urllib3 2.0.7-1 python3-botocore recommends no packages. python3-botocore suggests no packages. -- no debconf information
