Bug#1061087: RFS: bash-unit/2.1.0-1 [RFP] -- bash_unit - bash unit testing

[Martin Dosch]

Dear Andrey,

On 06.04.2024 19:25, Andrey Rakhmatullin wrote:

You need to use bash_unit from the package. Likely as simple as
"./bash_unit".


thanks, that's it. Just pushed the changes and uploaded to mentors.

Best regards,
Martin


signature.asc
Description: PGP signature

Bug#1061087: RFS: bash-unit/2.1.0-1 [RFP] -- bash_unit - bash unit testing

[Andrey Rakhmatullin]

On Sat, Apr 06, 2024 at 02:14:11PM +, Martin Dosch wrote:
> > Hi Martin, you added a B-D on itself, I assume it's to run build-time
> > tests, buit the idea of build-time tests is to use the software being
> > package,
> 
> Do you know how to achieve this? When I remove the build-dep on itself the
> built fails as the test can not be performed:
> >debian/rules override_dh_auto_test
> > make[1]: Entering directory '/<>'
> > bash_unit -f tap ./tests/test_*
> > /bin/sh: 1: bash_unit: not found
> > make[1]: *** [debian/rules:9: override_dh_auto_test] Error 127
You need to use bash_unit from the package. Likely as simple as
"./bash_unit".

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#1061087: RFS: bash-unit/2.1.0-1 [RFP] -- bash_unit - bash unit testing

[Martin Dosch]

Dear Andrey,

On 06.04.2024 13:36, Andrey Rakhmatullin wrote:

Hi Martin, you added a B-D on itself, I assume it's to run build-time
tests, buit the idea of build-time tests is to use the software being
package, 


Do you know how to achieve this? When I remove the build-dep on itself 
the built fails as the test can not be performed:

   debian/rules override_dh_auto_test
make[1]: Entering directory '/<>'
bash_unit -f tap ./tests/test_*
/bin/sh: 1: bash_unit: not found
make[1]: *** [debian/rules:9: override_dh_auto_test] Error 127




not the version from repos (also B-D on itself orevents it from
being built).
Yes, as it's not yet in the repos I had to inject it locally to get it 
built.


Best regards,
Martin


signature.asc
Description: PGP signature

Bug#1061087: RFS: bash-unit/2.1.0-1 [RFP] -- bash_unit - bash unit testing

[Andrey Rakhmatullin]

On Fri, Apr 05, 2024 at 08:53:58PM +, Martin Dosch wrote:
> Dear Andrey,
> 
> thank you for the valuable feedback. I hope it is all properly settled now.
> I just uploaded a new build to mentors and pushed the changes to the repo.
Hi Martin, you added a B-D on itself, I assume it's to run build-time
tests, buit the idea of build-time tests is to use the software being
package, not the version from repos (also B-D on itself orevents it from
being built).


-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#1061087: RFS: bash-unit/2.1.0-1 [RFP] -- bash_unit - bash unit testing

[Martin Dosch]

Dear Andrey,

thank you for the valuable feedback. I hope it is all properly settled 
now. I just uploaded a new build to mentors and pushed the changes to 
the repo.


Thank you very much,
Martin


signature.asc
Description: PGP signature

Bug#1061087: RFS: bash-unit/2.1.0-1 [RFP] -- bash_unit - bash unit testing

[Andrey Rakhmatullin]

Control: tags -1 + moreinfo
Control: retitle -1 RFS: bash-unit/2.1.0-1 [ITP] -- bash_unit - bash unit 
testing

Some issues found after a quick review:

- The package should be arch:all and shouldn't use ${shlibs:Depends}.
- The GPL-3 snippet in d/copyright looks wrong.
- The upstream docs should be installed, especially the manpage.
- The manpage should be rebuilt at the package build time.
- The package has autopkgtests but no build-time tests, it should have
  both if that's possible (and it should be possible in this case).

Please remove the moreinfo tag after these are addressed.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#1061087: RFS: bash-unit/2.1.0-1 [RFP] -- bash_unit - bash unit testing

[Martin Dosch]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "bash-unit":

 * Package name : bash-unit
   Version  : 2.1.0-1
   Upstream contact : Pascal Grange 
 * URL  : https://github.com/pgrange/bash_unit
 * License  : GPL-3
 * Vcs  : https://salsa.debian.org/mdosch/bash-unit
   Section  : devel

The source builds the following binary packages:

  bash-unit - bash_unit - bash unit testing

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/bash-unit/

Alternatively, you can download the package with 'dget' using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/b/bash-unit/bash-unit_2.1.0-1.dsc

Changes for the initial release:

 bash-unit (2.1.0-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #839210)

Regards,
--
  Martin Dosch


signature.asc
Description: PGP signature