Bug#1062547: fastdds: NMU diff for 64-bit time_t transition

2024-02-27 Thread mwhudson
Dear maintainer,

Please find attached a final version of this patch for the time_t
transition.  This patch is being uploaded to unstable.

Note that this adds a versioned build-dependency on dpkg-dev, to guard
against accidental backports with a wrong ABI.

Thanks!


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-21-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru fastdds-2.11.2+ds/debian/changelog fastdds-2.11.2+ds/debian/changelog
--- fastdds-2.11.2+ds/debian/changelog  2023-10-24 07:18:49.0 +
+++ fastdds-2.11.2+ds/debian/changelog  2024-02-28 03:47:46.0 +
@@ -1,3 +1,10 @@
+fastdds (2.11.2+ds-6.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.  Closes: #1062547
+
+ -- Michael Hudson-Doyle   Wed, 28 Feb 2024 03:47:46 +
+
 fastdds (2.11.2+ds-6) unstable; urgency=medium
 
   * Disable tests as hotfix for GTest issue (Closes: #1052742)
diff -Nru fastdds-2.11.2+ds/debian/control fastdds-2.11.2+ds/debian/control
--- fastdds-2.11.2+ds/debian/control2023-10-24 07:17:49.0 +
+++ fastdds-2.11.2+ds/debian/control2024-02-28 03:47:46.0 +
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Debian Robotics Team 
 Uploaders: Timo Röhling 
-Build-Depends:
+Build-Depends: dpkg-dev (>= 1.22.5),
  debhelper-compat (= 13),
  cmake,
  doxygen ,
@@ -39,7 +39,10 @@
  focuses on usability, and a lower-level Writer-Reader API that allows more
  sophisticated fine tuning of the RTPS protocol.
 
-Package: libfastrtps2.11
+Package: libfastrtps2.11t64
+Provides: ${t64:Provides}
+Replaces: libfastrtps2.11
+Breaks: libfastrtps2.11 (<< ${source:Version})
 Architecture: any
 Multi-Arch: same
 Depends: 
@@ -58,7 +61,7 @@
  ${misc:Depends},
  libasio-dev,
  libfastcdr-dev,
- libfastrtps2.11 (= ${binary:Version}),
+ libfastrtps2.11t64 (= ${binary:Version}),
  libfoonathan-memory-dev,
  libssl-dev,
  libtinyxml2-dev,
diff -Nru fastdds-2.11.2+ds/debian/libfastrtps2.11.install 
fastdds-2.11.2+ds/debian/libfastrtps2.11.install
--- fastdds-2.11.2+ds/debian/libfastrtps2.11.install2023-10-24 
07:17:49.0 +
+++ fastdds-2.11.2+ds/debian/libfastrtps2.11.install1970-01-01 
00:00:00.0 +
@@ -1 +0,0 @@
-usr/lib/*/lib*.so.*
diff -Nru fastdds-2.11.2+ds/debian/libfastrtps2.11t64.install 
fastdds-2.11.2+ds/debian/libfastrtps2.11t64.install
--- fastdds-2.11.2+ds/debian/libfastrtps2.11t64.install 1970-01-01 
00:00:00.0 +
+++ fastdds-2.11.2+ds/debian/libfastrtps2.11t64.install 2023-10-24 
07:17:49.0 +
@@ -0,0 +1 @@
+usr/lib/*/lib*.so.*
diff -Nru fastdds-2.11.2+ds/debian/libfastrtps2.11t64.lintian-overrides 
fastdds-2.11.2+ds/debian/libfastrtps2.11t64.lintian-overrides
--- fastdds-2.11.2+ds/debian/libfastrtps2.11t64.lintian-overrides   
1970-01-01 00:00:00.0 +
+++ fastdds-2.11.2+ds/debian/libfastrtps2.11t64.lintian-overrides   
2024-02-28 03:47:34.0 +
@@ -0,0 +1 @@
+libfastrtps2.11t64: package-name-doesnt-match-sonames libfastrtps2.11


Bug#1062547: fastdds: NMU diff for 64-bit time_t transition

2024-02-01 Thread mwhudson
Source: fastdds
Version: 2.11.2+ds-6
Severity: serious
Tags: patch pending
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
fastdds as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for fastdds
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-15-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru fastdds-2.11.2+ds/debian/changelog fastdds-2.11.2+ds/debian/changelog
--- fastdds-2.11.2+ds/debian/changelog  2023-10-24 07:18:49.0 +
+++ fastdds-2.11.2+ds/debian/changelog  2024-02-01 21:48:37.0 +
@@ -1,3 +1,10 @@
+fastdds (2.11.2+ds-6.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Michael Hudson-Doyle   Thu, 01 Feb 2024 21:48:37 +
+
 fastdds (2.11.2+ds-6) unstable; urgency=medium
 
   * Disable tests as hotfix for GTest issue (Closes: #1052742)
diff -Nru fastdds-2.11.2+ds/debian/control fastdds-2.11.2+ds/debian/control
--- fastdds-2.11.2+ds/debian/control2023-10-24 07:17:49.0 +
+++ fastdds-2.11.2+ds/debian/control2024-02-01 21:48:37.0 +
@@ -39,7 +39,10 @@
  focuses on usability, and a lower-level Writer-Reader API that allows more
  sophisticated fine tuning of the RTPS protocol.
 
-Package: libfastrtps2.11
+Package: libfastrtps2.11t64
+Provides: ${t64:Provides}
+Replaces: libfastrtps2.11
+Breaks: libfastrtps2.11 (<< ${source:Version})
 Architecture: any
 Multi-Arch: same
 Depends: 
@@ -58,7 +61,7 @@
  ${misc:Depends},
  libasio-dev,
  libfastcdr-dev,
- libfastrtps2.11 (= ${binary:Version}),
+ libfastrtps2.11t64 (= ${binary:Version}),
  libfoonathan-memory-dev,
  libssl-dev,
  libtinyxml2-dev,
diff -Nru fastdds-2.11.2+ds/debian/libfastrtps2.11.install 
fastdds-2.11.2+ds/debian/libfastrtps2.11.install
--- fastdds-2.11.2+ds/debian/libfastrtps2.11.install2023-10-24 
07:17:49.0 +
+++ fastdds-2.11.2+ds/debian/libfastrtps2.11.install1970-01-01 
00:00:00.0 +
@@ -1 +0,0 @@
-usr/lib/*/lib*.so.*
diff -Nru fastdds-2.11.2+ds/debian/libfastrtps2.11t64.install 
fastdds-2.11.2+ds/debian/libfastrtps2.11t64.install
--- fastdds-2.11.2+ds/debian/libfastrtps2.11t64.install 1970-01-01 
00:00:00.0 +
+++ fastdds-2.11.2+ds/debian/libfastrtps2.11t64.install 2023-10-24 
07:17:49.0 +
@@ -0,0 +1 @@
+usr/lib/*/lib*.so.*
diff -Nru fastdds-2.11.2+ds/debian/libfastrtps2.11t64.lintian-overrides 
fastdds-2.11.2+ds/debian/libfastrtps2.11t64.lintian-overrides
--- fastdds-2.11.2+ds/debian/libfastrtps2.11t64.lintian-overrides   
1970-01-01 00:00:00.0 +
+++ fastdds-2.11.2+ds/debian/libfastrtps2.11t64.lintian-overrides   
2024-02-01 21:48:37.0 +
@@ -0,0 +1 @@
+libfastrtps2.11t64: package-name-doesnt-match-sonames libfastrtps2.11