Bug#1062866: ros-image-common: NMU diff for 64-bit time_t transition

2024-02-29 Thread Benjamin Drung
Source: ros-image-common
Dear maintainer,

Please find attached a final version of this patch for the time_t
transition.  This patch is being uploaded to unstable.

Note that this adds a versioned build-dependency on dpkg-dev, to guard
against accidental backports with a wrong ABI.

Thanks!


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-21-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru ros-image-common-1.12.0/debian/changelog 
ros-image-common-1.12.0/debian/changelog
--- ros-image-common-1.12.0/debian/changelog2022-08-29 12:44:21.0 
+
+++ ros-image-common-1.12.0/debian/changelog2024-02-29 23:04:06.0 
+
@@ -1,3 +1,10 @@
+ros-image-common (1.12.0-12.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.  Closes: #1062866
+
+ -- Benjamin Drung   Thu, 29 Feb 2024 23:04:06 +
+
 ros-image-common (1.12.0-12) unstable; urgency=medium
 
   * Drop nose dependency (Closes: #1018627)
diff -Nru ros-image-common-1.12.0/debian/control 
ros-image-common-1.12.0/debian/control
--- ros-image-common-1.12.0/debian/control  2022-08-29 12:43:48.0 
+
+++ ros-image-common-1.12.0/debian/control  2024-02-29 23:04:06.0 
+
@@ -3,7 +3,7 @@
 Maintainer: Debian Science Maintainers 

 Uploaders: Jochen Sprickerhof ,
Leopold Palomo-Avellaneda 
-Build-Depends: debhelper-compat (= 13), catkin (>= 0.8.10-1~), 
libsensor-msgs-dev, ros-sensor-msgs, librosconsole-dev, 
libboost-filesystem-dev, libboost-python-dev, libyaml-cpp-dev, libroscpp-dev, 
libmessage-filters-dev, pluginlib-dev, libroslib-dev, ros-message-generation, 
libstd-msgs-dev, ros-std-msgs, librostest-dev, python3-all, 
dh-sequence-python3, libpython3-all-dev, libgtest-dev, python3-rostest 
, python3-sensor-msgs , rosbash , rospack-tools 

+Build-Depends: dpkg-dev (>= 1.22.5), debhelper-compat (= 13), catkin (>= 
0.8.10-1~), libsensor-msgs-dev, ros-sensor-msgs, librosconsole-dev, 
libboost-filesystem-dev, libboost-python-dev, libyaml-cpp-dev, libroscpp-dev, 
libmessage-filters-dev, pluginlib-dev, libroslib-dev, ros-message-generation, 
libstd-msgs-dev, ros-std-msgs, librostest-dev, python3-all, 
dh-sequence-python3, libpython3-all-dev, libgtest-dev, python3-rostest 
, python3-sensor-msgs , rosbash , rospack-tools 

 Standards-Version: 4.6.1
 Section: libs
 Rules-Requires-Root: no
@@ -15,12 +15,16 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libcamera-calibration-parsers0d (= ${binary:Version}), 
${misc:Depends}, libsensor-msgs-dev, librosconsole-dev, libboost-filesystem-dev
+Depends: libcamera-calibration-parsers0t64 (= ${binary:Version}), 
${misc:Depends}, libsensor-msgs-dev, librosconsole-dev, libboost-filesystem-dev
 Description: Robot OS camera_calibration_parsers package - development
  This package is part of Robot OS (ROS). It contains C++ headers for
  reading and writing camera calibration parameters.
 
-Package: libcamera-calibration-parsers0d
+Package: libcamera-calibration-parsers0t64
+Provides: ${t64:Provides}
+X-Time64-Compat: libcamera-calibration-parsers0d
+Replaces: libcamera-calibration-parsers0d
+Breaks: libcamera-calibration-parsers0d (<< ${source:Version})
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Multi-Arch: same
@@ -52,13 +56,17 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libcamera-info-manager0d (= ${binary:Version}), ${misc:Depends}, 
libroscpp-dev, libsensor-msgs-dev, libcamera-calibration-parsers-dev, 
libimage-transport-dev, libroslib-dev
+Depends: libcamera-info-manager0t64 (= ${binary:Version}), ${misc:Depends}, 
libroscpp-dev, libsensor-msgs-dev, libcamera-calibration-parsers-dev, 
libimage-transport-dev, libroslib-dev
 Description: Robot OS camera_info_manager package - development
  This package is part of Robot OS (ROS). It provides C++ header files
  for camera calibration information: CameraInfo, SetCameraInfo service
  requests, saving and restoring the camera calibration data.
 
-Package: libcamera-info-manager0d
+Package: libcamera-info-manager0t64
+Provides: ${t64:Provides}
+X-Time64-Compat: libcamera-info-manager0d
+Replaces: libcamera-info-manager0d
+Breaks: libcamera-info-manager0d (<< ${source:Version})
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Multi-Arch: same
@@ -71,7 +79,7 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libimage-transport0d (= ${binary:Version}), ${misc:Depends}, 
libmessage-filters-dev, pluginlib-dev, librosconsole-dev, libroscpp-dev, 
libroslib-dev, libsensor-msgs-dev
+Depends: libimage-transport0t64 (= ${binary:Version}), 

Bug#1062866: ros-image-common: NMU diff for 64-bit time_t transition

2024-02-03 Thread Sergio Durigan Junior
Source: ros-image-common
Version: 1.12.0-12
Severity: serious
Tags: patch pending sid trixie
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

NOTICE: these changes must not be uploaded to unstable yet!

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
ros-image-common as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for ros-image-common
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-5-amd64 (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru ros-image-common-1.12.0/debian/changelog 
ros-image-common-1.12.0/debian/changelog
--- ros-image-common-1.12.0/debian/changelog2022-08-29 12:44:21.0 
+
+++ ros-image-common-1.12.0/debian/changelog2024-02-03 20:35:48.0 
+
@@ -1,3 +1,10 @@
+ros-image-common (1.12.0-12.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Sergio Durigan Junior   Sat, 03 Feb 2024 20:35:48 
+
+
 ros-image-common (1.12.0-12) unstable; urgency=medium
 
   * Drop nose dependency (Closes: #1018627)
diff -Nru ros-image-common-1.12.0/debian/control 
ros-image-common-1.12.0/debian/control
--- ros-image-common-1.12.0/debian/control  2022-08-29 12:43:48.0 
+
+++ ros-image-common-1.12.0/debian/control  2024-02-03 20:35:48.0 
+
@@ -15,12 +15,16 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libcamera-calibration-parsers0d (= ${binary:Version}), 
${misc:Depends}, libsensor-msgs-dev, librosconsole-dev, libboost-filesystem-dev
+Depends: libcamera-calibration-parsers0t64 (= ${binary:Version}), 
${misc:Depends}, libsensor-msgs-dev, librosconsole-dev, libboost-filesystem-dev
 Description: Robot OS camera_calibration_parsers package - development
  This package is part of Robot OS (ROS). It contains C++ headers for
  reading and writing camera calibration parameters.
 
-Package: libcamera-calibration-parsers0d
+Package: libcamera-calibration-parsers0t64
+Provides: ${t64:Provides}
+X-Time64-Compat: libcamera-calibration-parsers0d
+Replaces: libcamera-calibration-parsers0d
+Breaks: libcamera-calibration-parsers0d (<< ${source:Version})
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Multi-Arch: same
@@ -52,13 +56,17 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libcamera-info-manager0d (= ${binary:Version}), ${misc:Depends}, 
libroscpp-dev, libsensor-msgs-dev, libcamera-calibration-parsers-dev, 
libimage-transport-dev, libroslib-dev
+Depends: libcamera-info-manager0t64 (= ${binary:Version}), ${misc:Depends}, 
libroscpp-dev, libsensor-msgs-dev, libcamera-calibration-parsers-dev, 
libimage-transport-dev, libroslib-dev
 Description: Robot OS camera_info_manager package - development
  This package is part of Robot OS (ROS). It provides C++ header files
  for camera calibration information: CameraInfo, SetCameraInfo service
  requests, saving and restoring the camera calibration data.
 
-Package: libcamera-info-manager0d
+Package: libcamera-info-manager0t64
+Provides: ${t64:Provides}
+X-Time64-Compat: libcamera-info-manager0d
+Replaces: libcamera-info-manager0d
+Breaks: libcamera-info-manager0d (<< ${source:Version})
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Multi-Arch: same
@@ -71,7 +79,7 @@