Bug#1063229: pianobar: NMU diff for 64-bit time_t transition

2024-02-29 Thread Benjamin Drung
Source: pianobar
Dear maintainer,

Please find attached a final version of this patch for the time_t
transition.  This patch is being uploaded to unstable.

Note that this adds a versioned build-dependency on dpkg-dev, to guard
against accidental backports with a wrong ABI.

Thanks!


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-21-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru pianobar-2022.04.01/debian/changelog 
pianobar-2022.04.01/debian/changelog
--- pianobar-2022.04.01/debian/changelog2022-04-01 23:15:30.0 
+
+++ pianobar-2022.04.01/debian/changelog2024-02-29 20:48:11.0 
+
@@ -1,3 +1,10 @@
+pianobar (2022.04.01-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.  Closes: #1063229
+
+ -- Benjamin Drung   Thu, 29 Feb 2024 20:48:11 +
+
 pianobar (2022.04.01-1) unstable; urgency=medium
 
   * New upstream version 2022.04.01.
diff -Nru pianobar-2022.04.01/debian/control pianobar-2022.04.01/debian/control
--- pianobar-2022.04.01/debian/control  2022-04-01 23:15:04.0 +
+++ pianobar-2022.04.01/debian/control  2024-02-29 20:48:11.0 +
@@ -5,7 +5,7 @@
 Uploaders:
  Romain Beauxis ,
  Unit 193 
-Build-Depends:
+Build-Depends: dpkg-dev (>= 1.22.5),
  debhelper-compat (= 13),
  libao-dev,
  libavcodec-dev,
@@ -43,7 +43,10 @@
  You need an account in order to use this player, so please consider
  create one for free before using pianobar at https://pandora.com.
 
-Package: libpiano0
+Package: libpiano0t64
+Provides: ${t64:Provides}
+Replaces: libpiano0
+Breaks: libpiano0 (<< ${source:Version})
 Architecture: any
 Multi-Arch: same
 Section: libs
@@ -74,7 +77,7 @@
 Multi-Arch: same
 Section: libdevel
 Pre-Depends: ${misc:Pre-Depends}
-Depends: libpiano0 (= ${binary:Version}), ${misc:Depends}
+Depends: libpiano0t64 (= ${binary:Version}), ${misc:Depends}
 Description: library to interface with Pandora radio -- development
  libpiano is a cross-platform library to interface with the personalized
  web radio Pandora, supporting all important features the official Flashâ„¢
diff -Nru pianobar-2022.04.01/debian/libpiano0.install 
pianobar-2022.04.01/debian/libpiano0.install
--- pianobar-2022.04.01/debian/libpiano0.install2019-01-25 
13:23:34.0 +
+++ pianobar-2022.04.01/debian/libpiano0.install1970-01-01 
00:00:00.0 +
@@ -1,2 +0,0 @@
-usr/lib/*/libpiano.so.0.0.0
-usr/lib/*/libpiano.so.0
diff -Nru pianobar-2022.04.01/debian/libpiano0.symbols 
pianobar-2022.04.01/debian/libpiano0.symbols
--- pianobar-2022.04.01/debian/libpiano0.symbols2020-12-01 
03:09:50.0 +
+++ pianobar-2022.04.01/debian/libpiano0.symbols1970-01-01 
00:00:00.0 +
@@ -1,22 +0,0 @@
-libpiano.so.0 libpiano0 #MINVER#
-* Build-Depends-Package: libpiano-dev
- PianoDecryptString@Base 2011.04.19
- PianoDestroy@Base 2011.04.19
- PianoDestroyPlaylist@Base 2011.04.19
- PianoDestroyRequest@Base 2011.04.19
- PianoDestroySearchResult@Base 2011.04.19
- PianoDestroyStation@Base 2011.04.19
- PianoDestroyStationInfo@Base 2011.04.19
- PianoDestroyStationMode@Base 2020.11.28
- PianoDestroyUserInfo@Base 2012.05.06
- PianoEncryptString@Base 2011.04.19
- PianoErrorToStr@Base 2011.04.19
- PianoFindStationById@Base 2011.04.19
- PianoInit@Base 2011.04.19
- PianoListAppend@Base 2013.09.15
- PianoListCount@Base 2013.09.15
- PianoListDelete@Base 2013.09.15
- PianoListGet@Base 2013.09.15
- PianoListPrepend@Base 2013.09.15
- PianoRequest@Base 2011.04.19
- PianoResponse@Base 2011.04.19
diff -Nru pianobar-2022.04.01/debian/libpiano0t64.install 
pianobar-2022.04.01/debian/libpiano0t64.install
--- pianobar-2022.04.01/debian/libpiano0t64.install 1970-01-01 
00:00:00.0 +
+++ pianobar-2022.04.01/debian/libpiano0t64.install 2019-01-25 
13:23:34.0 +
@@ -0,0 +1,2 @@
+usr/lib/*/libpiano.so.0.0.0
+usr/lib/*/libpiano.so.0
diff -Nru pianobar-2022.04.01/debian/libpiano0t64.lintian-overrides 
pianobar-2022.04.01/debian/libpiano0t64.lintian-overrides
--- pianobar-2022.04.01/debian/libpiano0t64.lintian-overrides   1970-01-01 
00:00:00.0 +
+++ pianobar-2022.04.01/debian/libpiano0t64.lintian-overrides   2024-02-29 
20:48:03.0 +
@@ -0,0 +1 @@
+libpiano0t64: package-name-doesnt-match-sonames libpiano0
diff -Nru pianobar-2022.04.01/debian/libpiano0t64.symbols 
pianobar-2022.04.01/debian/libpiano0t64.symbols
--- pianobar-2022.04.01/debian/libpiano0t64.symbols 1970-01-01 
00:00:00.0 +
+++ pianobar-2022.04.01/debian/libpiano0t64.symbols 2024-02-29 
20:48:03.0 +
@@ -0,0 +1,22 @@

Bug#1063229: pianobar: NMU diff for 64-bit time_t transition

2024-02-05 Thread Lucas Kanashiro
Source: pianobar
Version: 2022.04.01-1
Severity: serious
Tags: patch pending sid trixie
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

NOTICE: these changes must not be uploaded to unstable yet!

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
pianobar as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for pianobar
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.2.0-39-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru pianobar-2022.04.01/debian/changelog 
pianobar-2022.04.01/debian/changelog
--- pianobar-2022.04.01/debian/changelog2022-04-01 20:15:30.0 
-0300
+++ pianobar-2022.04.01/debian/changelog2024-02-05 15:49:13.0 
-0300
@@ -1,3 +1,10 @@
+pianobar (2022.04.01-1.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Lucas Kanashiro   Mon, 05 Feb 2024 15:49:13 -0300
+
 pianobar (2022.04.01-1) unstable; urgency=medium
 
   * New upstream version 2022.04.01.
diff -Nru pianobar-2022.04.01/debian/control pianobar-2022.04.01/debian/control
--- pianobar-2022.04.01/debian/control  2022-04-01 20:15:04.0 -0300
+++ pianobar-2022.04.01/debian/control  2024-02-05 15:49:13.0 -0300
@@ -43,7 +43,10 @@
  You need an account in order to use this player, so please consider
  create one for free before using pianobar at https://pandora.com.
 
-Package: libpiano0
+Package: libpiano0t64
+Provides: ${t64:Provides}
+Replaces: libpiano0
+Breaks: libpiano0 (<< ${source:Version})
 Architecture: any
 Multi-Arch: same
 Section: libs
@@ -74,7 +77,7 @@
 Multi-Arch: same
 Section: libdevel
 Pre-Depends: ${misc:Pre-Depends}
-Depends: libpiano0 (= ${binary:Version}), ${misc:Depends}
+Depends: libpiano0t64 (= ${binary:Version}), ${misc:Depends}
 Description: library to interface with Pandora radio -- development
  libpiano is a cross-platform library to interface with the personalized
  web radio Pandora, supporting all important features the official Flashâ„¢
diff -Nru pianobar-2022.04.01/debian/libpiano0.install 
pianobar-2022.04.01/debian/libpiano0.install
--- pianobar-2022.04.01/debian/libpiano0.install2019-01-25 
11:23:34.0 -0200
+++ pianobar-2022.04.01/debian/libpiano0.install1969-12-31 
21:00:00.0 -0300
@@ -1,2 +0,0 @@
-usr/lib/*/libpiano.so.0.0.0
-usr/lib/*/libpiano.so.0
diff -Nru pianobar-2022.04.01/debian/libpiano0.symbols 
pianobar-2022.04.01/debian/libpiano0.symbols
--- pianobar-2022.04.01/debian/libpiano0.symbols2020-12-01 
00:09:50.0 -0300
+++ pianobar-2022.04.01/debian/libpiano0.symbols1969-12-31 
21:00:00.0 -0300
@@ -1,22 +0,0 @@
-libpiano.so.0 libpiano0 #MINVER#
-* Build-Depends-Package: libpiano-dev
- PianoDecryptString@Base 2011.04.19
- PianoDestroy@Base 2011.04.19
- PianoDestroyPlaylist@Base 2011.04.19
- PianoDestroyRequest@Base 2011.04.19
- PianoDestroySearchResult@Base 2011.04.19
- PianoDestroyStation@Base 2011.04.19
- PianoDestroyStationInfo@Base 2011.04.19
- PianoDestroyStationMode@Base 2020.11.28
- PianoDestroyUserInfo@Base 2012.05.06
- PianoEncryptString@Base 2011.04.19
- PianoErrorToStr@Base 2011.04.19
- PianoFindStationById@Base 2011.04.19
- PianoInit@Base 2011.04.19
- PianoListAppend@Base 2013.09.15
- PianoListCount@Base