Bug#1063762: Build path leaks in generated documents, introducing reproducibility issues

2024-02-12 Thread Colin Watson
On Mon, Feb 12, 2024 at 01:37:56PM +0100, Enrico Zini wrote:
> Hello, and thank you for your work on sphinx!
> 
> Possibly due to 
> https://salsa.debian.org/python-team/packages/sphinx/-/commit/4a1ebb237fb0f10adef3df39c2844aa68b9da79c
> sphinx leaks the build path into the generated output (see attached
> output.html.gz).
> 
> This looks like an accidental mistake that is currently making packages
> unreproducible.

This actually turns out not to be a sphinx regression at all.  It's just
a coincidence that this upload was at around the same time as
https://salsa.debian.org/salsa-ci-team/pipeline/-/commit/9d97899bfdfde393d69312a67881330ade63b5ba,
which enabled build path variation in reprotest runs that we were
previously missing.

I think the correct fix is to enable the todo_link_only option on our
side.  I'm currently testing that, and if that works then I think this
bug can be closed.

-- 
Colin Watson (he/him)  [cjwat...@debian.org]



Bug#1063762: Build path leaks in generated documents, introducing reproducibility issues

2024-02-12 Thread Enrico Zini
Package: sphinx
Version: 7.2.6-4
Severity: important

Hello, and thank you for your work on sphinx!

Possibly due to 
https://salsa.debian.org/python-team/packages/sphinx/-/commit/4a1ebb237fb0f10adef3df39c2844aa68b9da79c
sphinx leaks the build path into the generated output (see attached
output.html.gz).

This looks like an accidental mistake that is currently making packages
unreproducible.


Thanks,

Enrico


-- System Information:
Debian Release: 12.4
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.1.0-15-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_IE:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled