Bug#1066707: ifupdown-ng: FTBFS: libifupdown/interface.c:28:9: error: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Werror=implicit-function-declaration]

2024-03-13 Thread Daniel Gröber
On Wed, Mar 13, 2024 at 12:51:44PM +0100, Lucas Nussbaum wrote:
> Source: ifupdown-ng
>
> During a rebuild of all packages in sid, your package failed to build
> on amd64.

Thanks Lucas, I'm uploading a fix right now.

> This is most likely caused by a change in dpkg 1.22.6, that enabled
> -Werror=implicit-function-declaration. For more information, see
> https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

It was due to a hardcoded path to libbsd's include directory which seems to
have moved to to a multiarch location.

Thanks,
--Daniel


signature.asc
Description: PGP signature


Bug#1066707: ifupdown-ng: FTBFS: libifupdown/interface.c:28:9: error: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Werror=implicit-function-declaration]

2024-03-13 Thread Lucas Nussbaum
Source: ifupdown-ng
Version: 0.12.1-3
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes 
> -Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd 
> -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. 
> -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" 
> -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" 
> -DPACKAGE_NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" 
> -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\; 
> -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML  -c -o 
> libifupdown/environment.o libifupdown/environment.c
> libifupdown/interface.c: In function ‘lif_address_parse’:
> libifupdown/interface.c:28:9: error: implicit declaration of function 
> ‘strlcpy’; did you mean ‘strncpy’? [-Werror=implicit-function-declaration]
>28 | strlcpy(buf, presentation, sizeof buf);
>   | ^~~
>   | strncpy
> cc -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes 
> -Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd 
> -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. 
> -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" 
> -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" 
> -DPACKAGE_NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" 
> -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\; 
> -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML  -c -o 
> libifupdown/execute.o libifupdown/execute.c
> cc -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes 
> -Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd 
> -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. 
> -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" 
> -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" 
> -DPACKAGE_NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" 
> -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\; 
> -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML  -c -o 
> libifupdown/lifecycle.o libifupdown/lifecycle.c
> cc -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes 
> -Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd 
> -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. 
> -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" 
> -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" 
> -DPACKAGE_NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" 
> -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\; 
> -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\" -DCONFIG_YAML  -c -o 
> libifupdown/config-parser.o libifupdown/config-parser.c
> libifupdown/interface-file.c: In function ‘maybe_remap_token’:
> libifupdown/interface-file.c:129:9: error: implicit declaration of function 
> ‘strlcpy’; did you mean ‘strncpy’? [-Werror=implicit-function-declaration]
>   129 | strlcpy(tokbuf, tok != NULL ? tok->alternative : token, 
> sizeof tokbuf);
>   | ^~~
>   | strncpy
> cc -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wall -Wextra -Werror -Wmissing-declarations -Wmissing-prototypes 
> -Wcast-align -Wpointer-arith -Wreturn-type -isystem /usr/include/bsd 
> -DLIBBSD_OVERLAY -Wdate-time -D_FORTIFY_SOURCE=2 -I. 
> -DINTERFACES_FILE=\"/etc/network/interfaces\" -DSTATE_FILE=\"/run/ifstate\" 
> -DCONFIG_FILE=\"/etc/network/ifupdown-ng.conf\" 
> -DPACKAGE_NAME=\"ifupdown-ng\" -DPACKAGE_VERSION=\"0.12.1\" 
> -DPACKAGE_BUGREPORT=\"https://github.com/ifupdown-ng/ifupdown-ng/issues/new\; 
> -DEXECUTOR_PATH=\"/usr/libexec/ifupdown-ng\"