Bug#1067222: dgit yields unparseable patches when color.ui=always

2024-03-20 Thread Ian Jackson
Control: severity -1 important

Rafael Laboissière writes ("Bug#1067222: dgit yields unparseable patches when 
color.ui=always"):
> Package: dgit
> Version: 11.6
> Severity: normal
...
> I have stumbled on a problem related to this specific Git configuration:
> 
> [color]
> ui = always
> 
> With such a configuration, the internal calls to "git diff" in dgit 
> yield unparseable patches, making dgit unusable.

How exciting.

> Would it be possible to add the option "-c color.ui=never" wherever 
> "git diff" is called in dgit?

Something should definitely be done about this.  Sometimes dgit runs
`git diff` for the benefit of the user in which case it should
probably respect this setting.

Maybe some of the `git diff` calls should be some more plumbingy
command.  There might be other things you could write in your git
config which would affect generated patches, and we ought to override
(or ignore) those too.

Ian.

-- 
Ian JacksonThese opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.



Bug#1067222: dgit yields unparseable patches when color.ui=always

2024-03-20 Thread Rafael Laboissière
Package: dgit
Version: 11.6
Severity: normal

Dear Maintainer,

I have stumbled on a problem related to this specific Git configuration:

[color]
ui = always

With such a configuration, the internal calls to "git diff" in dgit 
yield unparseable patches, making dgit unusable.

Would it be possible to add the option "-c color.ui=never" wherever 
"git diff" is called in dgit?

Best,

Rafael Laboissière