Bug#1067627: FTBFS: error: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘long int’

2024-04-04 Thread Benjamin Drung
On Mon, 25 Mar 2024 00:34:21 +0500 Andrey Rakhmatullin 
wrote:
> Source: xpra
> Version: 3.1.5+dfsg1-0.2
> Severity: serious
> Tags: ftbfs
> 
>
https://buildd.debian.org/status/fetch.php?pkg=xpra=i386=3.1.5%2Bdfsg1-0.2%2Bb3=1710056306=0
> 
> xpra/x11/bindings/keyboard_bindings.c: In function
‘__Pyx_PyInt_AndObjC’:
> xpra/x11/bindings/keyboard_bindings.c:30158:36: error: comparison of
integer
> expressions of different signedness: ‘long unsigned int’ and ‘long
int’
> [-Werror=sign-compare]
> 30158 | if ((intval & PyLong_MASK) == intval) {
>   |    ^~
> xpra/x11/bindings/keyboard_bindings.c:30160:71: error: operand of ‘?:’
changes
> signedness from ‘long int’ to ‘long unsigned int’ due to unsignedness
of other
> operand [-Werror=sign-compare]
> 30160 | long result = intval &
(likely(__Pyx_PyLong_IsPos(op1)) ?
> last_digit : (PyLong_MASK - last_digit + 1));
>   |
> ^~
> 
> 
> Note that the package enables -Werror.

I applied the attached patch to the Ubuntu package to disable -Werror
for the package build.

-- 
Benjamin Drung
Debian & Ubuntu Developer
diff -Nru xpra-3.1.5+dfsg1/debian/rules xpra-3.1.5+dfsg1/debian/rules
--- xpra-3.1.5+dfsg1/debian/rules	2023-09-15 13:15:05.0 +0200
+++ xpra-3.1.5+dfsg1/debian/rules	2024-04-04 14:00:41.0 +0200
@@ -10,7 +10,7 @@
 ifneq (,$(filter i386,$(DEB_HOST_ARCH)))
 EXTRA_BUILDOPTS := --without-csc_swscale --without-enc_ffmpeg --without-dec_avcodec2
 endif
-BUILDOPTS= --with-verbose --with-Xdummy --without-Xdummy_wrapper --with-html5 --without-minify --without-html5_gzip $(EXTRA_BUILDOPTS)
+BUILDOPTS= --with-verbose --with-Xdummy --without-Xdummy_wrapper --with-html5 --without-minify --without-html5_gzip --without-strict $(EXTRA_BUILDOPTS)
 
 export PYBUILD_CONFIG_ARGS=$(BUILDOPTS)
 export PYBUILD_BUILD_ARGS=$(BUILDOPTS)


Bug#1067627: FTBFS: error: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘long int’

2024-03-24 Thread Andrey Rakhmatullin
Source: xpra
Version: 3.1.5+dfsg1-0.2
Severity: serious
Tags: ftbfs

https://buildd.debian.org/status/fetch.php?pkg=xpra=i386=3.1.5%2Bdfsg1-0.2%2Bb3=1710056306=0

xpra/x11/bindings/keyboard_bindings.c: In function ‘__Pyx_PyInt_AndObjC’:
xpra/x11/bindings/keyboard_bindings.c:30158:36: error: comparison of integer
expressions of different signedness: ‘long unsigned int’ and ‘long int’
[-Werror=sign-compare]
30158 | if ((intval & PyLong_MASK) == intval) {
  |^~
xpra/x11/bindings/keyboard_bindings.c:30160:71: error: operand of ‘?:’ changes
signedness from ‘long int’ to ‘long unsigned int’ due to unsignedness of other
operand [-Werror=sign-compare]
30160 | long result = intval & (likely(__Pyx_PyLong_IsPos(op1)) ?
last_digit : (PyLong_MASK - last_digit + 1));
  |
^~


Note that the package enables -Werror.


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 
'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.7.9-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled