Bug#202488: isdnvboxserver: Spool directory incorrectly renamed on upgrade

2006-11-07 Thread Steve Langasek
tags 202488 patch
thanks

Looking at the changelog, it seems that the code causing these problems has
been present since version 1:3.1pre1b-13, which predates the version that
shipped with woody.  So any upgrade problems this code was written to
address are certainly a total non-issue now...

Therefore I'm uploading the attached patch as an NMU, to remove the upgrade
logic that's breaking users' vboxconfig and spooldir settings on upgrade.
These are config files, so user settings must be honored per policy; since
clearly anyone upgrading from sarge won't be in need of this particular
upgrade bit anyway, there's no reason to keep it at all, its only use is as
a policy violation.

NMU will be uploaded to incoming shortly.

Cheers,
-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
[EMAIL PROTECTED]   http://www.debian.org/
diff -u isdnutils-3.9.20060704/debian/changelog 
isdnutils-3.9.20060704/debian/changelog
--- isdnutils-3.9.20060704/debian/changelog
+++ isdnutils-3.9.20060704/debian/changelog
@@ -1,3 +1,13 @@
+isdnutils (1:3.9.20060704-2.2) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * High-urgency upload for RC bugfix.
+  * Don't set vboxconfig and spooldir settings in vboxgetty.conf,
+because there are no provisions for honoring user changes to these 
+settings, which is a policy violation.  Closes: #202488.
+
+ -- Steve Langasek [EMAIL PROTECTED]  Tue,  7 Nov 2006 00:18:58 -0800
+
 isdnutils (1:3.9.20060704-2.1) unstable; urgency=low
 
   * NMU
diff -u isdnutils-3.9.20060704/debian/isdnvboxserver.templates 
isdnutils-3.9.20060704/debian/isdnvboxserver.templates
--- isdnutils-3.9.20060704/debian/isdnvboxserver.templates
+++ isdnutils-3.9.20060704/debian/isdnvboxserver.templates
@@ -61,41 +61,12 @@
 _Description: Enter the password for ${User} here.
  Please don't use ':' in it! The way it is stored cannot handle this.
 
-Template: isdnvboxserver/spoolrename
-Type: note
-_Description: spool directory renamed
- The spool directory `${OLDSPOOL}' has been renamed to `${NEWSPOOL}' for
- consistency's sake. This should have no other consequences.
-
-Template: isdnvboxserver/dup3spool
-Type: note
-_Description: two obsolete spool directories detected
- The directories `${OLDSPOOL1}' and `${OLDSPOOL2}' (which aren't used
- anymore in the standard configuration), and the new spool directory
- `${NEWSPOOL}' all exist. The old directories will no longer be used;
- please manually move any messages from there to the new directory (if
- any), and delete the old directories.
-
-Template: isdnvboxserver/dupspool
-Type: note
-_Description: two spool directories detected
- The old spool directory `${OLDSPOOL}' and the new spool directory
- `${NEWSPOOL}' both exist. The old directory will no longer be used; please
- manually move any messages from there to the new directory (if any), and
- delete the old directory.
-
 Template: isdnvboxserver/spoolcreate
 Type: note
 _Description: spool directory created
  The spool directory `${NEWSPOOL}' has been created, which is necessary for
  proper working of vbox.
 
-Template: isdnvboxserver/vboxmoved
-Type: note
-_Description: vbox config file moved
- The configuration file `${OLD}' has been moved to `${DIR}/.vbox.conf'. 
- See `man vbox.conf' for information on changing this file.
-
 Template: isdnvboxserver/vboxcreate
 Type: note
 _Description: vbox config file created
diff -u isdnutils-3.9.20060704/debian/isdnvboxserver.postinst 
isdnutils-3.9.20060704/debian/isdnvboxserver.postinst
--- isdnutils-3.9.20060704/debian/isdnvboxserver.postinst
+++ isdnutils-3.9.20060704/debian/isdnvboxserver.postinst
@@ -91,7 +91,6 @@
 # fi
 # db_go || true
 # fi
-VBOX_CONFFILE=
 if [ -s /etc/isdn/vboxgetty.conf ]; then
 # only use ttyI6
 eval `perl -- - /etc/isdn/vboxgetty.conf 'EOF'
@@ -115,18 +114,6 @@
 db_go
 fi
 fi
-if [ -s /etc/isdn/vboxd.conf ]; then
-eval `perl -- - /etc/isdn/vboxd.conf 'EOF'
-while () { last if m,^# Remove this comment if you don.t want,; }
-# next line is the one
-if ($_ = ) {
-m,^A:[^:]+:[^:]+:([^:]+):([^:]+):([^:]+),;
-print VBOX_USERSPOOL=$3\n;
-exit 0;
-}
-EOF
-`
-fi
 db_get isdnvboxserver/user || true
 VBOX_USER=`echo $RET | tr -d ' '`
 if [ ! -z $VBOX_USER ]; then
@@ -136,122 +123,11 @@
 db_get isdnvboxserver/daemonuser || true
 VBOX_DUSER=`echo $RET | tr -d ' '`
 
-###
-# We have to clean up a big (potential) mess here.
-# There were different places where the spooldir could be:
-#
-# - /var/spool/vbox/${name of daemon user}
-# - /var/spool/vbox/${name of vboxd user}
-# - /var/spool/vbox/${something else?}
-#
-# I want to normalize this to just:
-#
-# - /var/spool/vbox/${name of ttyI device}
-#
-# which is more logical as multiple (vboxd) users can access the same
-# spool. 

Bug#202488: isdnvboxserver: Spool directory incorrectly renamed on upgrade

2006-09-26 Thread Steve Langasek
Is anyone working on this release critical bug?

Might I suggest that dropping the isdnvboxserver package for now might be a
better option than having all of isdnutils (and reverse-dependencies)
dropped from etch?

Cheers,
-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
[EMAIL PROTECTED]   http://www.debian.org/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#202488: isdnvboxserver: Spool directory incorrectly renamed on upgrade

2006-08-28 Thread Julian Mehnle
package isdnvboxserver
severity 202488 serious
# Justification: Breaks package on every upgrade
thanks

This bug has occurred to us multiple times, everytime I upgrade 
isdnvboxserver!  It always renames the spooldir to ttyI6 and thus breaks 
operation.  On top of this, it always gives the following brain-dead 
debconf note:

|  Configuring isdnvboxserver 
| 
| two obsolete spool directories detected
| 
| The directories `/vvaarr/ssppll/vvbbooxx/doesntexist_1' and
| `/vvaarr/ssppll/vvbbooxx/doesntexist_1' (which aren't used anymore in
| the standard configuration), and the new spool directory
| `/var/spool/vbox/ttyI6' all exist. The old directories will no longer be
| used; please manually move any messages from there to the new directory
| (if any), and delete the old directories. 

This package is seriously broken!


pgpEgRscBthpm.pgp
Description: PGP signature