Bug#214244: aptitude: add depends for auto-upgraded packages also

2016-02-05 Thread Manuel A. Fernandez Montecelo

2015-10-01 19:57 To Radim Kolar:

Control: tags -1 + moreinfo


Hi Radim,

2003-10-05 17:17 Radim Kolar:

Package: aptitude
Version: 0.2.13-2
Severity: wishlist

aptitude prints depend information with -D switch, this is a usefull
feature, which is badly missing from apt.

But depend information is printed only for:
1) The following NEW packages will be automatically installed:
2) The following packages will be automatically REMOVED:

but this  depend information is not printed for auto-upgraded packages
- The following packages will be upgraded:


That is because there is no distinction in the code between manually and
automatically upgraded (or downgraded).  This would probably be very
complex and it's not going to be looked at immediately.

It can be easily implemented for all upgraded or downgraded, but since
-D is supposedly only for automatically changed, I don't know if it
makes sense to do the change under these conditions.


-DShow the dependencies of automatically changed packages.



The attached patch implements the mentioned feature (part of the
original request), but as I said above, I don't know if it should be
applied because it is not clear if it matches the documentation, etc
(thus keeping "+moreinfo" for thinking further about it).

I figured that it's better to attach it here in the case that it's lost,
or so it can inspire other people looking to the reports.


Cheers.
--
Manuel A. Fernandez Montecelo 
diff --git a/src/generic/apt/infer_reason.cc b/src/generic/apt/infer_reason.cc
index 3ebea51..544631e 100644
--- a/src/generic/apt/infer_reason.cc
+++ b/src/generic/apt/infer_reason.cc
@@ -96,7 +96,14 @@ void infer_reason(pkgCache::PkgIterator pkg, set )
   pkgCache::VerIterator instver=state.InstVerIter(*apt_cache_file);
   pkgCache::VerIterator candver=state.CandidateVerIter(*apt_cache_file);
 
-  if(actionstate==pkg_auto_install)
+  // https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=214244
+  //
+  // Debian Bug report logs - #214244
+  // aptitude: add depends for auto-upgraded packages also
+  if (actionstate==pkg_auto_install ||
+  actionstate==pkg_install ||
+  actionstate==pkg_upgrade ||
+  actionstate==pkg_downgrade)
 {
   for(rev_dep_iterator d(instver); !d.end(); ++d)
 	if(!is_conflict((*d)->Type) &&


Bug#214244: aptitude: add depends for auto-upgraded packages also

2015-10-01 Thread Manuel A. Fernandez Montecelo

Control: tags -1 + moreinfo


Hi Radim,

2003-10-05 17:17 Radim Kolar:

Package: aptitude
Version: 0.2.13-2
Severity: wishlist

aptitude prints depend information with -D switch, this is a usefull
feature, which is badly missing from apt.

But depend information is printed only for:
1) The following NEW packages will be automatically installed:
2) The following packages will be automatically REMOVED:

but this  depend information is not printed for auto-upgraded packages
- The following packages will be upgraded:


That is because there is no distinction in the code between manually and
automatically upgraded (or downgraded).  This would probably be very
complex and it's not going to be looked at immediately.

It can be easily implemented for all upgraded or downgraded, but since
-D is supposedly only for automatically changed, I don't know if it
makes sense to do the change under these conditions.


 -DShow the dependencies of automatically changed packages.


Cheers.
--
Manuel A. Fernandez Montecelo