Package: jack
Version: 3.1.1-1
Severity: normal
Tags: patch
[CD that has a freedb disc ID of 5a092508 is an example for this]
Jack was not able to rename a file, but the error message did not show
the target filename and was not clear about the problem.
[majuli jack-5a092508]$ jack -q
This is jack 3.1.1 (C)2004 Arne Zellentin [EMAIL PROTECTED]
*warning* config file /etc/jackrc is of unknown version None.
*info* querying...
Tagging. *error* Cannot rename track_01.mp3 (Filename too long?)
The reason for the failure was this ...
snip from '[majuli jack-5a092508]$ strace jack -q'
write(4, TAGShankar Mahadevan / Dil Chaht..., 128) = 128
stat64(01_Shankar_Mahadevan_/_Dil_Chahta_Hai.mp3, 0xb650) = -1 ENOENT (No
such file or directory)
rename(track_01.mp3, 01_Shankar_Mahadevan_/_Dil_Chahta_Hai.mp3) = -1 ENOENT
(No such file or directory)
futex(0x813b990, FUTEX_WAKE, 1) = 0
The attached patch when applied, would also display the target filename and a
possible reason for the same. IMO, it is important that the target filename
be displayed.
[majuli jack-5a092508]$ jack -q
This is jack 3.1.1 (C)2004 Arne Zellentin [EMAIL PROTECTED]
*warning* config file /etc/jackrc is of unknown version None.
*info* querying...
Tagging. *error* Cannot rename track_01.mp3 to
01_Shankar_Mahadevan_/_Dil_Chahta_Hai.mp3 (Filename is too long or
has unusable characters)
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.10-1-686
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Versions of packages jack depends on:
ii cdparanoia3a9.8-11 An audio extraction tool for sampl
ii python2.3.5-1An interactive high-level object-o
ii python-cddb 1.4-3 Python interface to CD-IDs and Fre
ii python-id31.2-6.1Python module for id3-tags manipul
ii python-id3lib 0.5.1-3id3lib wrapper for Python - dummy
ii python-pyvorbis 1.3-1 A Python interface to the Ogg Vorb
ii vorbis-tools 1.0.1-1.2 Several Ogg Vorbis Tools
-- no debconf information
--- /usr/lib/python2.3/site-packages/jack_tag.py2005-03-10
15:18:34.695670416 +0530
+++ jack_tag.py 2005-03-10 15:18:24.407234496 +0530
@@ -174,7 +174,7 @@
try:
os.rename(mp3name, newname + ext)
except OSError:
-error('Cannot rename %s (Filename too
long?)' % mp3name)
+error('Cannot rename %s to %s (Filename is
too long or has unusable characters)' % (mp3name, newname + ext))
jack_m3u.add(newname + ext)
if cf['_keep_wavs']:
os.rename(wavname, newname + .wav)
