Package: dak
Version: whatever runs the debian archive
Severity: normal
thanks

For those of you not following the story so far:  my upload was rejected by
katie because I use policy URLs when I sign things.  Below is a fix that
will make katie and neve just ignore policy URLs.

On Saturday 16 April 2005 15.17, you wrote:
> >  - Is it realistic that a patch will be applied to katie to ignore
> > POLICY_URLs?  (I can try to write it, but I won't if it's difficult to
> > get such changes accepted anyway.)
>
> It looks like woody's gpgv simply chokes on that signature, and I
> consider it extremely unlikely a bugfix/whatever for gpgv will be
> installed on ftp-master, I think it'll need to wait until ftp-master is
> upgraded to sarge.

Hmmm. AFAICT gpgv from woody has no problem with policy URLs, but just 
prints additional output which confuses katie - the problem won't go 
away when ftp-master is sarge.

gpgv 1.0.6:
 ./gpgv --status-fd 1 --homedir ~/tmp < 
~/deb/postgrey/postgrey_1.21-1_i386.changes 2>/dev/null
[GNUPG:] SIG_ID PLNKM40jZlGYRTzu4R2QiDcHHUM 2005-04-16 1113645917
[GNUPG:] GOODSIG 8BA4318BE5A7F7D6 Adrian von Bidder <[EMAIL PROTECTED]>
[GNUPG:] POLICY_URL 
http://fortytwo.ch/legal/gpg/packaging.20030809?version=1.1&md5sum=e0b3f16a64bebaf0440fa029b1a9db21
[GNUPG:] VALIDSIG 5F5B2AF6295EFD25913A507C8BA4318BE5A7F7D6 2005-04-16 1113645917

gpgv 1.2.5:
/usr/bin/gpgv --status-fd 1 --homedir ~/tmp < 
~/deb/postgrey/postgrey_1.21-1_i386.changes 2>/dev/null
[GNUPG:] SIG_ID PLNKM40jZlGYRTzu4R2QiDcHHUM 2005-04-16 1113645917
[GNUPG:] GOODSIG 8BA4318BE5A7F7D6 Adrian von Bidder <[EMAIL PROTECTED]>
[GNUPG:] POLICY_URL 
http://fortytwo.ch/legal/gpg/packaging.20030809?version=1.1&md5sum=e0b3f16a64bebaf0440fa029b1a9db21
[GNUPG:] VALIDSIG 5F5B2AF6295EFD25913A507C8BA4318BE5A7F7D6 2005-04-16 
1113645917 0 4 0 17 2 01 EFE396F418F58D65849428FC1438516892082481

So we're back on field 1 :-)

The fix seems rather easy:

Index: utils.py
===================================================================
RCS file: /cvs/dak/dak/utils.py,v
retrieving revision 1.73
diff -u -r1.73 utils.py
--- utils.py    18 Mar 2005 05:24:38 -0000      1.73
+++ utils.py    16 Apr 2005 14:36:12 -0000
@@ -990,7 +990,7 @@
     # Finally ensure there's not something we don't recognise
     known_keywords = Dict(VALIDSIG="",SIG_ID="",GOODSIG="",BADSIG="",ERRSIG="",
                           SIGEXPIRED="",KEYREVOKED="",NO_PUBKEY="",BADARMOR="",
-                          NODATA="");
+                          NODATA="",POLICY_URL="");
 
     for keyword in keywords.keys():
         if not known_keywords.has_key(keyword):


there seems to be some code duplication - what is neve???  But let's fix it
anyway... :-)

Index: neve
===================================================================
RCS file: /cvs/dak/dak/neve,v
retrieving revision 1.20
diff -u -r1.20 neve
--- neve        17 Jun 2004 14:59:57 -0000      1.20
+++ neve        16 Apr 2005 14:38:58 -0000
@@ -193,7 +193,7 @@
     # Finally ensure there's not something we don't recognise
     known_keywords = 
utils.Dict(VALIDSIG="",SIG_ID="",GOODSIG="",BADSIG="",ERRSIG="",
                                 
SIGEXPIRED="",KEYREVOKED="",NO_PUBKEY="",BADARMOR="",
-                                NODATA="");
+                                NODATA="",POLICY_URL="");
 
     for keyword in keywords.keys():
         if not known_keywords.has_key(keyword):


As I don't run dak anywhere at home, this is completely untested and was
arrived at by spending no more than 30 seconds looking at the code, by
somebody who hasn't done anything in Python for more than 2 years.

Also, this is a minimal fix.  You might want to ignore whatever gpgv says
when it encounters notation packets or whatever else there is as well.

> Meanwhile, just don't include this policy url then 
> for signing packages.

Sure, that's the obvious workaround, and I'll do that until a fix is
implemented.

-- vbi

-- 
Beware of the FUD - know your enemies. This week
    * Patent Law, and how it is currently abused. *
http://fortytwo.ch/opinion

Attachment: pgpV40Uhn1tzg.pgp
Description: PGP signature

Reply via email to