Package: apt-listchanges
Version: 0.59-0.2
Severity: normal
Tags: patch

If apt is in quiet mode, apt-listchanges forces the frontend to text or
mail, depending on the quietness, before checking whether the frontend
was already 'none'. Since the text frontend prompts for input from
/dev/tty, this makes it impossible to use 'APT_LISTCHANGES_FRONTEND=none
apt-get -q' noninteractively.

The attached patch simply checks for the none frontend before the quiet
check. (Incidentally, no matter which way round it is, setting
config.frontend to mail if config.quiet >= 2 is pointless, since either
you've already exited or you're about to exit.)

Cheers,

-- 
Colin Watson                                       [EMAIL PROTECTED]
diff -Nru /tmp/Yj2GGJFeu4/apt-listchanges-2.59/apt-listchanges 
/tmp/I3wKEKwcjs/apt-listchanges-2.59/apt-listchanges
--- /tmp/Yj2GGJFeu4/apt-listchanges-2.59/apt-listchanges        2004-11-14 
01:34:08.000000000 +0000
+++ /tmp/I3wKEKwcjs/apt-listchanges-2.59/apt-listchanges        2005-12-03 
14:28:36.000000000 +0000
@@ -53,6 +53,9 @@
     if config.apt_mode:
         debs = apt_listchanges.read_apt_pipeline(config)
 
+    if config.quiet >= 2 or config.frontend == 'none':
+        sys.exit(0)
+
     # If apt is in quiet (loggable) mode, we should make our output
     # loggable too
     if config.quiet == 1:
@@ -60,9 +63,6 @@
     elif config.quiet >= 2:
         config.frontend = 'mail'
 
-    if config.quiet >= 2 or config.frontend == 'none':
-        sys.exit(0)
-
     if not config.show_all:
         status = DebianControlParser.DebianControlParser()
         status.readfile('/var/lib/dpkg/status')

Reply via email to