Bug#344553: [Logcheck-devel] Bug#344553: logcheck: Fails silently to read config file

2006-01-02 Thread Todd Troxell
On Sun, Jan 01, 2006 at 08:15:16PM +0200, Markus Peuhkuri wrote: Todd Troxell wrote: I see your point. The config is not really essential. What do you think about this: if [ -f $CONFFILE -a -r $CONFFILE]; then The problem is still that if CONFFILE is somehow mistyped, it still

Bug#344553: [Logcheck-devel] Bug#344553: logcheck: Fails silently to read config file

2006-01-02 Thread Maximilian Attems
On Mon, Jan 02, 2006 at 04:44:37AM -0500, Todd Troxell wrote: On Sun, Jan 01, 2006 at 08:15:16PM +0200, Markus Peuhkuri wrote: Todd Troxell wrote: I see your point. The config is not really essential. What do you think about this: if [ -f $CONFFILE -a -r $CONFFILE]; then

Bug#344553: [Logcheck-devel] Bug#344553: logcheck: Fails silently to read config file

2006-01-02 Thread Markus Peuhkuri
Maximilian Attems wrote: no the debian packaging takes care of that, no need to issue an error in that case. if you change the permissions of the CONFFILE you are on your own. In NO CASE should program functionality depend on some package management system. The program should be able to

Bug#344553: [Logcheck-devel] Bug#344553: logcheck: Fails silently to read config file

2006-01-02 Thread Maximilian Attems
On Mon, Jan 02, 2006 at 02:03:19PM +0200, Markus Peuhkuri wrote: Maximilian Attems wrote: no the debian packaging takes care of that, no need to issue an error in that case. if you change the permissions of the CONFFILE you are on your own. In NO CASE should program functionality

Bug#344553: [Logcheck-devel] Bug#344553: logcheck: Fails silently to read config file

2006-01-02 Thread Markus Peuhkuri
Maximilian Attems wrote: second you give _no_ argument why CONFFILE is so important. logcheck works fine without it. If config file is defined on command line argument, it should be read in and an error given if it not readable. If the config file exists, it should be read. third the

Bug#344553: [Logcheck-devel] Bug#344553: logcheck: Fails silently to read config file

2006-01-01 Thread Todd Troxell
On Sat, Dec 31, 2005 at 02:47:57PM +0100, Maximilian Attems wrote: On Sat, Dec 31, 2005 at 07:16:24AM -0500, Todd Troxell wrote: On Fri, Dec 23, 2005 at 08:21:53PM +0200, Markus Peuhkuri wrote: Package: logcheck Version: 1.2.42 Severity: minor Tags: patch Logcheck does not

Bug#344553: [Logcheck-devel] Bug#344553: logcheck: Fails silently to read config file

2006-01-01 Thread Markus Peuhkuri
Todd Troxell wrote: I see your point. The config is not really essential. What do you think about this: if [ -f $CONFFILE -a -r $CONFFILE]; then The problem is still that if CONFFILE is somehow mistyped, it still fails silently even if the fragment fixes the error I had with permissions.

Bug#344553: [Logcheck-devel] Bug#344553: logcheck: Fails silently to read config file

2005-12-31 Thread Todd Troxell
On Fri, Dec 23, 2005 at 08:21:53PM +0200, Markus Peuhkuri wrote: Package: logcheck Version: 1.2.42 Severity: minor Tags: patch Logcheck does not report any error if the config file is not readable or does not exists. This may easily happen, as logcheck is run as logcheck user and while

Bug#344553: [Logcheck-devel] Bug#344553: logcheck: Fails silently to read config file

2005-12-31 Thread Maximilian Attems
On Sat, Dec 31, 2005 at 07:16:24AM -0500, Todd Troxell wrote: On Fri, Dec 23, 2005 at 08:21:53PM +0200, Markus Peuhkuri wrote: Package: logcheck Version: 1.2.42 Severity: minor Tags: patch Logcheck does not report any error if the config file is not readable or does not exists.

Bug#344553: [Logcheck-devel] Bug#344553: logcheck: Fails silently to read config file

2005-12-31 Thread Markus Peuhkuri
Maximilian Attems wrote: if [ -r $CONFFILE ]; then i'm less then sure that this the right way to go, we shouldn't need the $CONFFILE? what was the error message you were seeing? The problem is that logcheck fails silently, if there is some problem with config file; either typo or some