Bug#348902: run-mozilla.sh should use mktemp -t to honour TMPDIR

2006-01-31 Thread Eric Dorland
* Ian Jackson ([EMAIL PROTECTED]) wrote:
 Eric Dorland writes (Re: Bug#348902: run-mozilla.sh should use mktemp -t to 
 honour TMPDIR):
  * Mike Hommey ([EMAIL PROTECTED]) wrote:
   Now, the real question is, why do we keep providing run-mozilla.sh in
   /usr/lib/firefox, since we don't use it...
  
  Agreed, I don't think it's useful to our users, and generally just
  causes more confusion. I'm removing it from the next release. 
 
 I'm sorry to cause this confusion !  I did check that it was shipped
 but not that it was actually used.

No apologies necessary. Helped us realize we don't need that file. 

-- 
Eric Dorland [EMAIL PROTECTED]
ICQ: #61138586, Jabber: [EMAIL PROTECTED]
1024D/16D970C6 097C 4861 9934 27A0 8E1C  2B0A 61E9 8ECF 16D9 70C6

-BEGIN GEEK CODE BLOCK-
Version: 3.12
GCS d- s++: a-- C+++ UL+++ P++ L++ E++ W++ N+ o K- w+ 
O? M++ V-- PS+ PE Y+ PGP++ t++ 5++ X+ R tv++ b+++ DI+ D+ 
G e h! r- y+ 
--END GEEK CODE BLOCK--


signature.asc
Description: Digital signature


Bug#348902: run-mozilla.sh should use mktemp -t to honour TMPDIR

2006-01-30 Thread Ian Jackson
Eric Dorland writes (Re: Bug#348902: run-mozilla.sh should use mktemp -t to 
honour TMPDIR):
 * Mike Hommey ([EMAIL PROTECTED]) wrote:
  Now, the real question is, why do we keep providing run-mozilla.sh in
  /usr/lib/firefox, since we don't use it...
 
 Agreed, I don't think it's useful to our users, and generally just
 causes more confusion. I'm removing it from the next release. 

I'm sorry to cause this confusion !  I did check that it was shipped
but not that it was actually used.

Ian.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#348902: run-mozilla.sh should use mktemp -t to honour TMPDIR

2006-01-29 Thread Eric Dorland
* Mike Hommey ([EMAIL PROTECTED]) wrote:
 On Thu, Jan 19, 2006 at 07:38:23PM +, Ian Jackson [EMAIL PROTECTED] 
 wrote:
  Package: firefox
  Version: 1.5.dfsg
  
  The patch below causes the /usr/bin/firefox script to honour TMPDIR
  when setting up for debugging.
  
  (This patch is part of the Ubuntu package firefox 1.5.dfsg-4ubuntu2
  and is one of several that I think should be included in Debian and/or
  upstream.  More mails like this one will follow ...)
 
 Actually, the /usr/bin/firefox script is the one in
 debian/firefox-runner, which already uses mktemp -t.
 
 Now, the real question is, why do we keep providing run-mozilla.sh in
 /usr/lib/firefox, since we don't use it...

Agreed, I don't think it's useful to our users, and generally just
causes more confusion. I'm removing it from the next release. 

-- 
Eric Dorland [EMAIL PROTECTED]
ICQ: #61138586, Jabber: [EMAIL PROTECTED]
1024D/16D970C6 097C 4861 9934 27A0 8E1C  2B0A 61E9 8ECF 16D9 70C6

-BEGIN GEEK CODE BLOCK-
Version: 3.12
GCS d- s++: a-- C+++ UL+++ P++ L++ E++ W++ N+ o K- w+ 
O? M++ V-- PS+ PE Y+ PGP++ t++ 5++ X+ R tv++ b+++ DI+ D+ 
G e h! r- y+ 
--END GEEK CODE BLOCK--


signature.asc
Description: Digital signature


Bug#348902: run-mozilla.sh should use mktemp -t to honour TMPDIR

2006-01-19 Thread Ian Jackson
Package: firefox
Version: 1.5.dfsg

The patch below causes the /usr/bin/firefox script to honour TMPDIR
when setting up for debugging.

(This patch is part of the Ubuntu package firefox 1.5.dfsg-4ubuntu2
and is one of several that I think should be included in Debian and/or
upstream.  More mails like this one will follow ...)

Regards,
Ian.

--- firefox-1.5.dfsg.orig/build/unix/run-mozilla.sh
+++ firefox-1.5.dfsg/build/unix/run-mozilla.sh
@@ -221,7 +221,7 @@
fi
 if [ -x $debugger ] 
 then
-   tmpfile=`mktemp /tmp/mozargs.XX` || { echo Cannot create temporary 
file 2; exit 1; }
+   tmpfile=`mktemp -t mozargs.XX` || { echo Cannot create temporary 
file 2; exit 1; }
trap  [ -f \$tmpfile\ ]  /bin/rm -f -- \$tmpfile\ 0 1 2 3 13 15
 echo set args ${1+$@}  $tmpfile
 # If you are not using ddd, gdb and know of a way to convey the arguments 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#348902: run-mozilla.sh should use mktemp -t to honour TMPDIR

2006-01-19 Thread Mike Hommey
On Thu, Jan 19, 2006 at 07:38:23PM +, Ian Jackson [EMAIL PROTECTED] wrote:
 Package: firefox
 Version: 1.5.dfsg
 
 The patch below causes the /usr/bin/firefox script to honour TMPDIR
 when setting up for debugging.
 
 (This patch is part of the Ubuntu package firefox 1.5.dfsg-4ubuntu2
 and is one of several that I think should be included in Debian and/or
 upstream.  More mails like this one will follow ...)

Actually, the /usr/bin/firefox script is the one in
debian/firefox-runner, which already uses mktemp -t.

Now, the real question is, why do we keep providing run-mozilla.sh in
/usr/lib/firefox, since we don't use it...

Mike


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]