Bug#350669: libpng12-dev: wrong type for tyepdefs

2006-02-03 Thread Goswin von Brederlow
Josselin Mouette [EMAIL PROTECTED] writes:

 Le mardi 31 janvier 2006 à 06:21 +0100, Goswin Brederlow a écrit :
 Package: libpng12-dev
 Version: 1.2.8rel-1
 Severity: wishlist
 
 Hi,
 
 /usr/include/pngconf.h defines among others:
 
 typedef unsigned long png_uint_32;
 
 Please consider using C99 by replacing those defines with
 
 #include stdint.h
 typedef uint32_t png_uint_32;
 
 or at least use an int for 32bit values as that is 32bit across
 basically all archs in use while long is 32bit or 64bit.
 
 MfG
  Goswin
 
 PS: this is wishlist as the comment says at least XX bits long but
 it also mentions using int on 64bit platforms.

 However, if this is changed, this will change the ABI on 64-bit
 platforms. You don't want a libpng ABI transition, do you?

Well, keep it around till something else causes a transition anyway.

The oversized types seem to make ogre fail among others. Arguably
their fault but I just found it odd to have a 32bit type with 64bit.

MfG
Goswin



Bug#350669: libpng12-dev: wrong type for tyepdefs

2006-01-30 Thread Goswin Brederlow
Package: libpng12-dev
Version: 1.2.8rel-1
Severity: wishlist

Hi,

/usr/include/pngconf.h defines among others:

typedef unsigned long png_uint_32;

Please consider using C99 by replacing those defines with

#include stdint.h
typedef uint32_t png_uint_32;

or at least use an int for 32bit values as that is 32bit across
basically all archs in use while long is 32bit or 64bit.

MfG
Goswin

PS: this is wishlist as the comment says at least XX bits long but
it also mentions using int on 64bit platforms.

-- System Information:
Debian Release: 3.1
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.8-frosties-2
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages libpng12-dev depends on:
ii  libpng12-0 1.2.8rel-1PNG library - runtime
ii  zlib1g-dev 1:1.2.2-4.sarge.2 compression library - development

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#350669: libpng12-dev: wrong type for tyepdefs

2006-01-30 Thread Josselin Mouette
Le mardi 31 janvier 2006 à 06:21 +0100, Goswin Brederlow a écrit :
 Package: libpng12-dev
 Version: 1.2.8rel-1
 Severity: wishlist
 
 Hi,
 
 /usr/include/pngconf.h defines among others:
 
 typedef unsigned long png_uint_32;
 
 Please consider using C99 by replacing those defines with
 
 #include stdint.h
 typedef uint32_t png_uint_32;
 
 or at least use an int for 32bit values as that is 32bit across
 basically all archs in use while long is 32bit or 64bit.
 
 MfG
   Goswin
 
 PS: this is wishlist as the comment says at least XX bits long but
 it also mentions using int on 64bit platforms.

However, if this is changed, this will change the ABI on 64-bit
platforms. You don't want a libpng ABI transition, do you?
-- 
 .''`.   Josselin Mouette/\./\
: :' :   [EMAIL PROTECTED]
`. `'[EMAIL PROTECTED]
  `-  Debian GNU/Linux -- The power of freedom


signature.asc
Description: Ceci est une partie de message	numériquement signée