Package: linux-2.6

----- Forwarded message from Benjamin Herrenschmidt <[EMAIL PROTECTED]> -----

Subject: [PATCH] powerpc: vdso 64bits gettimeofday bug
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
To: Andrew Morton <[EMAIL PROTECTED]>, Linus Torvalds <[EMAIL PROTECTED]>
Cc: Paul Mackerras <[EMAIL PROTECTED]>, Olaf Hering <[EMAIL PROTECTED]>,
        linuxppc-dev list <[EMAIL PROTECTED]>,
        linuxppc64-dev <[EMAIL PROTECTED]>,
        Greg KH <[EMAIL PROTECTED]>, David Woodhouse <[EMAIL PROTECTED]>,
        Sven Luther <[EMAIL PROTECTED]>
Date: Sun, 26 Feb 2006 08:09:00 +1100
Message-Id: <[EMAIL PROTECTED]>
X-Mailer: Evolution 2.5.91 

A bug in the assembly code of the vdso can cause gettimeofday() to hang
or to return incorrect results. The wrong register was used to test for
pending updates of the calibration variables and to create a dependency
for subsequent loads. This fixes it.

Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
---

Might be worth applying to the stable series too and/or distro kernels
2.6.15 and later

--- linux-work.orig/arch/powerpc/kernel/vdso64/gettimeofday.S   2006-02-26 
08:02:57.000000000 +1100
+++ linux-work/arch/powerpc/kernel/vdso64/gettimeofday.S        2006-02-26 
08:04:23.000000000 +1100
@@ -225,9 +225,9 @@
   .cfi_startproc
        /* check for update count & load values */
 1:     ld      r8,CFG_TB_UPDATE_COUNT(r3)
-       andi.   r0,r4,1                 /* pending update ? loop */
+       andi.   r0,r8,1                 /* pending update ? loop */
        bne-    1b
-       xor     r0,r4,r4                /* create dependency */
+       xor     r0,r8,r8                /* create dependency */
        add     r3,r3,r0
 
        /* Get TB & offset it */


---------------------------------------------------------------------------------------
Wanadoo vous informe que cet  e-mail a ete controle par l'anti-virus mail. 
Aucun virus connu a ce jour par nos services n'a ete detecte.




----- End forwarded message -----



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to