Bug#382334: bootsplash: progress bar patch still missing from initscripts
El Jueves, 31 de Agosto de 2006 13:53, Free Ekanayaka escribió: Anyway I've updated my unofficial package, and this time I've uploaded it to Debian. At the moment is in the NEW queue, but you can find it here as well: http://archive.64studio.com/pool/main/s/sysv-rc-bootsplash/ Hello, now the file /usr/share/initramfs-tools/scripts/functions doesn't need to be patched and it should assure that the new version of /sbin/splash.sh is installed, without this script the patch doesn't work. Greetings, -- Pablo Chinea [EMAIL PROTECTED] http://www.khertz.net/ Clave GPG Pública: http://www.khertz.net/files/khertz.asc pgpDOQykIsTZm.pgp Description: PGP signature
Bug#382334: bootsplash: progress bar patch still missing from initscripts
PC El Jueves, 31 de Agosto de 2006 13:53, Free Ekanayaka =?iso-8859-1?Q?escribi=F3=3A?= Anyway I've updated my unofficial package, and this time I've uploaded it to Debian. At the moment is in the NEW queue, but you can find it here as well: http://archive.64studio.com/pool/main/s/sysv-rc-bootsplash/ PC Hello, now the file /usr/share/initramfs-tools/scripts/functions doesn't PC need to be patched and it should assure that the new version PC of /sbin/splash.sh is installed, without this script the patch doesn't work. Ok, fine. I'll upload a new bootsplash package with updated /sbin/splash.sh as soonas sysv-rc-bootsplash is accepted by the ftp-master. Thanks again for your contribution! Ciao, Free
Bug#382334: bootsplash: progress bar patch still missing from initscripts
El Jueves, 31 de Agosto de 2006 03:11, David Broome escribió:
The progress bar during boot does not start until after the kernel part is
done (which makes sense since it is an init script) Once it comes on it
works very well.
Obviously, it cannot be solved from the init script. But I have been using
bootsplash since long time ago (from backported packages) and always it has
worked in that way.
During shutdown it hits the halfway mark then starts over.
Yes, I also realized it, but it is an usplash code issue, it happens to me
also with usplash. It calculates the progress with the K scripts, and start
again with S scripts. This is the price of reuse code, usplash bugs are
bootsplash bugs :-P.
There are another problem with bootsplash, the fbmngplay doesn't work (the
program that show the animations), I already sent the report about this bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=385443
I fixed a problem with the rc patch, bootsplash expects to receive the name
of the script that is running in every moment and I was sending to it the
full path. I had not realized this bug because it is needed for the
animations, and the animations doesn't works. I've attached the new version
of the patch.
--
Pablo Chinea
[EMAIL PROTECTED]
http://www.khertz.net/
*** rc.sysv-rc 2006-07-25 18:51:00.0 +0100
--- rc.bootsplash 2006-08-31 11:05:40.0 +0100
***
*** 12,17
--- 12,19
# Authors:
# Miquel van Smoorenburg [EMAIL PROTECTED]
# Bruce Perens [EMAIL PROTECTED]
+ # Edited for bootsplash by Pablo Chinea [EMAIL PROTECTED], 2006
+ #
PATH=/sbin:/bin:/usr/sbin:/usr/bin
export PATH
***
*** 39,51
# Set onlcr to avoid staircase effect.
stty onlcr 01
! # Decide if usplash progress bar should be activated or not. Override
! # in /etc/default/rcS if required.
! if type usplash_write /dev/null 21; then
! SPLASH=true
! else
! SPLASH=false
! fi
# Now find out what the current and what the previous runlevel are.
--- 41,56
# Set onlcr to avoid staircase effect.
stty onlcr 01
! # source the bootsplash config file
! test -f /etc/default/bootsplash . /etc/default/bootsplash
!
! #
! # Update bootsplash stuff. (progress bar, animations...)
! #
! rc_splash() {
! export progress
! test $SPLASH != no /sbin/splash.sh $1
! }
# Now find out what the current and what the previous runlevel are.
***
*** 72,77
--- 77,83
then
/sbin/unconfigured.sh
fi
+ rc_splash splash start # let bootsplash know we are ready
fi
. /etc/default/rcS
***
*** 82,92
#
startup_progress() {
$@
! if [ $SPLASH = true ] ; then
! step=$(($step + $step_change))
! progress=$(($step * $progress_size / $num_steps + $first_step))
! usplash_write PROGRESS $progress || true
! fi
}
#
--- 88,98
#
startup_progress() {
$@
! step=$(($step + $step_change))
! progress=$(($step * $progress_size / $num_steps + $first_step))
! if type usplash_write /dev/null 21; then
! usplash_write PROGRESS $progress || true
! fi
}
#
***
*** 192,197
--- 198,212
;;
esac
+ #
+ # let bootsplash know if we are shutting down
+ #
+ if [ $runlevel = 0 -o $runlevel = 6 ]
+ then
+rc_splash splash start
+rc_splash shutdown
+ fi
+
# Is there an rc directory for this new runlevel?
if [ -d /etc/rc$runlevel.d ]
then
***
*** 229,235
;;
esac
- if [ $SPLASH = true ] ; then
# Count the number of scripts we need to run (for usplash
# progress bar)
num_steps=0
--- 244,249
***
*** 242,248
num_steps=$(($num_steps + 1))
done
step=0
- fi
# First, run the KILL scripts.
if [ $previous != N ]
--- 256,261
***
*** 281,286
--- 294,300
SCRIPTS=$SCRIPTS $i
done
startup stop $SCRIPTS
+ rc_splash ${i#/etc/rc$runlevel.d/K[0-9][0-9]} stop # update bootsplash progress bar
done
fi
***
*** 320,325
--- 334,340
SCRIPTS=$SCRIPTS $i
done
startup $ACTION $SCRIPTS
+ rc_splash ${i#/etc/rc$runlevel.d/S[0-9][0-9]} $ACTION # update bootsplash progress bar
done
fi
***
*** 340,345
--- 355,362
fi
fi
+ rc_splash master # stop playing animations
+
trap - EXIT # Disable emergency handler
exit 0
pgpQOu3jaGKkG.pgp
Description: PGP signature
Bug#382334: bootsplash: progress bar patch still missing from initscripts
Hi all, sorry for the delay, but I was on vacation and just came back yesterday. |--== Pablo Chinea writes: PC El Jueves, 31 de Agosto de 2006 03:11, David Broome escribió: The progress bar during boot does not start until after the kernel part is done (which makes sense since it is an init script) Once it comes on it works very well. PC Obviously, it cannot be solved from the init script. But I have been using PC bootsplash since long time ago (from backported packages) and always it has PC worked in that way. During shutdown it hits the halfway mark then starts over. PC Yes, I also realized it, but it is an usplash code issue, it happens to me PC also with usplash. It calculates the progress with the K scripts, and start PC again with S scripts. This is the price of reuse code, usplash bugs are PC bootsplash bugs :-P. First of all many thanks to Pablo for his work. I've tested the patch and it works cleanly on my system too. However I confirm the misbehaviour of the progress bar during the shutdown sequence :/ Anyway I've updated my unofficial package, and this time I've uploaded it to Debian. At the moment is in the NEW queue, but you can find it here as well: http://archive.64studio.com/pool/main/s/sysv-rc-bootsplash/ PC There are another problem with bootsplash, the fbmngplay doesn't work (the PC program that show the animations), I already sent the report about this bug: PC http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=385443 PC I fixed a problem with the rc patch, bootsplash expects to receive the name PC of the script that is running in every moment and I was sending to it the PC full path. I had not realized this bug because it is needed for the PC animations, and the animations doesn't works. I've attached the new version PC of the patch. Ok, thanks again. Cheers, Free
Bug#382334: bootsplash: progress bar patch still missing from initscripts
El Miércoles, 30 de Agosto de 2006 06:10, David Broome escribió: ...but how would I use this?... ...How do I patch sysv-rc?... Well, I suppose that when the maintainer checks the code (and if he believes it suitable), he will pack it into a deb file that will patch the sysv-rc file automatically. Anyway, if you want to check it, you can patch the file with the command: # patch -b /etc/init.d/rc rc-bootsplash.patch The original file will be backuped in /etc/init.d/rc.orig, you can back to the original file replacing it with this file or using the command: # patch -R /etc/init.d/rc rc-bootsplash.patch Please, if you check it, tell us if it works fine to you or not. Greetings, -- Pablo Chinea [EMAIL PROTECTED] http://www.khertz.net/ pgpiF0vmDB6M0.pgp Description: PGP signature
Bug#382334: bootsplash: progress bar patch still missing from initscripts
I applied the patched and replaced the script. It works but two observations: The progress bar during boot does not start until after the kernel part is done (which makes sense since it is an init script) Once it comes on it works very well. During shutdown it hits the halfway mark then starts over. This is great though! If I can provide any info to help let me know. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#382334: bootsplash: progress bar patch still missing from initscripts
Hello, the idea of putting an alernative to the usplash scripts that sysv-rc
expects to find is not totally possible because bootsplash expects to receive
the script that is running in every moment (for start and stop animations)
and usplash don't, but at least is possible to use the progress percent
calculated for the uplash.
I adapted the sysv-rc and /sbin/splash.sh scripts for bootsplash trying to
reuse the code for usplash. I don't know if it is the better way to do it,
but it works good enought for me.
I've attached the adapted splash.sh script and the patch for the sysv-rc.
Greetings,
--
Pablo Chinea
[EMAIL PROTECTED]
http://www.khertz.net/
*** rc.sysv-rc 2006-07-25 18:51:00.0 +0100
--- rc.bootsplash 2006-08-28 09:01:38.0 +0100
***
*** 12,17
--- 12,19
# Authors:
# Miquel van Smoorenburg [EMAIL PROTECTED]
# Bruce Perens [EMAIL PROTECTED]
+ # Edited for bootsplash by Pablo Chinea [EMAIL PROTECTED], 2006
+ #
PATH=/sbin:/bin:/usr/sbin:/usr/bin
export PATH
***
*** 39,51
# Set onlcr to avoid staircase effect.
stty onlcr 01
! # Decide if usplash progress bar should be activated or not. Override
! # in /etc/default/rcS if required.
! if type usplash_write /dev/null 21; then
! SPLASH=true
! else
! SPLASH=false
! fi
# Now find out what the current and what the previous runlevel are.
--- 41,56
# Set onlcr to avoid staircase effect.
stty onlcr 01
! # source the bootsplash config file
! test -f /etc/default/bootsplash . /etc/default/bootsplash
!
! #
! # Update bootsplash stuff. (progress bar, animations...)
! #
! rc_splash() {
! export progress
! test $SPLASH != no /sbin/splash.sh $1
! }
# Now find out what the current and what the previous runlevel are.
***
*** 72,77
--- 77,83
then
/sbin/unconfigured.sh
fi
+ rc_splash splash start # let bootsplash know we are ready
fi
. /etc/default/rcS
***
*** 82,92
#
startup_progress() {
$@
! if [ $SPLASH = true ] ; then
! step=$(($step + $step_change))
! progress=$(($step * $progress_size / $num_steps + $first_step))
! usplash_write PROGRESS $progress || true
! fi
}
#
--- 88,98
#
startup_progress() {
$@
! step=$(($step + $step_change))
! progress=$(($step * $progress_size / $num_steps + $first_step))
! if type usplash_write /dev/null 21; then
! usplash_write PROGRESS $progress || true
! fi
}
#
***
*** 192,197
--- 198,212
;;
esac
+ #
+ # let bootsplash know if we are shutting down
+ #
+ if [ $runlevel = 0 -o $runlevel = 6 ]
+ then
+rc_splash splash start
+rc_splash shutdown
+ fi
+
# Is there an rc directory for this new runlevel?
if [ -d /etc/rc$runlevel.d ]
then
***
*** 229,235
;;
esac
- if [ $SPLASH = true ] ; then
# Count the number of scripts we need to run (for usplash
# progress bar)
num_steps=0
--- 244,249
***
*** 242,248
num_steps=$(($num_steps + 1))
done
step=0
- fi
# First, run the KILL scripts.
if [ $previous != N ]
--- 256,261
***
*** 281,286
--- 294,300
SCRIPTS=$SCRIPTS $i
done
startup stop $SCRIPTS
+ rc_splash $i stop # update bootsplash progress bar
done
fi
***
*** 320,325
--- 334,340
SCRIPTS=$SCRIPTS $i
done
startup $ACTION $SCRIPTS
+ rc_splash $i $ACTION # update bootsplash progress bar
done
fi
***
*** 340,345
--- 355,362
fi
fi
+ rc_splash master # stop playing animations
+
trap - EXIT # Disable emergency handler
exit 0
splash.sh
Description: application/shellscript
pgpaVAVl5EdHq.pgp
Description: PGP signature
Bug#382334: bootsplash: progress bar patch still missing from initscripts
This is a stupid question, but how would I use this? I guess I would replace the splash script in /sbin with yours. That part is simple enough. How do I patch sysv-rc? Thanks! On 8/29/06, Pablo Chinea [EMAIL PROTECTED] wrote: Hello, the idea of putting an alernative to the usplash scripts that sysv-rc expects to find is not totally possible because bootsplash expects to receive the script that is running in every moment (for start and stop animations) and usplash don't, but at least is possible to use the progress percent calculated for the uplash. I adapted the sysv-rc and /sbin/splash.sh scripts for bootsplash trying to reuse the code for usplash. I don't know if it is the better way to do it, but it works good enought for me. I've attached the adapted splash.sh script and the patch for the sysv-rc. Greetings, -- Pablo Chinea [EMAIL PROTECTED] http://www.khertz.net/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#382334: bootsplash: progress bar patch still missing from initscripts
|--== Martin-Éric Racine writes: MR On Fri, August 11, 2006 2:41, Free Ekanayaka said: |--== Martin-Éric Racine writes: MR On Fri, August 11, 2006 2:18, Free Ekanayaka said: |--== UTF writes: U Package: bootsplash U Severity: normal U The kernel patch and theme work very well, but the progress U bar doesn't move, due to missing support in iniscripts. I'm U wondering how are things progressing with the initscripts U maintainers to get necessary changes merged in? It would be U desirable for this to be fixed before Etch is released. Hi, this unofficial package provides the needed patches: http://apt.64studio.com/64studio/stable/pool/main/s/sysv-rc-bootsplash/ but at the moment I don't think the are suit for integration with the official sysv-rc package.. MR Once the /bin/sh is replaced with /bin/bash (function is a bashism), it MR still gives me this: MR nino:/root# dpkg -a --configure MR Setting up sysv-rc-bootsplash (1.0.1-1) ... MR Testing if patches apply cleanly... MR 4 out of 8 hunks FAILED -- saving rejects to file /etc/init.d/rc.rej MR Patches would not apply cleanly. MR dpkg: error processing sysv-rc-bootsplash (--configure): MR subprocess post-installation script returned error exit status 1 MR Errors were encountered while processing: MR sysv-rc-bootsplash MR That's probably because sysv-rc 2.86.ds1-15 is what we have in Etch, but MR the above package only works for 2.86.ds1-14.1. Thanks for the report. Yes, the package definitely needs to be polished. However I've not very time to do that at the moment.. :/ MR Looking at the patch, I can see why it fails to apply: MR You are trying to replace usplash functions! MR Unfortunately, Debian and Ubuntu both selected usplash as their default MR bootsplash package, so better try cooperating than fighting it. MR One suggestion from Petter Reinholdtsen (pere on IRC) is to put an MR alernative to the usplash scripts that sysv-rc expects to find, i.e. MR making bootsplash progress bar scripts emulate those from usplash. Then MR sysv-rc doesn't need to be patched anymore, because we emulate usplash MR scripts. Yes, that's a good proposal. As I said at the moment I've not time to implement it, but I'll try to fix this before Etch gets released. Of course if you wish helping you are welcome! Ciao, Free
Bug#382334: bootsplash: progress bar patch still missing from initscripts
On Fri, August 11, 2006 2:41, Free Ekanayaka said: |--== Martin-Éric Racine writes: MR On Fri, August 11, 2006 2:18, Free Ekanayaka said: |--== UTF writes: U Package: bootsplash U Severity: normal U The kernel patch and theme work very well, but the progress U bar doesn't move, due to missing support in iniscripts. I'm U wondering how are things progressing with the initscripts U maintainers to get necessary changes merged in? It would be U desirable for this to be fixed before Etch is released. Hi, this unofficial package provides the needed patches: http://apt.64studio.com/64studio/stable/pool/main/s/sysv-rc-bootsplash/ but at the moment I don't think the are suit for integration with the official sysv-rc package.. MR Once the /bin/sh is replaced with /bin/bash (function is a bashism), it MR still gives me this: MR nino:/root# dpkg -a --configure MR Setting up sysv-rc-bootsplash (1.0.1-1) ... MR Testing if patches apply cleanly... MR 4 out of 8 hunks FAILED -- saving rejects to file /etc/init.d/rc.rej MR Patches would not apply cleanly. MR dpkg: error processing sysv-rc-bootsplash (--configure): MR subprocess post-installation script returned error exit status 1 MR Errors were encountered while processing: MR sysv-rc-bootsplash MR That's probably because sysv-rc 2.86.ds1-15 is what we have in Etch, but MR the above package only works for 2.86.ds1-14.1. Thanks for the report. Yes, the package definitely needs to be polished. However I've not very time to do that at the moment.. :/ Looking at the patch, I can see why it fails to apply: You are trying to replace usplash functions! Unfortunately, Debian and Ubuntu both selected usplash as their default bootsplash package, so better try cooperating than fighting it. One suggestion from Petter Reinholdtsen (pere on IRC) is to put an alernative to the usplash scripts that sysv-rc expects to find, i.e. making bootsplash progress bar scripts emulate those from usplash. Then sysv-rc doesn't need to be patched anymore, because we emulate usplash scripts. -- Martin-Éric Racine http://q-funk.iki.fi
Bug#382334: bootsplash: progress bar patch still missing from initscripts
|--== David Broome writes: MR That's probably because sysv-rc 2.86.ds1-15 is what we have in Etch, but MR the above package only works for 2.86.ds1-14.1. DB I tried downgrading to that version but I got the exact same error as the DB other person DB Is there a work around for now? Hi, I've tried to adapt the patch to the new version, but it doesn't work cleanly. It should not be to difficult to fit it, but at the moment I don't have much time :/, so I'll think it will take a bit. Ciao, Free -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#382334: bootsplash: progress bar patch still missing from initscripts
MR That's probably because sysv-rc 2.86.ds1-15 is what we have in Etch, but MR the above package only works for 2.86.ds1-14.1. I tried downgrading to that version but I got the exact same error as the other person Is there a work around for now? -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#382334: bootsplash: progress bar patch still missing from initscripts
Package: bootsplash Severity: normal -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The kernel patch and theme work very well, but the progress bar doesn't move, due to missing support in iniscripts. I'm wondering how are things progressing with the initscripts maintainers to get necessary changes merged in? It would be desirable for this to be fixed before Etch is released. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFE2x/zeXr56x4Muc0RAhydAJ49L/ZO3wWYIWRE9DqV7fJFOF+0TACggEvn 4bdALaolO98hL4/Vtc/MP7w= =1v6q -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#382334: bootsplash: progress bar patch still missing from initscripts
|--== UTF writes: U Package: bootsplash U Severity: normal U The kernel patch and theme work very well, but the progress U bar doesn't move, due to missing support in iniscripts. I'm U wondering how are things progressing with the initscripts U maintainers to get necessary changes merged in? It would be U desirable for this to be fixed before Etch is released. Hi, this unofficial package provides the needed patches: http://apt.64studio.com/64studio/stable/pool/main/s/sysv-rc-bootsplash/ but at the moment I don't think the are suit for integration with the official sysv-rc package.. Ciao, Free -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#382334: bootsplash: progress bar patch still missing from initscripts
On Fri, August 11, 2006 2:18, Free Ekanayaka said: |--== UTF writes: U Package: bootsplash U Severity: normal U The kernel patch and theme work very well, but the progress U bar doesn't move, due to missing support in iniscripts. I'm U wondering how are things progressing with the initscripts U maintainers to get necessary changes merged in? It would be U desirable for this to be fixed before Etch is released. Hi, this unofficial package provides the needed patches: http://apt.64studio.com/64studio/stable/pool/main/s/sysv-rc-bootsplash/ but at the moment I don't think the are suit for integration with the official sysv-rc package.. /var/lib/dpkg/info/sysv-rc-bootsplash.postinst: 42: function: not found dpkg: error processing sysv-rc-bootsplash (--install): subprocess post-installation script returned error exit status 127 -- Martin-Éric Racine http://q-funk.iki.fi
Bug#382334: bootsplash: progress bar patch still missing from initscripts
|--== Martin-Éric Racine writes: MR On Fri, August 11, 2006 2:18, Free Ekanayaka said: |--== UTF writes: U Package: bootsplash U Severity: normal U The kernel patch and theme work very well, but the progress U bar doesn't move, due to missing support in iniscripts. I'm U wondering how are things progressing with the initscripts U maintainers to get necessary changes merged in? It would be U desirable for this to be fixed before Etch is released. Hi, this unofficial package provides the needed patches: http://apt.64studio.com/64studio/stable/pool/main/s/sysv-rc-bootsplash/ but at the moment I don't think the are suit for integration with the official sysv-rc package.. MR Once the /bin/sh is replaced with /bin/bash (function is a bashism), it MR still gives me this: MR nino:/root# dpkg -a --configure MR Setting up sysv-rc-bootsplash (1.0.1-1) ... MR Testing if patches apply cleanly... MR 4 out of 8 hunks FAILED -- saving rejects to file /etc/init.d/rc.rej MR Patches would not apply cleanly. MR dpkg: error processing sysv-rc-bootsplash (--configure): MR subprocess post-installation script returned error exit status 1 MR Errors were encountered while processing: MR sysv-rc-bootsplash MR That's probably because sysv-rc 2.86.ds1-15 is what we have in Etch, but MR the above package only works for 2.86.ds1-14.1. Thanks for the report. Yes, the package definitely needs to be polished. However I've not very time to do that at the moment.. :/ Ciao, Free
Bug#382334: bootsplash: progress bar patch still missing from initscripts
On Fri, August 11, 2006 2:18, Free Ekanayaka said: |--== UTF writes: U Package: bootsplash U Severity: normal U The kernel patch and theme work very well, but the progress U bar doesn't move, due to missing support in iniscripts. I'm U wondering how are things progressing with the initscripts U maintainers to get necessary changes merged in? It would be U desirable for this to be fixed before Etch is released. Hi, this unofficial package provides the needed patches: http://apt.64studio.com/64studio/stable/pool/main/s/sysv-rc-bootsplash/ but at the moment I don't think the are suit for integration with the official sysv-rc package.. Once the /bin/sh is replaced with /bin/bash (function is a bashism), it still gives me this: nino:/root# dpkg -a --configure Setting up sysv-rc-bootsplash (1.0.1-1) ... Testing if patches apply cleanly... 4 out of 8 hunks FAILED -- saving rejects to file /etc/init.d/rc.rej Patches would not apply cleanly. dpkg: error processing sysv-rc-bootsplash (--configure): subprocess post-installation script returned error exit status 1 Errors were encountered while processing: sysv-rc-bootsplash That's probably because sysv-rc 2.86.ds1-15 is what we have in Etch, but the above package only works for 2.86.ds1-14.1. -- Martin-Éric Racine http://q-funk.iki.fi
