Bug#395408: perdition won't accept: ssl_mode tls_listen,tls_listen_force

2007-11-02 Thread Simon Horman
On Fri, Nov 02, 2007 at 06:39:46AM +0100, Laurent Licour wrote:
 I think i have found the problem
 
 this is a (little) stack overflow in option.c.
 I think that this handle by recent versions of gcc with stack-protector
 option
 
 Here is the patch :
  
 --- perdition/options.c.ori 2007-11-02 05:42:00.0 +0100
 +++ perdition/options.c 2007-11-02 05:42:16.0 +0100
 @@ -894,7 +894,7 @@
char lower_case[40];
char strip_domain[40];
  #ifdef WITH_SSL_SUPPORT
 -  char ssl_mode[26];
 +  char ssl_mode[40];
char *ssl_mode_p = NULL;
  #endif /* WITH_SSL_SUPPORT */
 
 This is not optimal, but other parts of the code also use static buffers

Thanks. That seems sensible to me.



-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#395408: perdition won't accept: ssl_mode tls_listen,tls_listen_force

2007-11-01 Thread Laurent Licour
I think i have found the problem

this is a (little) stack overflow in option.c.
I think that this handle by recent versions of gcc with stack-protector
option

Here is the patch :
 
--- perdition/options.c.ori 2007-11-02 05:42:00.0 +0100
+++ perdition/options.c 2007-11-02 05:42:16.0 +0100
@@ -894,7 +894,7 @@
   char lower_case[40];
   char strip_domain[40];
 #ifdef WITH_SSL_SUPPORT
-  char ssl_mode[26];
+  char ssl_mode[40];
   char *ssl_mode_p = NULL;
 #endif /* WITH_SSL_SUPPORT */

This is not optimal, but other parts of the code also use static buffers

-- 
 
Laurent LICOUR

Mail : [EMAIL PROTECTED]
PGP KeyID 0xDA160AA2  
FingerPrint 0920 EC01 F265 C9EA 537E 7AEE 986F 58C6 DA16 0AA2




signature.asc
Description: OpenPGP digital signature


Bug#395408: perdition won't accept: ssl_mode tls_listen,tls_listen_force

2006-10-30 Thread Horms
On Thu, Oct 26, 2006 at 03:04:41PM -0400, Dykema, Erik wrote:
 Package: perdition
 Version: 1.17-7
 
 Perdition won't accept both ssl_mode flags tls_listen and tls_listen_force .  
 It will accept:
 ssl_mode tls_listen
 OR
 ssl_mode tls_listen_force
 or:
 ssl_mode tls_listen,garbage
 but not:
 ssl_mode tls_listen,tls_listen_force
 
 The program starts but hangs, it does not accept connections or advertise 
 it's 
 startup options in the logs.

Thanks, that certainly sounds like a bug.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#395408: perdition won't accept: ssl_mode tls_listen,tls_listen_force

2006-10-29 Thread Dykema, Erik

Package: perdition
Version: 1.17-7

Perdition won't accept both ssl_mode flags tls_listen and  
tls_listen_force .  It will accept:

ssl_mode tls_listen
OR
ssl_mode tls_listen_force
or:
ssl_mode tls_listen,garbage
but not:
ssl_mode tls_listen,tls_listen_force

The program starts but hangs, it does not accept connections or  
advertise it's startup options in the logs.


thanks,
Erik


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#395408: perdition won't accept: ssl_mode tls_listen,tls_listen_force

2006-10-26 Thread Dykema, Erik

Package: perdition
Version: 1.17-7

Perdition won't accept both ssl_mode flags tls_listen and  
tls_listen_force .  It will accept:

ssl_mode tls_listen
OR
ssl_mode tls_listen_force
or:
ssl_mode tls_listen,garbage
but not:
ssl_mode tls_listen,tls_listen_force

The program starts but hangs, it does not accept connections or  
advertise it's startup options in the logs.


thanks,
Erik


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]