Bug#402340: browser support not working on upgrading from eclise 3.1.2 to eclipse 3.2.1

2009-08-20 Thread Kiss Karoly 
Package: eclipse
Version: 3.4.1-1
Severity: normal


Looking at /usr/bin/eclipse line 132-135 shows:
-- SNIP -
MOZILLA_FIVE_HOME=${MOZILLA_FIVE_HOME%*/}
if false  [ -n $MOZILLA_FIVE_HOME -a -e 
$MOZILLA_FIVE_HOME/libgtkembedmoz.so ]; then
:
elif [ -e /usr/lib/mozilla/libgtkembedmoz.so ]; then
-- SNIP -

The problem is that having a conditional false  something always gives a 
false result.
The developer probably intended false || something.
That way simply exporting MOZILLA_FIVE_HOME in a shell before starting eclipse 
would enable
the user to specify the location of the libgtkembedmoz.so he would like to use.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.30-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages eclipse depends on:
ii  eclipse-jdt   3.4.1-1Java Development Tools plug-ins fo
ii  eclipse-pde   3.4.1-1Plug-in Development Environment to
ii  eclipse-source3.4.1-1Eclipse source code plug-ins
ii  libc6 2.9-24 GNU C Library: Shared libraries
ii  zenity2.26.0-1   Display graphical dialog boxes fro

Versions of packages eclipse recommends:
pn  eclipse-gcj   none (no description available)

eclipse suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#402340: browser support not working on upgrading from eclise 3.1.2 to eclipse 3.2.1

2009-08-20 Thread Niels Thykier 
Kiss Karoly wrote:
 Package: eclipse
 Version: 3.4.1-1
 Severity: normal
 
 
 Looking at /usr/bin/eclipse line 132-135 shows:
 -- SNIP -
 MOZILLA_FIVE_HOME=${MOZILLA_FIVE_HOME%*/}
 if false  [ -n $MOZILLA_FIVE_HOME -a -e 
 $MOZILLA_FIVE_HOME/libgtkembedmoz.so ]; then
 :
 elif [ -e /usr/lib/mozilla/libgtkembedmoz.so ]; then
 -- SNIP -
 
 The problem is that having a conditional false  something always gives a 
 false result.
 The developer probably intended false || something.
 That way simply exporting MOZILLA_FIVE_HOME in a shell before starting 
 eclipse would enable
 the user to specify the location of the libgtkembedmoz.so he would like to 
 use.
 

Hi

Thanks for notifying of this.

I think this was a quick way of lets disable this, that never got
enabled again (or cleaned up). Namely because false || something
always yields something, so there would no point in doing false ||
something.

Though, please note that due to way it is programmed, if you see this
warning, then setting MOZILLA_FIVE_HOME is actually considered (since it
is pre-appended to LD_LIBRARY_PATH regardless) - so setting it ought to
have an effect[1].

That being said I intend to remove that part, since it does not properly
handle nor detect the xulrunner libraries, which (I believe are detected
by the settings in /etc/gre.d/* - or at the very least remove the warning.

As far as I can tell, the internal browser works just fine on my machine
and I get that annoying warning.

~Niels

[1] at least assuming you do not have /etc/gre.d/*. Not sure how eclipse
handles having that and a mozilla lib in LD_LIBRARY_PATH.



signature.asc
Description: OpenPGP digital signature