On Wed, Mar 28, 2007 at 06:10:16AM +0000, Debian Bug Tracking System wrote: > * Add code to initscript to not attempt to start a second version if > already > running, and to not fail if imapproxy is no longer running (also #415954)
Actually, for start, using --pidfile & --oknodo on start-stop-daemon --start would be a cleaner way to do this than the extra bit of code I myself introduced -- --pidfile on start will do the right thing in start-stop-daemon if combined with --oknodo. For stop a similar thing holds, s-s-d will also do nothing if the process already died, I didn't actually test what happens if the pidfile doesn't exist though. Note that the original had some 'sleep 1; kill' bits, s-s-d also has support for that -- but that's only really useful if imapproxy ever actually fails to obey a regular TERM signal, of which I have no indication. Please, pretty please, don't just >/dev/null and || true so much in general, for most things you want to solve that way have a better way to deal with it. My mistake, something to fix post-etch (-10.1 is already unblocked despite of this). --Jeroen -- Jeroen van Wolffelaar [EMAIL PROTECTED] (also for Jabber & MSN; ICQ: 33944357) http://Jeroen.A-Eskwadraat.nl -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
