Bug#443405: Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-24 Thread Ola Lundqvist
Hi Julian On Sun, Sep 23, 2007 at 03:12:05PM +, Julian Mehnle wrote: Ola Lundqvist wrote: On Sun, Sep 23, 2007 at 11:49:36AM +, Julian Mehnle wrote: So I think debarchiver should check $! and $@ rather than the result of do() (unless ($t)), which really says nothing about whether

Bug#443405: Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-24 Thread Julian Mehnle
Ola Lundqvist wrote: `perldoc -f do` says: | If do cannot read the file, it returns undef and sets $! to the | error. If do can read the file but cannot compile it, it returns | undef and sets an error message in [EMAIL PROTECTED] If the file is | successfully compiled, do returns the

Bug#443405: Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-24 Thread Ola Lundqvist
Hi Julian On Mon, Sep 24, 2007 at 10:34:59AM +, Julian Mehnle wrote: Ola Lundqvist wrote: `perldoc -f do` says: | If do cannot read the file, it returns undef and sets $! to the | error. If do can read the file but cannot compile it, it returns | undef and sets an error message

Bug#443405: Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-23 Thread Ola Lundqvist
tags 443405 + unreproducible help thanks Hi Julian I have now tried to reproduce your problem, but failed. The current code that cause the warning looks like this: if (-e $etcconfigfile) { my $t = do $etcconfigfile; unless ($t) { pdebug(3, Loading config file

Bug#443405: Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-23 Thread Julian Mehnle
Ola Lundqvist wrote: I have now tried to reproduce your problem, but failed. The current code that cause the warning looks like this: if (-e $etcconfigfile) { my $t = do $etcconfigfile; unless ($t) { pdebug(3, Loading config file $etcconfigfile:\n\t$!\n\t$@); } } So I

Bug#443405: Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-23 Thread Ola Lundqvist
Hi On Sun, Sep 23, 2007 at 11:49:36AM +, Julian Mehnle wrote: Ola Lundqvist wrote: I have now tried to reproduce your problem, but failed. The current code that cause the warning looks like this: if (-e $etcconfigfile) { my $t = do $etcconfigfile; unless ($t) {

Bug#443405: Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-23 Thread Ola Lundqvist
Hi again Now I have checked the documentation and it says like this: If do cannot read the file, it returns undef and sets $! to the error. If do can read the file but cannot compile it, it returns undef and sets an error message in $@ . If the file is successfully compiled, do returns the

Bug#443405: Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-23 Thread Julian Mehnle
Ola Lundqvist wrote: On Sun, Sep 23, 2007 at 11:49:36AM +, Julian Mehnle wrote: So I think debarchiver should check $! and $@ rather than the result of do() (unless ($t)), which really says nothing about whether the file could be read and compiled successfully, UNLESS you require

Bug#443405: Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-22 Thread Ola Lundqvist
Hi Julian On Sat, Sep 22, 2007 at 01:27:11AM +, Julian Mehnle wrote: Ola Lundqvist wrote: I think you need to end the configuration file with 1; Why would that make a difference? The last statement is ... $gpgkey = '74E1D63F'; which returns a true value. So this is

Bug#443405: Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-21 Thread Ola Lundqvist
Hi Julian I think you need to end the configuration file with 1; Please try that and tell me if the warning disappear. The ^I part is the error output from perl. It should contain the error code and error string. I do not know why it is ^I in your case. Best regards, // Ola On Fri, Sep 21,

Bug#443405: Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-21 Thread Julian Mehnle
Ola Lundqvist wrote: I think you need to end the configuration file with 1; Why would that make a difference? The last statement is ... $gpgkey = '74E1D63F'; which returns a true value. So this is equivalent to a trailing 1;. Please try that and tell me if the warning disappear. As

Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-20 Thread Julian Mehnle
Package: debarchiver Version: 0.7.4 Followup-For: Bug #437508 debarchiver now _always_ warns in syslog: | debarchiver: Warning: Loading config file /etc/debarchiver.conf: | debarchiver: ^I | debarchiver: ^I even if there is no error condition! I think you changed one log level too many from 4

Bug#437508: debarchiver now _always_ warns: Loading config file /etc/debarchiver.conf:\n^I\n^I in syslog, even if no error condition

2007-09-20 Thread Ola Lundqvist
Package: debarchiver Version: 0.7.4 Severity: normal Hi Thanks for the information. I'm creating a new bug for this now. Please send me the output from debarchiver yournormaloptions --dl 5 and the /etc/debarchiver.conf file. Best regards, // Ola On Thu, Sep 20, 2007 at 07:45:40PM +,