Bug#480432: libkrb53: ret_flags check at g_accept_sec_context.c:248 looks wrong

2008-05-10 Thread Bryan Kadzban
Russ Allbery wrote: Bryan Kadzban [EMAIL PROTECTED] writes: The check (ret_flags GSS_C_DELEG_FLAG) looks extremely wrong. GSS_C_DELEG_FLAGS is a bitmask, and should not be logically compared against anything (since it will always be logical true). ret_flags is a pointer, and its value

Bug#480432: libkrb53: ret_flags check at g_accept_sec_context.c:248 looks wrong

2008-05-10 Thread Russ Allbery
Bryan Kadzban [EMAIL PROTECTED] writes: After some looking at the upstream bug database, this appears to be the same as their bug #5802: http://krbdev.mit.edu/rt/Ticket/Display.html?id=5802 and that page says the bug was fixed in 1.6.3. And indeed, the source for 1.6.3 (from upstream)

Bug#480432: libkrb53: ret_flags check at g_accept_sec_context.c:248 looks wrong

2008-05-09 Thread Bryan Kadzban
Package: libkrb53 Version: 1.6.dfsg.3~beta1-4 Severity: normal Tags: patch The check (ret_flags GSS_C_DELEG_FLAG) looks extremely wrong. GSS_C_DELEG_FLAGS is a bitmask, and should not be logically compared against anything (since it will always be logical true). ret_flags is a pointer, and its

Bug#480432: libkrb53: ret_flags check at g_accept_sec_context.c:248 looks wrong

2008-05-09 Thread Russ Allbery
Bryan Kadzban [EMAIL PROTECTED] writes: The check (ret_flags GSS_C_DELEG_FLAG) looks extremely wrong. GSS_C_DELEG_FLAGS is a bitmask, and should not be logically compared against anything (since it will always be logical true). ret_flags is a pointer, and its value should not be bitwise