Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-07-09 Thread Dustin Kirkland
Here is a patch that provides the status action functionality for nmbd, smbd, and winbindd. I developed this against Ubuntu and am submitting this for inclusion in Debian. Thanks to Steve for his copious feedback on IRC. Note that the hunk dealing with the debian/control file may need to be

Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-07-08 Thread Dustin Kirkland
Hi- I'm working on a generic status_of_proc() function to be provided by /lib/lsb/init-functions in the lsb-base package. This bug is: * http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=483285 This function also currently uses /bin/pidof, although eventually, I'd like at add some improved

Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-07-04 Thread Steve Langasek
On Thu, Jul 03, 2008 at 05:39:31PM +0200, Tim Stoop wrote: Op 2-jul-2008, om 5:54 heeft Steve Langasek het volgende geschreven: I think it would be better to first fix winbind to use a proper PID file, then use code similar to that in the smbd/nmbd case. I'll spend some time today to see if

Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-07-03 Thread Tim Stoop
Op 2-jul-2008, om 5:54 heeft Steve Langasek het volgende geschreven: I think it would be better to first fix winbind to use a proper PID file, then use code similar to that in the smbd/nmbd case. I'll spend some time today to see if I can fix that. I guess the -- make-pidfile option from

Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-07-02 Thread Tim Stoop
Op 2-jul-2008, om 5:54 heeft Steve Langasek het volgende geschreven: There's an example of this already in /etc/init.d/samba. Ah yes, in testing. Using that version of the init script now for my development (seems to work as expected for the version in Etch, too). Perhaps that check is

Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-07-01 Thread Tim Stoop
Op 30-jun-2008, om 23:14 heeft Steve Langasek het volgende geschreven: Here comes the criticism ;) I prefer the term constructive remarks ;-) So the right way to do this is to look at the PID files themselves first, check their contents, and verify that those processes are still running.

Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-07-01 Thread Steve Langasek
On Tue, Jul 01, 2008 at 10:34:09AM +0200, Tim Stoop wrote: Note that procps is required for this functionality to work, because of the use of ps. I don't know that a dependency is actually warranted, since this is optional functionality; anyway, procps is Priority: required, so it will

Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-06-30 Thread Tim Stoop
Op 28-jun-2008, om 15:25 heeft Christian Perrier het volgende geschreven: I think you're very welcome to propose a patch. We'll review it (indeed, Steve will criticize it and I'll just look..:-)) and, hopefully, integrate it. This is my addition to the initscript for samba: status)

Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-06-30 Thread Christian Perrier
This is my addition to the initscript for samba: I rewrote it to fit the indentation style we use. I have no deep advice here, except that: - the echo stuff add extra noise and are not handled by the LSB init functions. Not sure whether this is wanted. Actually, the important stuff are

Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-06-30 Thread Tim Stoop
Op 30-jun-2008, om 19:44 heeft Christian Perrier het volgende geschreven: - the echo stuff add extra noise and are not handled by the LSB init functions. Not sure whether this is wanted. Actually, the important stuff are return codes... I'd vote to remove these echo lines. Although I

Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-06-30 Thread Steve Langasek
On Mon, Jun 30, 2008 at 09:34:17AM +0200, Tim Stoop wrote: Op 28-jun-2008, om 15:25 heeft Christian Perrier het volgende geschreven: I think you're very welcome to propose a patch. We'll review it (indeed, Steve will criticize it and I'll just look..:-)) and, hopefully, integrate it. Here

Bug#488275: [Pkg-samba-maint] Bug#488275: samba and winbind: initscript miss 'status' option

2008-06-28 Thread Christian Perrier
Quoting Tim Stoop ([EMAIL PROTECTED]): I hope you'll see it from that point of view. If so, I created a 'status' function in my own samba init script. If you'd like, I can post it here. It's not very good (I'm using pidof...), but it seems to work and maybe can be a starting point for a