Bug#491480: [Pkg-xfce-devel] Bug#491480: I think i fixed the bug
On mer, 2008-08-06 at 03:20 +0200, Daniel Gibson wrote: Good new everyone, I found the bug (or at least the one that made the plugin crash for _me_). It's in panel-plugin/acpi.c in refresh_acpi(). The (broken) code is at line 475: case STATE: file = g_strdup_printf (%s/%s/state, ACPI_DIR_FAN, cf-devicename); cf-raw_value = strcmp(get_acpi_value(file), on)==0 ? 1.0 : 0.0; The problem is, that get_acpi_value() (in contrast to get_acpi_zone_value() for example) expects a _full_ path to the file. Ok I guess that's why I don't have crashes on this box: I don't have anything in /proc/acpi/fan so the STATE part is never entered. I'll try to build the plugin with the patch and report back, stay tuned. btw strac'ing the plugin I saw that it tries to open /proc/acpi/battery/battery/BAT0 which doesn't exist here (it's /proc/acpi/battery/BAT0). What do you have (if you have a battery)? Cheers, -- Yves-Alexis signature.asc Description: This is a digitally signed message part
Bug#491480: [Pkg-xfce-devel] Bug#491480: I think i fixed the bug
On Wed, Aug 6, 2008 at 7:59 AM, Yves-Alexis Perez [EMAIL PROTECTED] wrote: Ok I guess that's why I don't have crashes on this box: I don't have anything in /proc/acpi/fan so the STATE part is never entered. I'll try to build the plugin with the patch and report back, stay tuned. btw strac'ing the plugin I saw that it tries to open /proc/acpi/battery/battery/BAT0 which doesn't exist here (it's /proc/acpi/battery/BAT0). What do you have (if you have a battery)? Cheers, -- Yves-Alexis Hi, I do have a battery, but no /proc/acpi/battery/ dir - in kernel 2.4.25. as far as I remember from fixing the battery-plugin the battery-stuff has been deprecated in /proc/ and now is in /sys/class/power_supply/ However on a 2.4.24 kernel the battery-dir is /proc/acpi/battery/BAT1/ - I think it was just a mistake to add ACPI_DIR_BATTERY twice... The whole acpi-code of this seems to be rather untested.. but hopefully we've fixed the worst bugs now. Will you report them upstream? Cheers, - Daniel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#491480: [Pkg-xfce-devel] Bug#491480: I think i fixed the bug
On Wed, Aug 06, 2008 at 02:40:23PM +0200, Daniel Gibson wrote: On Wed, Aug 6, 2008 at 7:59 AM, Yves-Alexis Perez [EMAIL PROTECTED] wrote: Hi, I do have a battery, but no /proc/acpi/battery/ dir - in kernel 2.4.25. as far as I remember from fixing the battery-plugin the battery-stuff has been deprecated in /proc/ and now is in /sys/class/power_supply/ Yeah. The sensor code is not ready for the /proc disappearance. However on a 2.4.24 kernel the battery-dir is /proc/acpi/battery/BAT1/ - I think it was just a mistake to add ACPI_DIR_BATTERY twice... yes. The whole acpi-code of this seems to be rather untested.. but hopefully we've fixed the worst bugs now. Will you report them upstream? Yes, already done. As you may have noticed, I uploaded the package with the two patches. Upstream bugs are http://bugzilla.xfce.org/show_bug.cgi?id=4265 and http://bugzilla.xfce.org/show_bug.cgi?id=4266 Cheers, -- Yves-Alexis -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
