Hi again,
I've taken a better look at the code involved in this particular
"bug", and I'm a bit worried: if you look at the (X)HTML form, you'll
see that the "value=" member of each button doesn't have any space.
There thus shouldn't be any "+" inserted by IE, *unless* IE takes the
text contained in the button itself (the text between <button></
button> tags). If so, there's no fix for this bug, as this particular
text is localized (you can check by starting apache with environment
variable "LANG=fr" set).
If you could check whether my assumption is correct or not that would
be pretty helpful. If it is incorrect, I'll have to figure out why the
hell IE would insert "+"...
Thanks a lot
Thibaut
Le 17 août 08 à 18:17, Stephen J. Smith a écrit :
Buttons with spaces in the description weren't working with IE7. For
example, IE7 sends "Play+All" while Firefox sends "PlayAll" for the
"Play All" button.
I made the straightforward change of checking for both strings.
diff -puNr libapache-mod-musicindex-1.2.1.orig/src/http.c libapache-
mod-musicindex-1.2.1/src/http.c
--- libapache-mod-musicindex-1.2.1.orig/src/http.c 2007-04-28
12:50:52.000000000 -0400
+++ libapache-mod-musicindex-1.2.1/src/http.c 2008-08-17
09:30:39.000000000 -0400
@@ -241,7 +241,7 @@ void treat_post_args(request_rec *r, mu_
if (!conf->cache)
conf->options |= MI_QUICKPL;
}
- else if (!strcmp(p, "RecursiveSearch")) {
+ else if (!strcmp(p, "RecursiveSearch") || !strcmp(p, "Recursive
+Search")) {
conf->options |= MI_RECURSIVE;
conf->order[0] = SB_DIR;
conf->order[1] = SB_URI;
@@ -256,11 +256,11 @@ void treat_post_args(request_rec *r, mu_
conf->options &= ~MI_RECURSIVE;
if (conf->options & MI_ALLOWSTREAM) {
- if (!strcmp(p, "PlaySelected")) {
+ if (!strcmp(p, "PlaySelected") || !strcmp(p,
"Play+Selected")) {
conf->options |= MI_STREAMLST;
- } else if (!strcmp(p, "PlayAll")) {
+ } else if (!strcmp(p, "PlayAll") || !strcmp(p,
"Play+All")) {
conf->options |= MI_STREAMALL;
- } else if (!strcmp(p, "ShuffleAll")) {
+ } else if (!strcmp(p, "ShuffleAll") || !strcmp(p, "Shuffle
+All")) {
conf->options |= MI_STREAMALL;
conf->order[0] = SB_RANDOM;
conf->order[1] = SB_DEFAULT;
@@ -268,28 +268,28 @@ void treat_post_args(request_rec *r, mu_
}
if (conf->options & MI_ALLOWTARBALL) {
- if (!strcmp(p, "DownloadAll")) {
+ if (!strcmp(p, "DownloadAll") || !strcmp(p,
"Download+All")) {
conf->options |= MI_DWNLDALL;
- } else if (!strcmp(p, "DownloadSelected")) {
+ } else if (!strcmp(p, "DownloadSelected") || !strcmp(p, "Download
+Selected")) {
conf->options |= MI_DWNLDLST;
}
}
if ((conf->options & (MI_ALLOWSTREAM|MI_ALLOWTARBALL))) {
- if (!strcmp(p, "AddToPlaylist")) {
+ if (!strcmp(p, "AddToPlaylist") || !strcmp(p, "Add+To
+Playlist")) {
conf->options |= MI_COOKIEADDLST;
- } else if (!strcmp(p, "AddAllToPlaylist")) {
+ } else if (!strcmp(p, "AddAllToPlaylist") || !strcmp(p, "Add+All
+To+Playlist")) {
conf->options |= MI_COOKIEADDALL;
}
}
- if (!strcmp(p, "RemoveFromPlaylist")) {
+ if (!strcmp(p, "RemoveFromPlaylist") || !strcmp(p, "Remove+From
+Playlist")) {
conf->options |= MI_COOKIEDELLST;
- } else if (!strcmp(p, "ClearPlaylist")) {
+ } else if (!strcmp(p, "ClearPlaylist") || !strcmp(p, "Clear
+Playlist")) {
conf->options |= MI_COOKIEPURGE;
- } else if (!strcmp(p, "StreamPlaylist")) {
+ } else if (!strcmp(p, "StreamPlaylist") || !strcmp(p, "Stream
+Playlist")) {
conf->options |= MI_COOKIESTREAM;
- } else if (!strcmp(p, "DownloadPlaylist")) {
+ } else if (!strcmp(p, "DownloadPlaylist") || !strcmp(p, "Download
+Playlist")) {
conf->options |= MI_COOKIEDWNLD;
}
}
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
