Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-08-01 Thread Guido Günther
On Fri, Aug 01, 2008 at 02:22:09PM +0200, Marco d'Itri wrote: > On Aug 01, Guido Günther <[EMAIL PROTECTED]> wrote: > > > It turned out that the code for another usage of '-s' is there but it > > isn't in the options passed to getopt_long, so we can safely keep the > > compat code. Possible patch

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-08-01 Thread Teodor
On Fri, Aug 1, 2008 at 10:35 AM, Guido Günther <[EMAIL PROTECTED]> wrote: > In order to support the upgrade we need to: > udev: > * hack in enough support for -s so we can update udev without > updating multipath-tools - this can probably be done by just > implementing -s as -d and simply doing a

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-08-01 Thread Marco d'Itri
On Aug 01, Guido Günther <[EMAIL PROTECTED]> wrote: > It turned out that the code for another usage of '-s' is there but it > isn't in the options passed to getopt_long, so we can safely keep the > compat code. Possible patch attached. WTF? You cannot just remove the code, -s is not used but --sg-

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-08-01 Thread Guido Günther
On Fri, Aug 01, 2008 at 03:35:06AM -0400, Guido Günther wrote: > * hack in enough support for -s so we can update udev without > updating multipath-tools - this can probably be done by just > implementing -s as -d and simply doing a: s%^/block/%^/dev/% in > set_options if "-s" was set. I just

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-08-01 Thread Guido Günther
On Thu, Jul 31, 2008 at 06:11:01PM +0200, Marco d'Itri wrote: > On Jul 31, Teodor <[EMAIL PROTECTED]> wrote: > > > I think this can be fixed by depending on udev >= 0.125 and hitting > > both together in lenny. First you'll have to ask for a freeze > > exception since this seems to be RC. > This i

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-07-31 Thread Julien Cristau
On Thu, Jul 31, 2008 at 19:12:10 +0300, Teodor wrote: > On Thu, Jul 31, 2008 at 6:34 PM, Guido Günther <[EMAIL PROTECTED]> wrote: > > No it can't. This allows for a udev update without updating > > multipath-tools. This would have worked if scsi_id in the old versions > > would have supported -d p

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-07-31 Thread Marco d'Itri
On Jul 31, Teodor <[EMAIL PROTECTED]> wrote: > I think this can be fixed by depending on udev >= 0.125 and hitting > both together in lenny. First you'll have to ask for a freeze > exception since this seems to be RC. This is planned, and I expect that the freeze exception will be granted. But ple

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-07-31 Thread Teodor
On Thu, Jul 31, 2008 at 6:34 PM, Guido Günther <[EMAIL PROTECTED]> wrote: > No it can't. This allows for a udev update without updating > multipath-tools. This would have worked if scsi_id in the old versions > would have supported -d properly. I don't see why not. In fact it would not work with a

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-07-31 Thread Guido Günther
On Thu, Jul 31, 2008 at 06:20:44PM +0300, Teodor wrote: > On Thu, Jul 31, 2008 at 3:39 PM, Guido Günther <[EMAIL PROTECTED]> wrote: > > I've already sent a patch upstream for multipath-tools to switch to -d > > instead of -s. > > > > Unfortunately -d/--device doesn't work in e.g. udev 0.114 (curren

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-07-31 Thread Teodor
On Thu, Jul 31, 2008 at 3:39 PM, Guido Günther <[EMAIL PROTECTED]> wrote: > I've already sent a patch upstream for multipath-tools to switch to -d > instead of -s. > > Unfortunately -d/--device doesn't work in e.g. udev 0.114 (currently in > lenny): > Thank's to that we don't have an upgrade path:

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-07-31 Thread Guido Günther
On Thu, Jul 31, 2008 at 11:24:25AM +0200, Marco d'Itri wrote: > On Jul 31, Guido Günther <[EMAIL PROTECTED]> wrote: > > > It breaks software currently targeted for lenny - at least > I am not going to revert the change, so the possibile actions on my > part are: > - merge a lenny-only patch from y

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-07-31 Thread Marco d'Itri
On Jul 31, Guido Günther <[EMAIL PROTECTED]> wrote: > It breaks software currently targeted for lenny - at least I am not going to revert the change, so the possibile actions on my part are: - merge a lenny-only patch from you, who apparently are the only other maintainer affected - add a Confli

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-07-31 Thread Guido Günther
On Thu, Jul 31, 2008 at 10:42:30AM +0200, Marco d'Itri wrote: > On Jul 31, Guido Günther <[EMAIL PROTECTED]> wrote: > > > This breaks multipath-tools since it calls scsi_id internally. We could > > probably fix this up for lenny but it would nevertheless break user's > > udev rules. > Users will

Bug#493075: scsi_id changed commandline syntax (breaks multipath)

2008-07-31 Thread Guido Günther
Package: udev Version: 0.124-5 Severity: critical Hi, up to version 114 scsi_id accepted: ./scsi_id -u -g -s /block/sdg 1494554010e9b000e Whereas 124 doesn't: /lib/udev/scsi_id -u -g -s /block/sdg /lib/udev/scsi_id: invalid option -- s it needs: /lib/udev/scsi_