Bug#493322: [Aptitude-devel] Bug#493322: aptitude: pressing 'escape' in search/tree limit dialog should cancel

[Axel Beckert]

Hi Manuel,

Manuel A. Fernandez Montecelo wrote:
> > Just in case you're still in there with your mind: The very same
> > happens with pressing Ctrl-G while Ctrl-G (as well as Escape) closes
> > the according minibuffer-style search box.
> >
> > Maybe you can fix that for Ctrl-G as well. Being an Emacs user, I tend
> > to press Ctrl-G more often than Escape. :-) See also #607118. ;-)
> 
> I am not sure if I understand correctly.

You do:

> I think that what you ask is if this can also be implemented for
> 'Ctrl-G' as well as for 'Esc'.
> 
> In this case, the answer is that yes, it has been implemented for both,
> because I am using what cwidget considers as "Cancel" keys,

Ah, great! Thanks!

> which are these:
> 
>  cancelkey.push_back(KEY_CTRL(L'g'));
>  cancelkey.push_back(key(L'\e', true));
>  cancelkey.push_back(KEY_CTRL(L'['));

Yeah, I remember that code from looking for the cause for #607118. :-)

> (If you can confirm that it works for both before the next release, it
> would be great).

Will try to do so.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Bug#493322: [Aptitude-devel] Bug#493322: aptitude: pressing 'escape' in search/tree limit dialog should cancel

[Manuel A. Fernandez Montecelo]

2015-09-07 22:08 Axel Beckert:

Hi Manuel,

Manuel A. Fernandez Montecelo wrote:

> Pressing 'escape' in the dialog puts a ^[ into the search term, instead
> of just closing/canceling the search/limit.

I just implemented this, it will be present in the next release.


Thanks!

Just in case you're still in there with your mind: The very same
happens with pressing Ctrl-G while Ctrl-G (as well as Escape) closes
the according minibuffer-style search box.

Maybe you can fix that for Ctrl-G as well. Being an Emacs user, I tend
to press Ctrl-G more often than Escape. :-) See also #607118. ;-)


I am not sure if I understand correctly.  I think that what you ask is
if this can also be implemented for 'Ctrl-G' as well as for 'Esc'.

In this case, the answer is that yes, it has been implemented for both,
because I am using what cwidget considers as "Cancel" keys, which are
these:

 cancelkey.push_back(KEY_CTRL(L'g'));
 cancelkey.push_back(key(L'\e', true));
 cancelkey.push_back(KEY_CTRL(L'['));
		  
The first is Control-g, the other two are two variants of Escape, I

think.

(If you can confirm that it works for both before the next release, it
would be great).


Cheers.
--
Manuel A. Fernandez Montecelo 

Bug#493322: [Aptitude-devel] Bug#493322: aptitude: pressing 'escape' in search/tree limit dialog should cancel

[Axel Beckert]

Hi Manuel,

Manuel A. Fernandez Montecelo wrote:
> > Pressing 'escape' in the dialog puts a ^[ into the search term, instead
> > of just closing/canceling the search/limit.
> 
> I just implemented this, it will be present in the next release.

Thanks!

Just in case you're still in there with your mind: The very same
happens with pressing Ctrl-G while Ctrl-G (as well as Escape) closes
the according minibuffer-style search box.

Maybe you can fix that for Ctrl-G as well. Being an Emacs user, I tend
to press Ctrl-G more often than Escape. :-) See also #607118. ;-)

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE