Hi Chris,

Sorry to be a pain but I'm still not entirely sure this is all fixed
now.

It fixes the case I saw in /etc/init.d/networking but log_failure_msg
still returns a failure code.

Is that by design?  It didn't use to be the case in -15.

If I extend the lsb-test.sh to add:
log_success_msg "Success"
log_failure_msg "Failure"

then I get:
[EMAIL PROTECTED] ~/lsb]$ ./lsb-test.sh lsb-3.2-18
Importing lsb-3.2-18/init-functions
Only a warning (warning).
Success.
Failure failed!
[EMAIL PROTECTED] ~/lsb]$ ./lsb-test.sh lsb-3.2-15
Importing lsb-3.2-15/init-functions
Only a warning
Success
Failure
OK!
[EMAIL PROTECTED] ~/lsb]$

I think you probably want all three of them to return 0 no matter what
was passed unless there was an error producing the message somehow (is
that possible?).  That way they'll be safe in any script with set -e.

You might want to publicise to a wider audience your changelog about not
using these functions though if they aren't meant to be used.

I hadn't noticed that -17 was ok if the terminal was colour (I was
testing under screen so something must have confused it into thinking it
wasn't colour capable).

Simon.

-- 
Just another wannabie |  "Did someone say they wanted  |  Just another fool
----------------------+   toast?" -- Talkie Toaster    +-------------------
This message was brought to you by the letter L and the number  3.
htag.pl 0.0.24 -- http://www.earth.li/projectpurple/progs/htag.html

Attachment: signature.asc
Description: Digital signature

Reply via email to