Bug#500703: urxvtcd: increments $SHLVL for daemon process

2008-10-06 Thread martin f krafft
also sprach Decklin Foster <[EMAIL PROTECTED]> [2008.10.02.2015 +0200]: > I realize I should have pointed out (to you) that urxvtc does send > its environment to the new terminal that urxvtd creates. That may > or may not be useful. (OK not really, what we would like here is > for urxvtcd to Just W

Bug#500703: urxvtcd: increments $SHLVL for daemon process

2008-10-02 Thread Decklin Foster
martin f krafft writes: > Anyway, I am not sure at this moment whether my patch is actually > the right thing to do, so give me a few days to make sure it is > actually doing the right thing. I am now starting to think that > a terminal emulator should always start shells with SHLVL=0... Well, up

Bug#500703: urxvtcd: increments $SHLVL for daemon process

2008-10-01 Thread Decklin Foster
martin f krafft writes: > Anyway, I am not sure at this moment whether my patch is actually > the right thing to do, so give me a few days to make sure it is > actually doing the right thing. I am now starting to think that > a terminal emulator should always start shells with SHLVL=0... I think

Bug#500703: urxvtcd: increments $SHLVL for daemon process

2008-10-01 Thread martin f krafft
also sprach Decklin Foster <[EMAIL PROTECTED]> [2008.10.01.1454 +0200]: > I think that might be a good idea. Not sure how upstream would > feel, but I could check. I'd appreciate that. -- .''`. martin f. krafft <[EMAIL PROTECTED]> : :' : proud Debian developer, author, administrator, and us

Bug#500703: urxvtcd: increments $SHLVL for daemon process

2008-10-01 Thread martin f krafft
> case $- in > *i*) ishlvl=$(($ishlvl+1));; > esac Except zsh doesn't allow you to do fancy stuff with $ishlvl that you can do with $SHLVL, simply because the former is non-standard. Anyway, I am not sure at this moment whether my patch is actually the right thing to do, so give m

Bug#500703: urxvtcd: increments $SHLVL for daemon process

2008-09-30 Thread Decklin Foster
martin f krafft writes: > > Well, only if /bin/sh is bash. > > No, also with dash and zsh. And for the cases where $SHLVL is not > set, my patch will just no-op. I tested dash here and it didn't (the man page also makes no mention of SHLVL either). Are you sure? As for zsh, I suppose I should ha

Bug#500703: urxvtcd: increments $SHLVL for daemon process

2008-09-30 Thread martin f krafft
also sprach Decklin Foster <[EMAIL PROTECTED]> [2008.09.30.2044 +0200]: > > Since /usr/bin/urxvtcd is a shell script, it will increase $SHLVL > > for urxvtd's environment > > Well, only if /bin/sh is bash. No, also with dash and zsh. And for the cases where $SHLVL is not set, my patch will just n

Bug#500703: urxvtcd: increments $SHLVL for daemon process

2008-09-30 Thread Decklin Foster
martin f krafft writes: > Since /usr/bin/urxvtcd is a shell script, it will increase $SHLVL > for urxvtd's environment Well, only if /bin/sh is bash. What is the problem caused by increasing $SHLVL? What is $SHLVL good for? (I don't use bash.) According to the documentation, it is incremented by

Bug#500703: urxvtcd: increments $SHLVL for daemon process

2008-09-30 Thread martin f krafft
Package: rxvt-unicode-ml Version: 9.05-2 Severity: minor File: /usr/bin/urxvtcd Tags: patch Since /usr/bin/urxvtcd is a shell script, it will increase $SHLVL for urxvtd's environment, which makes no sense. The following patch reverses this increment: --- /tmp/urxvtcd2008-09-30 17:52:27.00