Bug#506219: please use java-wrappers for the jabref wrapper script
Hello ! gregor herrmann wrote: I'd be happy to write the script and adapt the manual page accordingly, of course. That would be nice, thanks! There you go, in the attached diff. Thanks a lot! You're welcome ! Patch applied, tested, slightly changed (sunmin5 instead of sun) and (soon) shipped :) I saw that ;-) ... (One question re java-wrappers: shouldn't openjdk6 also be in all_runtimes, java2_runtimes, full_swing_runtimes?) Most probably... The internal code has changed quite a lot since the current testing/unstable version (you can check out the experimental one if you like). I'll make sure things are right when the current experimental version hits unstable. Cheers, Vincent -- Vincent Fourmond, Debian Developer http://vince-debian.blogspot.com/ If you put a large switch in some cave somewhere, with a sign on it saying End-of-the-World switch. PLEASE DO NOT TOUCH, the paint wouldn't even have the time to dry. -- Terry Pratchet, Thief of Time Vincent, listening to Travelling Riverside Blues (Led Zeppelin) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#506219: please use java-wrappers for the jabref wrapper script
On Thu, 20 Nov 2008 23:36:26 +0100, Vincent Fourmond wrote:
I'd be happy to write the script and adapt the manual page accordingly,
of course.
That would be nice, thanks!
There you go, in the attached diff.
Thanks a lot!
Patch applied, tested, slightly changed (sunmin5 instead of sun)
and (soon) shipped :)
(One question re java-wrappers: shouldn't openjdk6 also be in
all_runtimes, java2_runtimes, full_swing_runtimes?)
Cheers,
gregor
--
.''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4
: :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/
`. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
`-NP: Townes Van Zandt: Tecumseh Valley
signature.asc
Description: Digital signature
Bug#506219: please use java-wrappers for the jabref wrapper script
Hello,
gregor herrmann wrote:
On Wed, 19 Nov 2008 14:59:26 +0100, Vincent Fourmond wrote:
Would you be interested to use java-wrappers for the jabref wrapper
script ? It is an attempt to unify wrapper scripts, providing easier
writing for developers and also much more functionality for users (including
potential functionalities that won't exists at the time you choose to use it
!).
Sure, I think that's a good idea in general.
(Just that the last time I looked, java-wrappers and me didn't become
friends for a reason I can't remember.)
I'd be happy to write the script and adapt the manual page accordingly,
of course.
That would be nice, thanks!
There you go, in the attached diff.
Cheers,
Vincent
--
Vincent Fourmond, Debian Developer
http://vince-debian.blogspot.com/
find(1):
A `%' at the end of the format argument causes undefined behaviour
since there is no following character. In some locales, it may
hide your door keys, while in others it may remove the final page
from the novel you are reading.
Vincent, listening to The Importance Of Being Idle (Oasis)
diff -u jabref-2.3.1/debian/control jabref-2.3.1/debian/control
--- jabref-2.3.1/debian/control
+++ jabref-2.3.1/debian/control
@@ -17,7 +17,7 @@
Depends: openjdk-6-jre | sun-java6-jre | sun-java5-jre, antlr, antlr3,
libjgoodies-looks-java, libjgoodies-forms-java, libspin-java,
libglazedlists-java, libmicroba-java, libpdfbox-java,
- libjempbox-java (= 0.2.0)
+ libjempbox-java (= 0.2.0), java-wrappers (= 0.1.6)
Suggests: gv | postscript-viewer, xpdf | pdf-viewer
Description: graphical frontend to manage BibTeX databases
JabRef is a GUI to manage BibTeX databases, the standard LaTeX bibliography
diff -u jabref-2.3.1/debian/jabref-wrapper jabref-2.3.1/debian/jabref-wrapper
--- jabref-2.3.1/debian/jabref-wrapper
+++ jabref-2.3.1/debian/jabref-wrapper
@@ -3,13 +3,10 @@
-# jabref wrapper script
-# code for java detection borrowed from tuxguitar
+# Include the wrappers utility script
+. /usr/lib/java-wrappers/java-wrappers.sh
-if [ -z $JAVA_HOME ] ; then
- t=/usr/lib/jvm/java-1.5.0-sun test -d $t JAVA_HOME=$t
- t=/usr/lib/jvm/java-6-sun test -d $t JAVA_HOME=$t
- t=/usr/lib/jvm/java-6-openjdk test -d $t JAVA_HOME=$t
- test -n $JAVA_HOME JAVA=${JAVA_HOME}/jre/bin/java
-fi
+# We need sun runtime.
+find_java_runtime openjdk || find_java_runtime sun
-export JAVA=${JAVA:=java}
+find_jars jabref antlr antlr3 looks forms spin glazedlists
+find_jars microba pdfbox jempbox
-exec $JAVA -cp
/usr/share/java/jabref.jar:/usr/share/java/antlr.jar:/usr/share/java/antlr3.jar:/usr/share/java/looks.jar:/usr/share/java/forms.jar:/usr/share/java/spin.jar:/usr/share/java/glazedlists.jar:/usr/share/java/microba.jar:/usr/share/java/pdfbox.jar:/usr/share/java/jempbox.jar
net.sf.jabref.JabRefMain $@
+run_java net.sf.jabref.JabRefMain $@
diff -u jabref-2.3.1/debian/jabref.1 jabref-2.3.1/debian/jabref.1
--- jabref-2.3.1/debian/jabref.1
+++ jabref-2.3.1/debian/jabref.1
@@ -65,10 +65,25 @@
.TP
\fB\-s\fR, \fB\-\-nosplash\fR=BOOLEAN
Do not show splash window at startup
+
+.SH JAVA-WRAPPERS NOTE
+
+This program is a shell script wrapper based on
+.BR java-wrappers (7).
+You therefore benefit from several features; please see the
+.BR java-wrappers (7)
+manual page for more information about them.
+
+
+
.SH SEE ALSO
the included help
.br
http://jabref.sourceforge.net/
+
+.BR java-wrappers (7)
+
+
.SH AUTHOR
jabref was written by Morten O. Alver and Nizar Batada.
.PP
Bug#506219: please use java-wrappers for the jabref wrapper script
Package: jabref Version: 2.3.1-5 Severity: wishlist Hello, Would you be interested to use java-wrappers for the jabref wrapper script ? It is an attempt to unify wrapper scripts, providing easier writing for developers and also much more functionality for users (including potential functionalities that won't exists at the time you choose to use it !). For instance the wrapper script from statsvn looks this way: #!/bin/sh # Include the wrappers utility script . /usr/lib/java-wrappers/java-wrappers.sh # We first look for sun's runtime, and then for all the rest find_java_runtime sun || find_java_runtime find_jars jfreechart jcommon statcvs backport-util-concurrent statsvn run_java net.sf.statsvn.Main $@ I'd be happy to write the script and adapt the manual page accordingly, of course. Cheers, Vincent -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages jabref depends on: ii antlr 2.7.7-9 language tool for constructing rec ii antlr3 3.0.1+dfsg-4 language tool for constructing rec ii libglazedlists-java 1.7.0.dfsg-3 java list transformation library ii libjempbox-java 0.2.0.dfsg-1 XMP Compatible Java Library ii libjgoodies-forms-java 1.2.0-1 Framework to lay out and implement ii libjgoodies-looks-java 2.2.1-1 library with Swing lookfeel imple ii libmicroba-java 1:0.4.4.3-2 set of JFC (Swing) components ii libpdfbox-java 0.7.3.dfsg-2 PDF library for Java ii libspin-java1.5-1transparent threading solution for ii sun-java6-jre 6-10-2 Sun Java(TM) Runtime Environment ( jabref recommends no packages. Versions of packages jabref suggests: ii acroread [pdf-viewer]8.1.3-0.0 Adobe Acrobat Reader: Portable Doc ii ghostscript [postscript- 8.62.dfsg.1-3.1 The GPL Ghostscript PostScript/PDF ii gv [postscript-viewer] 1:3.6.5-2 PostScript and PDF viewer for X ii xpdf 3.02-1.4Portable Document Format (PDF) sui ii xpdf-reader [pdf-viewer] 3.02-1.4Portable Document Format (PDF) sui ii xpdf-utils [pdf-viewer] 3.02-1.4Portable Document Format (PDF) sui -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#506219: please use java-wrappers for the jabref wrapper script
On Wed, 19 Nov 2008 14:59:26 +0100, Vincent Fourmond wrote:
Would you be interested to use java-wrappers for the jabref wrapper
script ? It is an attempt to unify wrapper scripts, providing easier
writing for developers and also much more functionality for users (including
potential functionalities that won't exists at the time you choose to use it
!).
Sure, I think that's a good idea in general.
(Just that the last time I looked, java-wrappers and me didn't become
friends for a reason I can't remember.)
I'd be happy to write the script and adapt the manual page accordingly,
of course.
That would be nice, thanks!
Please note that TTBOMK jabref works only with sun-java5, sun-java6
and openjdk. I hope that can be expressed with the find-java*
commands in java-wrappers.
Cheers,
gregor
--
.''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4
: :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/
`. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
`-NP: U2: Staring At The Sun (New Mix)
signature.asc
Description: Digital signature
Bug#506219: please use java-wrappers for the jabref wrapper script
Hello, On Wed, Nov 19, 2008 at 4:33 PM, gregor herrmann [EMAIL PROTECTED] wrote: On Wed, 19 Nov 2008 14:59:26 +0100, Vincent Fourmond wrote: Would you be interested to use java-wrappers for the jabref wrapper script ? It is an attempt to unify wrapper scripts, providing easier writing for developers and also much more functionality for users (including potential functionalities that won't exists at the time you choose to use it !). Sure, I think that's a good idea in general. Great ! (Just that the last time I looked, java-wrappers and me didn't become friends for a reason I can't remember.) I'm open to all suggestions ;-)... I'd be happy to write the script and adapt the manual page accordingly, of course. That would be nice, thanks! Some time tomorrow evening (European time). Please note that TTBOMK jabref works only with sun-java5, sun-java6 and openjdk. I hope that can be expressed with the find-java* commands in java-wrappers. For java-wrappers in unstable, there is a small bug and you need to use something like find_runtime openjdk | find_runtime sun For the one in experimental: find_runtime openjdk sun (and that includes cacao-oj6, which seemed faster than openjdk last time I checked). Cheers, Vincent -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
