hey joe,
On Fri, Jul 17, 2009 at 09:27:53AM +0100, Joe Orton wrote:
* i'm not sure but it seems like there might be a few corresponding free()'s
missing from the mallocs/strdups.
Yeah, everything here is malloc'ed but never free'd. We could set it up
to be free'd in the date
Hi Sean, sorry I didn't see your comments earlier.
On Wed, Jul 15, 2009 at 01:14:46AM +0200, sean finney wrote:
in your comments you say:
/* Parse an ISO-6709 date as used in zone.tab. Returns end of the
s/date/coordinate/ ? :)
Hah! I've fixed this in patch v7.
but more seriously:
v6 attached, which now passes all the tests in the ext/date testsuite
and fixes some significant bugs in v5 and earlier.
Regards, Joe
Add support for use of the system timezone database, rather
than embedding a copy. Discussed upstream but was not desired.
History:
r6: fix fd leak in r5, fix
Hi folks, I've attached v5 of the system timezone patch, which is
updated for 5.3.0.
This contains the changes to parse zone.tab which I proposed in my
previous mail, and should fix the crash reported in the Debian bug
535770. It seems to work fine though I have not tested it exhaustively.
hey joe,
great, thanks for this. i'll give it some review and take it for a spin
and report back in a bit :)
sean
signature.asc
Description: Digital signature
hi joe,
some quick notes/observations...
in your comments you say:
/* Parse an ISO-6709 date as used in zone.tab. Returns end of the
s/date/coordinate/ ? :)
but more seriously:
* in create_zone_index() it looks like
find_zone_info(system_zone_info...) is called but system_zone_info
Hi Sean - adding the Fedora PHP devel list to CC. Thanks for getting in
touch. For Fedora folks, Sean has referenced this Debian bug report:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=535770
Quoting in full:
On Tue, Jul 07, 2009 at 12:05:31AM +0200, sean finney wrote:
...and hi again
...and hi again :)
On Mon, Jul 06, 2009 at 10:51:40PM +0200, sean finney wrote:
specifically timezone_identifiers_list() was extended to include country
codes as a filter for the returned values and it doesn't look like this
is covered by the patch and results in a segfault.
looking a bit
8 matches
Mail list logo
