On Sun, Jul 19, 2009 at 08:41:53PM -0300, Otavio Salvador wrote:
Also, I think for low-volume projects such as debootstrap, it is faster to
just fix up the whitespaces while commiting and tell the contributor
to take a close look at whitespace issues before sending the next patch.
Well I
On Mon, Jul 20, 2009 at 09:59:35PM +0300, Riku Voipio wrote:
Hrmh. In fact this shows that that codepath is actually not
needed then :) Thanks for spotting it. We still need the /proc
path since we can't mount in scratchbox. updated patch attached.
in this mail..
diff -urN
On Sat, Jul 18, 2009 at 06:32:54PM -0300, Otavio Salvador wrote:
On Wed, Jul 15, 2009 at 5:54 PM, Riku Voipioriku.voi...@iki.fi wrote:
Argh, please forget the previous patch. That one was certainly not the
one I wanted to send. The patch attached to this mail has the advantage
of actually
Hello Riku,
On Sun, Jul 19, 2009 at 5:00 PM, Riku Voipioriku.voi...@iki.fi wrote:
Manpage updated. I didn't touch the whitespace issues because I already
try match what is in the files it patch - tabs for debootstrap and functions,
mixed for scripts/sid.
[...]
Is, it doesn't mean we ought to
Hello Riku,
On Mon, Jul 13, 2009 at 4:13 PM, Riku Voipioriku.voi...@iki.fi wrote:
Package: debootstrap
Version: 1.0.13
Severity: wishlist
Tags: patch
Two changes needed for supporting scratchbox2:
The patch looks OK but:
- it has coding style issues (mixed tabs and spaces)
- it lacks
Hello,
On Wed, Jul 15, 2009 at 5:54 PM, Riku Voipioriku.voi...@iki.fi wrote:
Argh, please forget the previous patch. That one was certainly not the
one I wanted to send. The patch attached to this mail has the advantage
of actually working.
Previous comments still fits. It has coding style
Argh, please forget the previous patch. That one was certainly not the
one I wanted to send. The patch attached to this mail has the advantage
of actually working.
Riku
diff -urN debootstrap-1.0.13/debian/changelog debootstrap-1.0.14~0.1/debian/changelog
--- debootstrap-1.0.13/debian/changelog
Package: debootstrap
Version: 1.0.13
Severity: wishlist
Tags: patch
Two changes needed for supporting scratchbox2:
1) make chrooting optional for --second-stage - after all we are in the
new chroot, if / is defined as the target. To facialiate this, we convert
calls of chroot to $CHROOT and set
8 matches
Mail list logo
