Bug#548154: libsane: segfault in genesys, missing error check

2009-09-26 Thread Julien BLACHE
Tollef Fog Heen tfh...@err.no wrote:

Hi,

 it seems like there's a missing error check in genesys.c when
 SANE_DEBUG_LOG_RAW_DATA is enabled.  The attached patch fixes it for
 me.

Thanks for the patch, I've just applied it upstream. Updated packages
will follow shortly.

JB.

-- 
 Julien BLACHE - Debian  GNU/Linux Developer - jbla...@debian.org 
 
 Public key available on http://www.jblache.org - KeyID: F5D6 5169 
 GPG Fingerprint : 935A 79F1 C8B3 3521 FD62 7CC7 CD61 4FD7 F5D6 5169 



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#548154: libsane: segfault in genesys, missing error check

2009-09-24 Thread Tollef Fog Heen
Package: libsane
Version: 1.0.20-7
Severity: normal

Hi,

it seems like there's a missing error check in genesys.c when
SANE_DEBUG_LOG_RAW_DATA is enabled.  The attached patch fixes it for
me.

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing'), (50, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=nb_NO.UTF-8, LC_CTYPE=nb_NO.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libsane depends on:
ii  adduser  3.110   add and remove users and groups
ii  libavahi-client3 0.6.25-1Avahi client library
ii  libavahi-common3 0.6.25-1Avahi common library
ii  libc62.9-25  GNU C Library: Shared libraries
ii  libexif120.6.17-1library to parse EXIF files
ii  libgphoto2-2 2.4.6-1 gphoto2 digital camera library
ii  libgphoto2-port0 2.4.6-1 gphoto2 digital camera port librar
ii  libieee1284-30.2.11-5cross-platform library for paralle
ii  libjpeg626b-15   The Independent JPEG Group's JPEG 
ii  libsane-extras   1.0.20.2API library for scanners -- extra 
ii  libtiff4 3.9.1-1 Tag Image File Format (TIFF) libra
ii  libusb-0.1-4 2:0.1.12-13 userspace USB programming library
ii  libv4l-0 0.6.1-1 Collection of video4linux support 
ii  makedev  2.3.1-89creates device files in /dev
ii  udev 141-1.2 rule-based device node and kernel 

Versions of packages libsane recommends:
ii  sane-utils1.0.20-7   API library for scanners -- utilit

Versions of packages libsane suggests:
ii  avahi-daemon  0.6.25-1   Avahi mDNS/DNS-SD daemon
ii  hplip 3.9.4b-1   HP Linux Printing and Imaging Syst
pn  hpoj  none (no description available)

-- no debconf information

-- 
Tollef Fog Heen
UNIX is user friendly, it's just picky about who its friends are
--- sane-backends-1.0.20.orig/backend/genesys.c
+++ sane-backends-1.0.20/backend/genesys.c
@@ -4246,8 +4246,11 @@
 	   genesys_read_ordered_data: nothing more to scan: EOF\n);
   *len = 0;
 #ifdef SANE_DEBUG_LOG_RAW_DATA
-  fclose (rawfile);
-  rawfile = NULL;
+  if (rawfile != NULL)
+	{
+	  fclose (rawfile);
+	  rawfile = NULL;
+	}
 #endif
   return SANE_STATUS_EOF;
 }