Bug#551964: [pkg-mono-group] Bug#551964: libmono-corlib2.0-cil: One of DynamicMethod's Constructors ignores restrictedSkipVisibility

2009-12-06 Thread Mirco Bauer
Hi,

On Thu, 22 Oct 2009 08:28:14 +0300
Silviu Paragina bug-sub...@paragina.ro wrote:

 Package: libmono-corlib2.0-cil
 Version: 2.4.2.3+dfsg-2
 Severity: wishlist
 Tags: patch
 
 The constructor public DynamicMethod (string name, Type returnType,
 Type[] parameterTypes, bool restrictedSkipVisibility) ignores
 restrictedSkipVisibility.
 
 As a side effect some code won't function properly like DbLinq (which
 would alow use of linq to mysql/postgresql/etc)
 
 This bug has been resolved in upstream, but both my patch and the
 upstream version (they are virtually identical) don't do another
 check. Please see the description on the restrictedSkipVisibility
 parameter on http://msdn.microsoft.com/en-us/library/bb348332.aspx
 for details on the checks (please read them).
 
 I'm sending this in case some other people require the DbLinq library
 till 2.6 is out and into debian.

I have no issues with this patch as it's a simple one but it changes a
core component of Mono and thus I need to verify if this change is the
right one. Can you point to an upstream SVN commit which does
exactly this change or even better an upstream report about this?

In general, if you take changes from upstream SVN I will apply it, but
you need to tell me the commit id or the verbatim upstream patch
(full commit).

 
 
 I think I duplicated this bug post, sorry about that, first time
 using the reportbug application and I think I double clicked the
 forward button. Sorry sorry.

No duplicate received, everything is fine :)

PS: sorry for the late reply

-- 
Regards,

Mirco 'meebey' Bauer

PGP-Key ID: 0xEEF946C8

FOSS Developermee...@meebey.net  http://www.meebey.net/
PEAR Developermee...@php.net http://pear.php.net/
Debian Developer  mee...@debian.org  http://www.debian.org/



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#551964: [pkg-mono-group] Bug#551964: libmono-corlib2.0-cil: One of DynamicMethod's Constructors ignores restrictedSkipVisibility

2009-12-06 Thread Silviu Paragina


Mirco Bauer wrote:
 Hi,

 On Thu, 22 Oct 2009 08:28:14 +0300
 Silviu Paragina bug-sub...@paragina.ro wrote:

   
 Package: libmono-corlib2.0-cil
 Version: 2.4.2.3+dfsg-2
 Severity: wishlist
 Tags: patch

 The constructor public DynamicMethod (string name, Type returnType,
 Type[] parameterTypes, bool restrictedSkipVisibility) ignores
 restrictedSkipVisibility.

 As a side effect some code won't function properly like DbLinq (which
 would alow use of linq to mysql/postgresql/etc)

 This bug has been resolved in upstream, but both my patch and the
 upstream version (they are virtually identical) don't do another
 check. Please see the description on the restrictedSkipVisibility
 parameter on http://msdn.microsoft.com/en-us/library/bb348332.aspx
 for details on the checks (please read them).

 I'm sending this in case some other people require the DbLinq library
 till 2.6 is out and into debian.
 

 I have no issues with this patch as it's a simple one but it changes a
 core component of Mono and thus I need to verify if this change is the
 right one. Can you point to an upstream SVN commit which does
 exactly this change or even better an upstream report about this?

 In general, if you take changes from upstream SVN I will apply it, but
 you need to tell me the commit id or the verbatim upstream patch
 (full commit).

   


The same change was made in commit 138886 in july 2009, this is the only
change in the commit. This is the commit (copy/paste in windows)
Revision: 138886
Author: marek
Date: 01:07:01, 29 iulie 2009
Message:
2009-07-28  Marek Safar em...@address.com

* DynamicMethod.cs: Pass skipVisibility.


Modified : /trunk/mcs/class/corlib/System.Reflection.Emit/ChangeLog
Modified : /trunk/mcs/class/corlib/System.Reflection.Emit/DynamicMethod.cs

The changelog repeats the svn comment.

svn repository from: http://anonsvn.mono-project.com/source/trunk
from the -patch mono list:
http://archive.netbsd.se/?ml=mono-patchesa=2009-07t=11200615

Also big note there is a new attribute added in svn code [MonoTODO
(Visibility is not restricted)]
I'm guessing this is a mark that mono doesn't do some other checks
specified in the documentation about the calling assembly trust level
and the called assemblys trust level (when visibility checks are
actually skipped). On the .net framework the calling assembly must have
higher or equal trust level than the assemblyes where you are accessing
private/protected members, on mono, I think, I'm not sure, the trust
level of an assembly isn't implemented.

I can not find any reports, sorry.

   
 I think I duplicated this bug post, sorry about that, first time
 using the reportbug application and I think I double clicked the
 forward button. Sorry sorry.
 

 No duplicate received, everything is fine :)

 PS: sorry for the late reply
   
No problem


Silviu




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org