Bug#554349: rred and stack overflows

2009-11-30 Thread Goswin von Brederlow
Robert Lemmen rober...@semistable.com writes: On Wed, Nov 25, 2009 at 08:08:36PM +0100, David Kalnischkies wrote: Really, i don't think it is a stackoverflow as it fails at a to prominent cmd count... I have rewritten a few parts of rred to use long and more sane return values and it patches

Bug#554349: rred and stack overflows

2009-11-25 Thread Robert Lemmen
this is most certainly related to the way rred currently works, it uses a tail recursion on the stack to reverse the diff elements. it would be easy to change that to use an iteration instead, if you want that just holler and i'll change rred.cc, but i think the real problem is that we should

Bug#554349: rred and stack overflows

2009-11-25 Thread David Kalnischkies
2009/11/25 Robert Lemmen rober...@semistable.com: this is most certainly related to the way rred currently works, it uses a tail recursion on the stack to reverse the diff elements. Really, i don't think it is a stackoverflow as it fails at a to prominent cmd count... I have rewritten a few

Bug#554349: rred and stack overflows

2009-11-25 Thread Robert Lemmen
On Wed, Nov 25, 2009 at 08:08:36PM +0100, David Kalnischkies wrote: Really, i don't think it is a stackoverflow as it fails at a to prominent cmd count... I have rewritten a few parts of rred to use long and more sane return values and it patches the file now just fine. :) ok, excellent. but