Bug#560252: Bug#559136: Bug#560252: band-aid fix

2010-01-11 Thread Keith Packard 
On Mon, 11 Jan 2010 08:38:26 +0100, Andreas Barth a...@not.so.argh.org wrote:

 Could you please bump the dependency on defoma to = 0.11.10-4 with
 the next upload, as we still have badly built packages in the
 archive?

I'll set a build dependency on 0.11.10-4 but leave the suggests at 0.7.0
as this is strictly a packaging issue and not a run-time issue. Make
sense to you?

-- 
keith.pack...@intel.com


pgpFdZ46E7gzm.pgp
Description: PGP signature

Bug#559136: Bug#560252: Bug#559136: Bug#560252: band-aid fix

2010-01-11 Thread Andreas Barth 
* Keith Packard (kei...@keithp.com) [100111 20:32]:
 On Mon, 11 Jan 2010 08:38:26 +0100, Andreas Barth a...@not.so.argh.org 
 wrote:
 
  Could you please bump the dependency on defoma to = 0.11.10-4 with
  the next upload, as we still have badly built packages in the
  archive?
 
 I'll set a build dependency on 0.11.10-4 but leave the suggests at 0.7.0
 as this is strictly a packaging issue and not a run-time issue. Make
 sense to you?

Absolutly. Thanks.


Cheers,
Andi



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#560252: Bug#559136: Bug#560252: band-aid fix

2010-01-10 Thread Andreas Barth 
Hi,

* Cyril Brulebois (k...@debian.org) [091231 17:49]:
 Keith Packard kei...@keithp.com (31/12/2009):
  Right, I didn't realize there was a bug in defoma as well which was
  causing this problem; having found an obvious bug in my packaging, I
  thought that would have fixed the bug; sorry for not testing it
  properly.
 
 Oh well, since in the end, final fixes are flowing in quite quickly,
 we shouldn't be have many more troubles with those defoma thingies. :)

Could you please bump the dependency on defoma to = 0.11.10-4 with
the next upload, as we still have badly built packages in the
archive? (They probably don't hurt as long as all chroots have defoma
installed, but well - or just conflict with 0.11.10-3. Nothing too
urgent, but should just really be fixed.)


Cheers,
Andi



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#559136: Bug#560252: band-aid fix

2009-12-31 Thread Cyril Brulebois 
Keith Packard kei...@keithp.com (30/12/2009):
 I haven't received any mail about RC bugs today, and can't find any
 through the bugs.debian.org web interface.

I meant #559136 and #560252, opened for some weeks.

   2. optionally fix them;
 
 I'm trying, but it looks like dh_installdefoma is just plain busted
 though. It does things like:
 
   test -x `which defoma-app`  defoma-app clean fontconfig
 
 which is clearly broken when defoma-app is not installed (as test -x
 with no argument returns success)

Indeed (and for those following at home: #563121).

Still, losing Riku's band-aid wasn't nice. Anyway, now that the root
issue's being addressed, the band-aid shouldn't be necessary for too
much time.

  I've just uploaded a package re-introducing Riku's changes to prevent
  buildds to be fucked again after a couple of builds (which I repeat
  needs manual intervention, which is not nice).
 
 Thanks; I've got a defoma patch that I'm testing here; can you suggest a
 method to test the resulting fontconfig patches built with that change?

What I did to check how my fontconfig upload was going was:
 - grab my nearest chroot, possibly minimal-like;
 - make sure defoma wasn't installed;
 - copy all fontconfig binaries there;
 - dpkg -i /tmp/*.deb;
 - apt-get -f install

That's how I noticed the set +e bits, commands that weren't found, and
made sure it wasn't making the postinst script fail. I'm probably
going to do so with the (new) defoma patch I've just written a mail
about in the other bug. I'll keep you posted.

Mraw,
KiBi.


signature.asc
Description: Digital signature

Bug#560252: Bug#559136: Bug#560252: band-aid fix

2009-12-31 Thread Keith Packard 
On Thu, 31 Dec 2009 09:10:49 +0100, Cyril Brulebois k...@debian.org wrote:

 Still, losing Riku's band-aid wasn't nice. Anyway, now that the root
 issue's being addressed, the band-aid shouldn't be necessary for too
 much time.

Right, I didn't realize there was a bug in defoma as well which was
causing this problem; having found an obvious bug in my packaging, I
thought that would have fixed the bug; sorry for not testing it
properly.

I'll follow your suggested testing method before uploading a new version
(with a suitable ACK for the current NMU).

-- 
keith.pack...@intel.com


pgp1OS1io0VFc.pgp
Description: PGP signature

Bug#560252: Bug#559136: Bug#560252: band-aid fix

2009-12-31 Thread Cyril Brulebois 
Keith Packard kei...@keithp.com (31/12/2009):
 Right, I didn't realize there was a bug in defoma as well which was
 causing this problem; having found an obvious bug in my packaging, I
 thought that would have fixed the bug; sorry for not testing it
 properly.

Oh well, since in the end, final fixes are flowing in quite quickly,
we shouldn't be have many more troubles with those defoma thingies. :)

 I'll follow your suggested testing method before uploading a new
 version (with a suitable ACK for the current NMU).

Just to be clear, I don't really mind dropping some changelog entries,
it's not about being famous or whatever. It was just too bad to see
those chroot breakages happen again. ;)

Mraw,
KiBi.


signature.asc
Description: Digital signature

Bug#560252: band-aid fix

2009-12-30 Thread Kurt Roeckx 
found 559136 2.8.0-1
thanks

On Mon, Dec 14, 2009 at 12:51:42PM +0200, Riku Voipio wrote:
 Hi,
 
 Here is the debdiff of the quick fix I just uploaded. This is _not_ intended
 as the correct permanent fix, but rather something to keep the buildd chroots
 from breaking several times a day... hence the emergency.

It's broken again:
Setting up fontconfig (2.8.0-1) ...
/var/lib/dpkg/info/fontconfig.postinst: 27: defoma-app: not found
dpkg: error processing fontconfig (--configure):
 subprocess installed post-installation script returned error exit status 127
[...]
Removing fontconfig ...
/var/lib/dpkg/info/fontconfig.prerm: 13: defoma-app: not found
dpkg: error processing fontconfig (--purge):
 subprocess installed pre-removal script returned error exit status 127


Kurt




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#559136: Bug#560252: band-aid fix

2009-12-30 Thread Cyril Brulebois 
Kurt Roeckx k...@roeckx.be (30/12/2009):
  Here is the debdiff of the quick fix I just uploaded. This is
  _not_ intended as the correct permanent fix, but rather something
  to keep the buildd chroots from breaking several times a
  day... hence the emergency.
 It's broken again:
 Setting up fontconfig (2.8.0-1) ...
 /var/lib/dpkg/info/fontconfig.postinst: 27: defoma-app: not found
 dpkg: error processing fontconfig (--configure):
  subprocess installed post-installation script returned error exit status 127
 [...]
 Removing fontconfig ...
 /var/lib/dpkg/info/fontconfig.prerm: 13: defoma-app: not found
 dpkg: error processing fontconfig (--purge):
  subprocess installed pre-removal script returned error exit status 127

Same cause, same effect.

Please, Keith, could you, as package maintainer, please:
 1. reply to RC bugs filed against your packages;
 2. optionally fix them;
 3. or acknowledge NMUs instead of trashing the related changes, and
triggering again RC bugs that were worked around, leading to
uninstallable packages, broken buildds, etc.

I've just uploaded a package re-introducing Riku's changes to prevent
buildds to be fucked again after a couple of builds (which I repeat
needs manual intervention, which is not nice).

Please find the source debdiff attached.

Mraw,
KiBi.
diff -u fontconfig-2.8.0/debian/changelog fontconfig-2.8.0/debian/changelog
--- fontconfig-2.8.0/debian/changelog
+++ fontconfig-2.8.0/debian/changelog
@@ -1,3 +1,12 @@
+fontconfig (2.8.0-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Re-apply Riku's band-aid (introduced in 2.6.0-4.1 and 2.6.0-4.2, which
+were not ACK'd) to unbreak the buildds again: Use “set +e” in postinst
+and prerm instead of “set -e” (Closes: #559136).
+
+ -- Cyril Brulebois k...@debian.org  Wed, 30 Dec 2009 23:36:50 +0100
+
 fontconfig (2.8.0-1) unstable; urgency=low
 
   * upstream release of 2.8
diff -u fontconfig-2.8.0/debian/fontconfig.postinst fontconfig-2.8.0/debian/fontconfig.postinst
--- fontconfig-2.8.0/debian/fontconfig.postinst
+++ fontconfig-2.8.0/debian/fontconfig.postinst
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-set -e
+set +e
 
 if [ $1 = triggered ]; then
   # Force regeneration of all fontconfig cache files.
@@ -10,8 +10,8 @@
 fi
 
 if [ $1 = configure ]; then
-  # If defoma is installed, ensure Defoma subst file exists, with some default substitutions
-  if which defoma-subst  /dev/null  ! defoma-subst check-rule fontconfig; then
+  # Ensure Defoma subst file exists, with some default substitutions
+  if ! defoma-subst check-rule fontconfig; then
 defoma-subst new-rule fontconfig \
   'serif --GeneralFamily,* Roman --Shape Serif Upright --Weight Medium' \
   'sans-serif --GeneralFamily,* SansSerif --Shape NoSerif Upright --Weight Medium' \
only in patch2:
unchanged:
--- fontconfig-2.8.0.orig/debian/fontconfig.prerm
+++ fontconfig-2.8.0/debian/fontconfig.prerm
@@ -0,0 +1,7 @@
+#! /bin/sh
+
+set +e
+
+#DEBHELPER#
+
+exit 0


signature.asc
Description: Digital signature

Bug#559136: Bug#560252: band-aid fix

2009-12-30 Thread Keith Packard 
On Thu, 31 Dec 2009 00:09:42 +0100, Cyril Brulebois k...@debian.org wrote:

  1. reply to RC bugs filed against your packages;

I haven't received any mail about RC bugs today, and can't find any
through the bugs.debian.org web interface.

  2. optionally fix them;

I'm trying, but it looks like dh_installdefoma is just plain busted
though. It does things like:

test -x `which defoma-app`  defoma-app clean fontconfig

which is clearly broken when defoma-app is not installed (as test -x
with no argument returns success)

  3. or acknowledge NMUs instead of trashing the related changes, and
 triggering again RC bugs that were worked around, leading to
 uninstallable packages, broken buildds, etc.

I rashly assumed that the only issue with defoma was in the code I had
written, not in that added by dh_installdefoma.

 I've just uploaded a package re-introducing Riku's changes to prevent
 buildds to be fucked again after a couple of builds (which I repeat
 needs manual intervention, which is not nice).

Thanks; I've got a defoma patch that I'm testing here; can you suggest a
method to test the resulting fontconfig patches built with that change?

-- 
keith.pack...@intel.com


pgpJ0pUS7eYhu.pgp
Description: PGP signature

Bug#560252: band-aid fix

2009-12-14 Thread Riku Voipio 
Hi,

Here is the debdiff of the quick fix I just uploaded. This is _not_ intended
as the correct permanent fix, but rather something to keep the buildd chroots
from breaking several times a day... hence the emergency.



diff -u fontconfig-2.6.0/debian/fontconfig.postinst fontconfig-2.6.0/debian/fontconfig.postinst
--- fontconfig-2.6.0/debian/fontconfig.postinst
+++ fontconfig-2.6.0/debian/fontconfig.postinst
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-set -e
+set +e
 
 if [ $1 = triggered ]; then
   # Force regeneration of all fontconfig cache files.
diff -u fontconfig-2.6.0/debian/changelog fontconfig-2.6.0/debian/changelog
--- fontconfig-2.6.0/debian/changelog
+++ fontconfig-2.6.0/debian/changelog
@@ -1,3 +1,11 @@
+fontconfig (2.6.0-4.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * emergency band-aid fix to avoid messing setup on install/remove when
+defoma is not installed, Closes: #559136, #560252, #559348
+
+ -- Riku Voipio riku.voi...@iki.fi  Mon, 14 Dec 2009 10:42:40 +0200
+
 fontconfig (2.6.0-4) unstable; urgency=low
 
   * fontconfig.{triggers,postinst}: register a trigger to automatically 
only in patch2:
unchanged:
--- fontconfig-2.6.0.orig/debian/fontconfig.prerm
+++ fontconfig-2.6.0/debian/fontconfig.prerm
@@ -0,0 +1,5 @@
+#! /bin/sh
+
+set +e
+
+#DEBHELPER#