Bug#562506: init scripts should not use set -e

2010-06-03 Thread Russ Allbery
Guillem Jover guil...@debian.org writes: On Tue, 2010-06-01 at 10:42:35 -0700, Russ Allbery wrote: Here is proposed wording, which hopefully reflects the subsequent discussion. I'm looking for seconds. [...] Seconded. Thanks! That's two, so I'm merging for the next release. -- Russ

Bug#562506: init scripts should not use set -e

2010-06-02 Thread Raphael Hertzog
On Tue, 01 Jun 2010, Russ Allbery wrote: Here is proposed wording, which hopefully reflects the subsequent discussion. I'm looking for seconds. [...] p + Be careful of using ttset -e/tt in fileinit.d/file + scripts. Writing correct fileinit.d/file scripts requires

Bug#562506: init scripts should not use set -e

2010-06-02 Thread Guillem Jover
On Tue, 2010-06-01 at 10:42:35 -0700, Russ Allbery wrote: Here is proposed wording, which hopefully reflects the subsequent discussion. I'm looking for seconds. diff --git a/policy.sgml b/policy.sgml index d16df70..1871d4c 100644 --- a/policy.sgml +++ b/policy.sgml @@ -6011,7 +6011,7 @@

Bug#562506: init scripts should not use set -e

2010-06-01 Thread Russ Allbery
Russ Allbery r...@debian.org writes: Currently, Debian Policy makes a general statement that all Bourne shell scripts should start with set -e and does not (so far as I can see) make an exception for init scripts. I've seen several init scripts use set -e, which is usually a bad idea. It

Bug#562506: init scripts should not use set -e

2010-03-03 Thread Goswin von Brederlow
Russ Allbery r...@debian.org writes: martin f krafft madd...@debian.org writes: I still think set -e is a good idea, but I realise it boils down to preference. If your experience is representative, then it's probably better to advocate not setting set -e in init scripts. What about

Bug#562506: init scripts should not use set -e

2010-03-02 Thread martin f krafft
also sprach Russ Allbery r...@debian.org [2010.03.01.0744 +0100]: I think lsb-base should be fixed, but I also think set -e in an init script is a bad idea. I would argue that specifically because running commands that fail is a normal and expected init script operation, unlike nearly every

Bug#562506: init scripts should not use set -e

2010-03-02 Thread Russ Allbery
martin f krafft madd...@debian.org writes: I still think set -e is a good idea, but I realise it boils down to preference. If your experience is representative, then it's probably better to advocate not setting set -e in init scripts. What about maintainer scripts? It's almost always

Bug#562506: init scripts should not use set -e

2010-02-28 Thread martin f krafft
also sprach Bastian Blank wa...@debian.org [2010.02.27.1320 +0100]: set -e produces problems like this: #546743. lsb-base should not get away with because we write shitty shell code and don't do proper error handling, we expect everyone else to do alike. If set -e is causing problems, remember

Bug#562506: init scripts should not use set -e

2010-02-28 Thread Russ Allbery
martin f krafft madd...@debian.org writes: also sprach Bastian Blank wa...@debian.org [2010.02.27.1320 +0100]: set -e produces problems like this: #546743. lsb-base should not get away with because we write shitty shell code and don't do proper error handling, we expect everyone else to do

Bug#562506: init scripts should not use set -e

2010-02-27 Thread Bastian Blank
On Mon, Dec 28, 2009 at 03:44:53PM -0800, Russ Allbery wrote: That seems reasonable, although I think we should also point out the problems with using set -e when starting a daemon, namely that you need to be sure to wrap the start-stop-daemon invocation in a conditional so that you can

Bug#562506: init scripts should not use set -e

2010-02-26 Thread Vincent Danjean
On 29/12/2009 00:44, Russ Allbery wrote: Steve Langasekvor...@debian.org writes: I don't think that 'set -e' is wrong for init scripts, so much as the LSB init script interfaces' requirement of 'set +e' is an unfortunate design flaw. Still, as many init scripts are using

Bug#562506: init scripts should not use set -e

2009-12-28 Thread Steve Langasek
On Thu, Dec 24, 2009 at 04:07:48PM -0800, Russ Allbery wrote: Currently, Debian Policy makes a general statement that all Bourne shell scripts should start with set -e and does not (so far as I can see) make an exception for init scripts. I've seen several init scripts use set -e, which is

Bug#562506: init scripts should not use set -e

2009-12-28 Thread Russ Allbery
Steve Langasek vor...@debian.org writes: I don't think that 'set -e' is wrong for init scripts, so much as the LSB init script interfaces' requirement of 'set +e' is an unfortunate design flaw. Still, as many init scripts are using /lib/lsb/init-functions nowadays, I think it's worth calling

Bug#562506: init scripts should not use set -e

2009-12-25 Thread Guillem Jover
Hi! On Thu, 2009-12-24 at 16:07:48 -0800, Russ Allbery wrote: Package: debian-policy Version: 3.8.3.0 Severity: minor Currently, Debian Policy makes a general statement that all Bourne shell scripts should start with set -e and does not (so far as I can see) make an exception for init

Bug#562506: init scripts should not use set -e

2009-12-24 Thread Russ Allbery
Package: debian-policy Version: 3.8.3.0 Severity: minor Currently, Debian Policy makes a general statement that all Bourne shell scripts should start with set -e and does not (so far as I can see) make an exception for init scripts. I've seen several init scripts use set -e, which is usually a