tags 568618 + patch
thanks
* Use Built-in functions for atomic memory access instead of
hard-coded assembler. Closes: #568618.
On 09.02.2010 09:48, Thomas Koch wrote:
Hi Matthias,
could you be so kind to look into this, please?
Source: zookeeper
Version: 3.2.2+dfsg3-2
Severity: serious
There was an error while trying to autobuild your package:
sbuild (Debian sbuild) 0.59.1 (24 Jan 2010) on debian-31.osdl.marist.edu
[...]
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests
-I./generated -DTHREADED -g -O2 -MT libzkmt_la-mt_adaptor.lo -MD -MP -MF
.deps/libzkmt_la-mt_adaptor.Tpo -c src/mt_adaptor.c -fPIC -DPIC -o
.libs/libzkmt_la-mt_adaptor.o src/mt_adaptor.c: Assembler messages:
src/mt_adaptor.c:352: Error: Unrecognized opcode: `lock'
make[3]: *** [libzkmt_la-mt_adaptor.lo] Error 1
--- zookeeper-3.2.2+dfsg3.orig/src/c/src/mt_adaptor.c
+++ zookeeper-3.2.2+dfsg3/src/c/src/mt_adaptor.c
@@ -349,11 +349,7 @@
int32_t fetch_and_add(volatile int32_t* operand, int incr)
{
int32_t result;
-asm __volatile__(
- lock xaddl %0,%1\n
- : =r(result), =m(*(int *)operand)
- : 0(incr)
- : memory);
+result = __sync_fetch_and_add(operand, incr);
return result;
}
